From patchwork Mon Nov 7 09:54:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 119517 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E652AA0093; Mon, 7 Nov 2022 10:54:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C961D40156; Mon, 7 Nov 2022 10:54:52 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2068.outbound.protection.outlook.com [40.107.101.68]) by mails.dpdk.org (Postfix) with ESMTP id 0D5B540151 for ; Mon, 7 Nov 2022 10:54:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mg/cX0j/F8QLYsj9XMAkrNpmH/2VsIKBmr4bT7i3SkS6N5xSiWVxWkyfDcrKqdReCXwjj1UOnCSuGE/nm+8T2U/4+hEqwjOS17silLQkOfUr5g4MSXxiebLQvRWk71Hr2JI63ffvomepGCv70yi6tHvJDjG4C7cYBhWyqBJP7F5s1D7AYYoWc8QGvuV2P5Ox+jaBLvhDnviVQPQkKnWbl+wRI5nIvPh2bsX59+1NLyF6sSaAn62jI69kC3C3rQX2XC+rykUuj3+YYPqMj34Ea6PMLoN1ubjbqFYVxjfVydc83XZLo8En6UK7Q3a3KNLcUdtJT9fsp7+3JglfRGppZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7016N9cQChHsNNtgbdWdkBi5Yb0RcX6gHVTrPytrGOs=; b=NRvMxKQZGfhMgjP4YkXGM+N9hjLFqskF0NrUUBQ8lSd59Lq5oqPNaipkIsC3+e3KXctl8S9mL6GyUG7uND0qWlGU/3oTDd0Ve+qamqWXrPgvA93aZYyx1igjs6OqGMPX7/m7LEtRRQmHuyQRfj8Q9lUW2oko1ADDEpw9tIKs+QPHZzv3R8Uuc+1XrukhKZyn98YHW4g5+mOlb3Xkqo7WPUIgdXwzXmuvMTVEPJYBRC62UhPQKJJZuXENvhcoOa1Qx7ioiKYqFZZ/Zx4eZDEfk1Lslyt7JsYDnSh1rVpxrPZlGyM2gfOeIbfug0+m28f9oAERA96MbGRdfMIM1ZuUrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7016N9cQChHsNNtgbdWdkBi5Yb0RcX6gHVTrPytrGOs=; b=Z/rfujpk3wGCUHhlKjJxNJy1WDWPyQKTJ04Xjh90NVm1I6esK/qahPTcZMcuAlXRuAb519DEk8vw1XWEp1bcpLdWzmApwztkUNoLkA7hkJp69cG3veP1rSlEv9mM7Sn66RucaAlPnIqVdvCE7T6SeWjRwvrcQZyaVOgidJFJX9+o4rBvdO535qqUDBnduvuiftyprD6kp25B/szouq0YePldtspwCrca7e4Mol8Q5XgLI+i6HeHdlNEW7UmjzpKTNQbzxpIEQyvm7mvbnMBQrhHXsk6ygSP/UfJl1KcCHp2jogQKJjcC37G2l6/wmMz22hOLBdYPN2BYMOexbL1v4A== Received: from MW4PR04CA0296.namprd04.prod.outlook.com (2603:10b6:303:89::31) by SJ0PR12MB6805.namprd12.prod.outlook.com (2603:10b6:a03:44f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 09:54:49 +0000 Received: from CO1NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::8e) by MW4PR04CA0296.outlook.office365.com (2603:10b6:303:89::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Mon, 7 Nov 2022 09:54:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT115.mail.protection.outlook.com (10.13.174.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 09:54:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 7 Nov 2022 01:54:38 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 01:54:36 -0800 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH 4/4] net/mlx5/hws: fix possible negative return on sq create Date: Mon, 7 Nov 2022 11:54:18 +0200 Message-ID: <20221107095418.13891-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221103125146.7291-1-valex@nvidia.com> References: <20221103125146.7291-1-valex@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT115:EE_|SJ0PR12MB6805:EE_ X-MS-Office365-Filtering-Correlation-Id: a8b35b0e-f5c6-4140-166f-08dac0a61be6 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: phqrvWR87dbjhDSWngk1PdkgRX9XMxZqPeoXOxpWg1LVO5MY+2YEraokFVbkA9mZajdQsdgcjil4OjhCakPnqXEcYr+1Ed6ZsEsQ487eo/sKuolaWDajjfzgVsR8eCkfEteYP17VZgOZ8Zcs+CwD9kv1pYaz/3g98n74g5AvJnIZ/LkTY9QqeOwE2Q6f9F3g3EcKcGN7jU9mbqcc3qJvuWtDJ/DgEi/LOgxoSgjvyEgUj9A3qFpsQHTg0igWw7Fzo9AZ5ERb8jf4Zp0YaeeZ0oZ1HyKNi4HMe7nPc41+CJwQmWf7D1SbfgmIJ5+8jCGuFgC8S/lfy437rQ6Zjv0CsZURn8LNF9CmQBbEVI5kPfKwfhGFe37RO5t6z4noUNn1E17rSgrXe32Zgi0ttCow83LslMZl0sPtYphVIJk2rzRaMQjy+cei236CBVm3t7M6ZIx7IPkcuODl7uiUizuOghjiXEUfYWAO43n1E8zkrZa+syQk5Adne1njdV74UPyveDzb9Jd7hMHeun0gqID1OCQg63atmhPhF+vsFRgVZGzc84W5scfI4LRS/Grky1Jes7Qhr2PWLmjsHg+CvRu4Rzkn4pKaxVgD4kKXQxvjZfFBqcK4K6R6xDlvdpVCuOwkrXkjvK/oI1LubzwA1ajn264T1K7IO67L86GjmDJTUxSbMUX7EAUB9r7fCRMuyRajtqDhD6s0Jwo1o2Oof4JSRjAlbjKNczhAZgyiXXTKNJXcXWZcC4F1v16synoKO7yF1UAoSG2g9PHx2t0zzrEUvA== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(2906002)(110136005)(426003)(83380400001)(47076005)(6286002)(8936002)(36756003)(40460700003)(86362001)(41300700001)(5660300002)(8676002)(70586007)(36860700001)(70206006)(40480700001)(6636002)(55016003)(4326008)(54906003)(316002)(82740400003)(7696005)(6666004)(2616005)(26005)(336012)(107886003)(82310400005)(7636003)(356005)(1076003)(478600001)(186003)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 09:54:49.0108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8b35b0e-f5c6-4140-166f-08dac0a61be6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6805 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The sysconf call can return a negative value (-1) on failure this will lead to posix_memalign to fail. This is not a realistic case which was found by the static checkers. Coverity issue: 381674 Fixes: 3eb7488 ("net/mlx5/hws: add send layer") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 26904a9040..1e9953a38f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -524,6 +524,7 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, size_t sq_log_buf_sz; size_t buf_aligned; size_t sq_buf_sz; + size_t page_size; size_t buf_sz; int err; @@ -532,8 +533,9 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, sq_buf_sz = 1 << (sq_log_buf_sz + log2above(MLX5_SEND_WQE_BB)); sq->reg_addr = queue->uar->reg_addr; - buf_aligned = align(sq_buf_sz, sysconf(_SC_PAGESIZE)); - err = posix_memalign((void **)&sq->buf, sysconf(_SC_PAGESIZE), buf_aligned); + page_size = sysconf(_SC_PAGESIZE); + buf_aligned = align(sq_buf_sz, page_size); + err = posix_memalign((void **)&sq->buf, page_size, buf_aligned); if (err) { rte_errno = ENOMEM; return err;