Message ID | 20221024132823.3246243-1-michaelba@nvidia.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Raslan Darawsheh |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C729A034C; Mon, 24 Oct 2022 15:28:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC771427F0; Mon, 24 Oct 2022 15:28:45 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2077.outbound.protection.outlook.com [40.107.101.77]) by mails.dpdk.org (Postfix) with ESMTP id F00CC40A8B for <dev@dpdk.org>; Mon, 24 Oct 2022 15:28:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3HhoWT2g5LeiRj0mEC7srGq8Yh/SRp831cr+SKHPgIp+Lif8afCOn1mqbUgOjSxIV36tltS4haG78XVJiSzdZVzoyTi4ibKFFBay/3c3JSV+hGq6U47qSSpGuOIabYNG1yH4ePb0B4W4ud5jjV3ceo+snRiyPbBbPRYv31vqPWshOQytOynKNWSkxbf9MDUGpzbX6Ik2XY3rdOtZQFD+oH09Ua58anKNaIE45SjhftYGAhFtoK7Ks3KC9E6YT2VfBme1wCcy2ifdu11neq2K34UCrbxWaHUUKn7sCnAZFCGck2+1p2NRJLIJrnsLKvlFDRjcfymq+BZvbOuJ8MP+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t+SfGn1KXm50TQPk/ctqTpmY/9kPoFEKcd38aS0+pAk=; b=ALoO/scYShZrNHI1h/EYci6JvkFOC+flxGuDxT0AVQ8qpW16N3LDqnNJdLxSYgr/tGPPZLRopouvzOWhHm7hnOCQfMLI2443OY21CBsU0gt9lRpdyiIP5Hws89KFYDKO7/8V5Ue+dMI8uIU/S0dKPB+/gR+8Wi+ReDvQZnFmnk6jSOi5WxGW68iiMjjZUif0fNqz21LZeJwekBK4mSlvAG2jXjFuWGi4E2HtG5IXpW3tMh4Pp7bKdbR6RjNwiZ5JBCGzkycJhY4x6xyDZIVs6234KlBCeYKzwGxgm1EFgA7ykfX6VqGAU2IJCBzBqbT108yEAJt4+EIcW3DDT+2pUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+SfGn1KXm50TQPk/ctqTpmY/9kPoFEKcd38aS0+pAk=; b=r9r6NKqs/Gh79ildyTIdB7X/f4ON8qpWz9vDwEuoTZ9N7SaIjhUucjsM3iGmb2lFUJY9mmkOwD3nHNCcRfzcihJaM1TIUG2w0pcqWplQXhPsTiVXFI2hwxFWXSvYkYh2Yya298J3M8Ef7WZjXItgNm2pW7xy1RFXn6v2DovfLSOguYbvaxPQ8YIDBsQs2S/JWgkmWacQSp4XQEnvSOS334hKzbohhvxxheWaaWkEUFJ5+YwWBFHV6P79owF/CHZV3uTkIOip2T2A3MOTDJP/GTpP+OZ8mDxtRD6v3dhzuiCX6IgrHfhP7OkaC68YnRW4eeKHDMY8Y5e5bJswUuEg5Q== Received: from MW4PR02CA0016.namprd02.prod.outlook.com (2603:10b6:303:16d::22) by BL3PR12MB6593.namprd12.prod.outlook.com (2603:10b6:208:38c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 24 Oct 2022 13:28:41 +0000 Received: from CO1NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:303:16d:cafe::b9) by MW4PR02CA0016.outlook.office365.com (2603:10b6:303:16d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.28 via Frontend Transport; Mon, 24 Oct 2022 13:28:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT084.mail.protection.outlook.com (10.13.174.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.16 via Frontend Transport; Mon, 24 Oct 2022 13:28:40 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 24 Oct 2022 06:28:30 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 24 Oct 2022 06:28:29 -0700 Received: from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29 via Frontend Transport; Mon, 24 Oct 2022 06:28:28 -0700 From: Michael Baum <michaelba@nvidia.com> To: <dev@dpdk.org> CC: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <michaelba@nvidia.com> Subject: [PATCH] net/mlx5: fix wrong free function in HWS AGE info Date: Mon, 24 Oct 2022 16:28:23 +0300 Message-ID: <20221024132823.3246243-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT084:EE_|BL3PR12MB6593:EE_ X-MS-Office365-Filtering-Correlation-Id: 06bb00a0-5c1a-4f5d-074c-08dab5c3aa67 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qHahTPB5dLWFAQnzsyIT3WYPzS1NryOmkAM51ETd4ZMOaT8LMx8p5iO6lol8Vgf3bWNxlA1FzT76+tEu5bC4jpFLnfRG7glMPHgSKrBTLy77VpwtYx6hAITl7U3Kr7S9iVELrtyQHa1HX0wLO87oBXsy0TbLx5O8Qxe0Rp0UR+5uf7oz+QEYX+1bSyCK81xJJdJWZkqSQA5yuKTjIYOsX9T8Iw/jzaJpzVnfASN11m1AaKA6/mF/P3DBqs1Gq9gzC+nMpd53KiNZtjM3VGum5qS4VtrregjTj6xjzwSSd0q36Xl+W0fE8khG6V6FoEuVFM1aq5zXOOnIagY/z8YwDg2Fj1FQ6rfR0kf0zc5hkkKRgf8+kLc8Qqb/wftMhwric1Ko0TbzkVqlOyo+UqtDxFJWEh3QSyrsak2kmV/wyE3PVlU4v7dtg3FCwYO6jWuE68Qf1MdFHscJTqM8tEdXH6TWcZE+MpnyajMCiUeNbhz3NK2bHOE96THnJveKot1c6ThxWNjrVsV0c6EiviJr9unf+HqL3ZXhI8ttLpupc3UjbjXU1liSLE1u3c2JpNsTAsRhfGIfE+Ni90cYNDoZsQIGsJyAMVzGBysSV7WOGzEy78cUDjPOFpCAolzSrGRyH5NpA/UmtVsT0PTn/E9i5GKCvdrLfF5aqL+Gwz+X/VQg9AH/v00X8cl9Vorf2piptQyd2aIq0Bw04FThbHM60heXw13A7cE7DEbCC1CqVprOj95ZS9xju/bXc0LhVFjVJrMwI1MMDxXRKO1Zuf4TCw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(2906002)(70206006)(86362001)(82740400003)(7636003)(2616005)(1076003)(36860700001)(356005)(8936002)(54906003)(107886003)(426003)(4744005)(82310400005)(47076005)(83380400001)(186003)(8676002)(40480700001)(316002)(40460700003)(41300700001)(6666004)(6916009)(478600001)(336012)(7696005)(26005)(70586007)(5660300002)(4326008)(55016003)(36756003)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2022 13:28:40.7538 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06bb00a0-5c1a-4f5d-074c-08dab5c3aa67 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6593 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net/mlx5: fix wrong free function in HWS AGE info
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | warning | apply issues |
ci/iol-testing | warning | apply patch failure |
Commit Message
Michael Baum
Oct. 24, 2022, 1:28 p.m. UTC
In AGE info initialization, the mlx5_hws_q_age_info structure is allocated by "mlx5_malloc" function. However, in case of failure, this structure is released by "rte_free". This patch changes it to use "mlx5_free". Fixes: 32c98171674f ("net/mlx5: add HWS AGE action support") Cc: michaelba@nvidia.com Signed-off-by: Michael Baum <michaelba@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- drivers/net/mlx5/mlx5_hws_cnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, > -----Original Message----- > From: Michael Baum <michaelba@nvidia.com> > Sent: Monday, October 24, 2022 4:28 PM > To: dev@dpdk.org > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh > <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Michael > Baum <michaelba@nvidia.com> > Subject: [PATCH] net/mlx5: fix wrong free function in HWS AGE info > > In AGE info initialization, the mlx5_hws_q_age_info structure is allocated by > "mlx5_malloc" function. > > However, in case of failure, this structure is released by "rte_free". > > This patch changes it to use "mlx5_free". > > Fixes: 32c98171674f ("net/mlx5: add HWS AGE action support") > Cc: michaelba@nvidia.com > > Signed-off-by: Michael Baum <michaelba@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> Patch squashed into relevant commit in next-net-mlx, Kindest regards, Raslan Darawsheh
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 9c37700f94..b8ce69af57 100644 --- a/drivers/net/mlx5/mlx5_hws_cnt.c +++ b/drivers/net/mlx5/mlx5_hws_cnt.c @@ -1100,7 +1100,7 @@ mlx5_hws_age_info_init(struct rte_eth_dev *dev, uint16_t nb_queues, MLX5_ASSERT(strict_queue); while (qidx--) rte_ring_free(age_info->hw_q_age->aged_lists[qidx]); - rte_free(age_info->hw_q_age); + mlx5_free(age_info->hw_q_age); return -1; }