[v1] net/ice: fix format overflow warning for meson build

Message ID 20221020032101.1932275-1-stevex.yang@intel.com (mailing list archive)
State Not Applicable, archived
Delegated to: Qi Zhang
Headers
Series [v1] net/ice: fix format overflow warning for meson build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation warning apply issues

Commit Message

Steve Yang Oct. 20, 2022, 3:21 a.m. UTC
  ‘__builtin___sprintf_chk’ may write a terminating nul past the end of
the destination [-Werror=format-overflow=]

Enlarge string size to avoid this warning.

Fixes: f2a3245e7aec ("net/ice: support ddp dump switch rule binary")

Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
 drivers/net/ice/ice_ddp_package.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Qi Zhang Oct. 20, 2022, 5:02 a.m. UTC | #1
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Thursday, October 20, 2022 11:21 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>
> Subject: [PATCH v1] net/ice: fix format overflow warning for meson build
> 
> ‘__builtin___sprintf_chk’ may write a terminating nul past the end of the
> destination [-Werror=format-overflow=]
> 
> Enlarge string size to avoid this warning.
> 
> Fixes: f2a3245e7aec ("net/ice: support ddp dump switch rule binary")
> 
> Signed-off-by: Steve Yang <stevex.yang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Squashed into below patch on dpdk-next-net-intel.
https://patchwork.dpdk.org/project/dpdk/patch/20221018064736.1727193-1-stevex.yang@intel.com/

Thanks
Qi
  

Patch

diff --git a/drivers/net/ice/ice_ddp_package.c b/drivers/net/ice/ice_ddp_package.c
index b881fa3ded..a27a4a2da2 100644
--- a/drivers/net/ice/ice_ddp_package.c
+++ b/drivers/net/ice/ice_ddp_package.c
@@ -445,7 +445,7 @@  ice_dump_switch(struct rte_eth_dev *dev, uint8_t **buff2, uint32_t *size)
 	hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 
 	/* table index string format: "0000:" */
-	#define TBL_IDX_STR_SIZE  6
+	#define TBL_IDX_STR_SIZE 7
 	for (i = 0; i < ICE_BLK_MAX_COUNT; i++) {
 		int res;
 		uint16_t buff_size;