From patchwork Tue Oct 18 19:41:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 118471 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93A53A0560; Tue, 18 Oct 2022 21:42:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 891F641147; Tue, 18 Oct 2022 21:42:57 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2085.outbound.protection.outlook.com [40.107.223.85]) by mails.dpdk.org (Postfix) with ESMTP id 169F64113C; Tue, 18 Oct 2022 21:42:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sm50x4ZDnUIOti+OYWpo4ePRBBFY0AIDn8gvgFcJTSkMf6P3CcLNAzdNyeAjU9lXGAAcVfPDrO+1/EYSrOX1Yaw5mM6PxV+XBNU0Qylwo5Mn0sEJYCls7LUrZMS+QMkHv1c4BUjGyEhW67QqUBZE6/clzAR/AvT8lN3wQtRPnGuDWYocQ9BZqYHTd8/z4fDzSH36+NYhxGc5xDTVnofwYUTdclgnTU9ei404VgHQ8JjQNuoE/cYMLeSzeUYEl/HUZmG5VPxe7LPMc/w8WXEwspfhgk4cjv2zH8nAPctFPxRwFKdgti39Imz9mc9MWha6L7F9B4fNQGdOXI0NIr5/Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=gFJV/4H3YubwNGp4/msWtG48YTyB4S315UINu1eUrfGL+ngMJXx+bA/pbmRxfy6ly4mh8/SfP7lA+riysgIIF0WSfIM/6zgiAXr5VGh6IQqSnZzo8he7uCMaz/ogTRrwJ6f7BiBpUmxryDLBfiZhyE6uT5hI7u7VobaY3lGea8Srdddl4Eu6yGhGIZM0OxkwiwRZP6ErTGvqQXhoszlR5BQzNghpeZid7U2UEMbiF9yPYEVYYwOkC06dMDwPB1KUdXPQTwY5ay23AjDhWX8gK4otX2SJAhJ6dy3a+T9tjl9JyILAdtdE9YSlt3SCgPeky/Mtz3sutOS4UP4+/k87pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=40fjOdsZ9XMkJ08cFZgreKod3g1ObzNW5j5dhZ+1Rc4=; b=5eD9Kv91178d8EamY3gglIKerODYbDFAY+T6GE2G/b/AWliRIxF8WTM59JfUm0eGI4Onx8K1b6RGuGL2Th9ICooUuP5GX31LaYP2vGmHX1gmxHI2QGMvj7gRWO5E/BwVOgbHUIxjEqdrDlAPH3mw1Iko5UKkG8EJEH5af0qOctY= Received: from BN9PR03CA0427.namprd03.prod.outlook.com (2603:10b6:408:113::12) by BY5PR12MB4965.namprd12.prod.outlook.com (2603:10b6:a03:1c4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Tue, 18 Oct 2022 19:42:52 +0000 Received: from BN8NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::6a) by BN9PR03CA0427.outlook.office365.com (2603:10b6:408:113::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.31 via Frontend Transport; Tue, 18 Oct 2022 19:42:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT084.mail.protection.outlook.com (10.13.176.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5746.16 via Frontend Transport; Tue, 18 Oct 2022 19:42:51 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 14:42:50 -0500 From: Andrew Boyer To: CC: Andrew Boyer , , Subject: [PATCH v2 05/36] net/ionic: fix up reported error stats Date: Tue, 18 Oct 2022 12:41:00 -0700 Message-ID: <20221018194131.23006-6-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221011005032.47584-1-andrew.boyer@amd.com> References: <20221011005032.47584-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT084:EE_|BY5PR12MB4965:EE_ X-MS-Office365-Filtering-Correlation-Id: 859dc7f2-0d12-48ff-cd4b-08dab140f190 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xy6qDut28r5qbUadGMUbRMnKFQcU7rSEDw74C5EAEQ2WvHMQZBuvK0UfSP/0MzoHSKuEbrlgL+YJFLdMAyb6fyHtuy4wvMRUrRwBwR4Nmy6wKOhVPMimO51zTJDW78QrnZOgbFS1LxPvsfY31M2rtWqjhR448nFolR0I+JJi05pRO/k/5uRy1fBjgZVqe3t0sqU1P3eGWawdxrz5CQCxWDbv7/31oiZoHh9LPlgUpHKZkP3zseWXNt27txGF0sg0WAXFeadAPuTznGw09VDM3jaCGTfhu4esb87kUN44pzS9MsdspPwmGDmYxcF5VEqF97w28mABg54xJM/kP0SFsqvJ1JphOgD1Zpkcym/xBls71/SZ6TX228OzCtbYt9Wsq14PUVBcyvbXyqRW3kJUcdMFI+TuHTMgw+8eJhEjBFrDEHI3cLqJEhKSacmV3SjyurTmPp3hOw1tcn29VD3MRzIjcMKEmPeiJPs/o8u8++Ih5FhokMQF5HQM6MmlPMUjEimPoJS2yEMTg7cOR9mRGi8DBSj1Yv/O8+cNCI6YP/dhX1qXOkBoe61oko5WEFu6QJcoad1esvDh08aJoME4Mn+UfF5lmqnhHqdDZ0BeuMFco0YWm81aZ/2CezyqAtfT/zOYjDAf8r8QCIvMSYhgva5LfEWyElq0Nfofsk4z/G01Taf4jbugwadAREWrIUzSY28Lrvmy8VINt2fLT2wCh2Olefa/HthfVquuX05OawXHj9bPyAZNebqpKvQv4bhQinLJsUDTvanhiSer3uHMW8n/NLyBB9UKPXCx8vLHlmyDABWB2bdWteZsdaS5Fe2Z X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(346002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(36860700001)(86362001)(336012)(82740400003)(44832011)(2906002)(5660300002)(2616005)(426003)(186003)(16526019)(1076003)(81166007)(356005)(83380400001)(47076005)(6916009)(316002)(478600001)(26005)(41300700001)(70586007)(6666004)(54906003)(70206006)(40480700001)(82310400005)(8936002)(4326008)(8676002)(40460700003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 19:42:51.4699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 859dc7f2-0d12-48ff-cd4b-08dab140f190 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4965 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Report descriptor errors in ierrors instead of imissed. Don't report rx_queue_empty or rx_queue_disabled in imissed, since those packet errors are already included in the rx_*_drop_packets counters. This makes the reported stats correct. Fixes: 3cdfd90579e7 ("net/ionic: add stats") Cc: cardigliano@ntop.org Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 5e8fdf3893..799530f7f5 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -132,7 +132,7 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats; - stats->imissed += + stats->ierrors += rx_stats->no_cb_arg + rx_stats->bad_cq_status + rx_stats->no_room + @@ -144,10 +144,8 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats ls->rx_mcast_drop_packets + ls->rx_bcast_drop_packets; - stats->imissed += - ls->rx_queue_empty + + stats->ierrors += ls->rx_dma_error + - ls->rx_queue_disabled + ls->rx_desc_fetch_error + ls->rx_desc_data_error;