From patchwork Tue Oct 18 19:40:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 118470 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C2C7A0560; Tue, 18 Oct 2022 21:42:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F29D40A8B; Tue, 18 Oct 2022 21:42:48 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by mails.dpdk.org (Postfix) with ESMTP id EEBD340041; Tue, 18 Oct 2022 21:42:46 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cq2BA3DSoETCTn2LXYxwqEh2o1NHbQkFrLGPa75jnKxD6cGencP/b8UO1+3ZUJ52BASvzzDuG99qM8p6/FEiot6kLrIXM8L5j6y+/zy/6n1RmpbkB3oH2RVCbpXzPFHcqZ0Lpzl81cnvBwt5AB0wVRG6ezkP7EdTBTmuoThZgUWwit1vpOBbwjtVvI1RrM4uFjTOsLw/y0YGg9xz4ZSLEQgLCm1C3wNmOte9J0lj7byb6SuetR/YU69Yud3RxRj3gZGWZp6xrrTWn9We0cmm6FUD6GG/PSnz7YOoKGZ7Sw92a8FwpX4nXlGl75eTdPumAugdkN6F8qUO/SUqx0TSPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=GwRX1eEIlOPqH/DGuG6Ka/X78o9Xmz//qtLO5zxXZmFK5ArnfP/GjBqlyLjGlreAPuSvOEhwqDxSp7iScPPjXUTTZ/+GC88piQt8cYwmgZr5TavKcrWpnt87T02owDI9kLa9ydGjzufILKx37wcV3MDAWLAWjRu3wjHxCXU7e4U9L52Bj5Wx8bQSx1tTDNNu4DoXaV7rH7mZA3MmbPgtmOcc/s/iH0gLzWlmEGVeVV7U4wfCdqIYP/DdLqBugwe5voYRcolrtN0WFD98t+etnunHYeuDHmrlj8DDRsiPfWlZsyd26/DduydhCPZ2G6/FjPYT8LQfPnV7L6N7WNr6mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2D9kgK+HW6LulQg52lNcgajhCK4gktTz9uKrqFgyWmA=; b=Y5jFSC7uIscwpVqSKxxp+s3rNy3fMlYZu8iyKPNM3qND9ATMc3Op9/73fKFvgNH4cvW7ZUWYJa+bSUNb6IcTv0x2sM1ZgQkhfsRYJSHDNiD2pUT/otZO0MoZnXaCaChPf5qla1pD8t5bGhieTkIXKpWDjCnDlHn6Ybh7ElozDpA= Received: from BN9PR03CA0435.namprd03.prod.outlook.com (2603:10b6:408:113::20) by SA1PR12MB7197.namprd12.prod.outlook.com (2603:10b6:806:2bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Tue, 18 Oct 2022 19:42:44 +0000 Received: from BN8NAM11FT084.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::e5) by BN9PR03CA0435.outlook.office365.com (2603:10b6:408:113::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.34 via Frontend Transport; Tue, 18 Oct 2022 19:42:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT084.mail.protection.outlook.com (10.13.176.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5746.16 via Frontend Transport; Tue, 18 Oct 2022 19:42:44 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 18 Oct 2022 14:42:04 -0500 From: Andrew Boyer To: CC: Andrew Boyer , Subject: [PATCH v2 04/36] net/ionic: fix up the Rx filter save API Date: Tue, 18 Oct 2022 12:40:59 -0700 Message-ID: <20221018194131.23006-5-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221011005032.47584-1-andrew.boyer@amd.com> References: <20221011005032.47584-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT084:EE_|SA1PR12MB7197:EE_ X-MS-Office365-Filtering-Correlation-Id: 67e423ad-6251-47bd-07eb-08dab140ed35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: smbL7Wx/Zi20LGWiZFk3Z657X3+AV89lmYDNzvhr48r7hylazlejQEAcyo6Pt2UHnTlWeTTQnmAUDBlb4Ok4+/a0hVHDosYUBlIZ631wtZlkUXWrbhYwMZTGoS3imjhmgbVQFaE6Tgv4tlzQV7vhlHfn8eidaKQml7tTUWDed0oBqUDSEONosuw2rsppic6qcK2CJgNhzwQKdRjVY5X8avsFufongHeoP3BwbTCMac+mkmouK4KmRt7OIWdl78Fpfw6F9lODL9NdxPvNWU55TYSs9owba8BYALuUQiNvyNcE2jT5ISk8jD08/44AZg/sX9L/u7XriWK78KTxL92EIQ0mmN4Pl937wPUxiZ9aFAY1tVP/0rQPc872U/AH1V354NsdSWvo+snwJ4Pglj/Sv18giwnApkxlkRZdOLUNA1Cj+uWXMhxcwaT2issCqLwRlOiKLidWhVMhmR4qlna3kitfYHzY23b3X38AJqTSdk5LbxVYh4O5BIfpisGMO85P25Le8oH2MTI0jvx30yDFRkMk9RtFbWbTkkd8HmxDY0gHJYchkD/p9+9ouxPf9efZnRfe/gbaZOLgazX4IubTAylaWpHikR+n07/tDSEysHBLojlueRp8jJcXlMMeThOURXb00fjEQSusC3r+yHoTqqwEnD3YfbIOwslm8bMVDg2qIpiDNg/2VxCox1sy9j+24Q5u8WdbxegrorovcXbtiRg2PKuTrpa1ytEFqk5hicADp1iir1r1C12ru2XsgfzrBz0SMeVcET5A4rSiPKymu0g3pmPjUimklTMK+wG0qa4is3K172aTc+XfYZitvZqC X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(5660300002)(44832011)(4744005)(70586007)(6916009)(54906003)(8676002)(41300700001)(4326008)(36860700001)(36756003)(450100002)(478600001)(6666004)(8936002)(26005)(316002)(83380400001)(426003)(2906002)(47076005)(70206006)(40480700001)(40460700003)(356005)(81166007)(1076003)(186003)(82310400005)(82740400003)(2616005)(16526019)(86362001)(336012)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 19:42:44.1576 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67e423ad-6251-47bd-07eb-08dab140ed35 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT084.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7197 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check the match variable after copying cmd info, or else there can be unexpected results. Fixes: a27e0e96ab77 ("net/ionic: observe endianness in Rx filter") Cc: andrew.boyer@amd.com Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rx_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c index bf57a9fa52..4b2e907f9f 100644 --- a/drivers/net/ionic/ionic_rx_filter.c +++ b/drivers/net/ionic/ionic_rx_filter.c @@ -63,8 +63,8 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id, f->flow_id = flow_id; f->filter_id = rte_le_to_cpu_32(ctx->comp.rx_filter_add.filter_id); f->rxq_index = rxq_index; - f->match = rte_le_to_cpu_16(f->cmd.match); memcpy(&f->cmd, &ctx->cmd, sizeof(f->cmd)); + f->match = rte_le_to_cpu_16(f->cmd.match); switch (f->match) { case IONIC_RX_FILTER_MATCH_VLAN: