From patchwork Tue Oct 18 13:53:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 118429 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA75A0560; Tue, 18 Oct 2022 17:07:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05C4A41148; Tue, 18 Oct 2022 17:07:14 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id C84CF40395 for ; Tue, 18 Oct 2022 17:07:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666105631; x=1697641631; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=WVNcUPYcxA8xorxD7xVEfI5zoxukFLO/FEVf+wz2QLs=; b=WtcamxXg0LprLDdW/ATL7F+6/vtOiYB5IbNnYHbFN40SVCzt65bMXl38 dM85hX66XOzCrf/7b+wyG+030DFzbXBdb/bUgHGecwEIFgiqEJNAw77Ai AqhQuoz66jdXTyx8iJfs5z9q3zU4nisAZLya4KjZiqT2VQNv24Ur6BFps a7gb+raYQZa1tHn9mUxKAJasGLy+6PcS3A0r3P/ZufmSy+Ceg0xT40tp4 3/W4heHrqHQT3XqC7/OEeOrOaO9mtHLEMuFDohZaASwVeqYDS/s2RkvnV wC1re0ogrfKWNlsg/v/WROFIUrzZoY/5oGesAe2wKdDtxQ0lwqq+kqdFM Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="307792768" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307792768" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2022 08:02:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10504"; a="579825441" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="579825441" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga003.jf.intel.com with ESMTP; 18 Oct 2022 08:02:32 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, kai.ji@intel.com, Arek Kusztal Subject: [PATCH v2 3/3] crypto/qat: fix not set rsa lengths Date: Tue, 18 Oct 2022 14:53:34 +0100 Message-Id: <20221018135334.34873-3-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20221018135334.34873-1-arkadiuszx.kusztal@intel.com> References: <20221018135334.34873-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fixed not set output length in asym pmd when doing RSA. Fixes: 002486db239e ("crypto/qat: refactor asymmetric session") Signed-off-by: Arek Kusztal Acked-by: Ciara Power --- v2: - fixed compilation issues - split into 3 patches drivers/crypto/qat/qat_asym.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 0eb5ba79bc..05ca95319b 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -508,21 +508,19 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_ENCRYPT) { - uint8_t *rsa_result = asym_op->rsa.cipher.data; - - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.cipher.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.cipher.length = alg_bytesize; HEXDUMP("RSA Encrypted data", cookie->output_array[0], alg_bytesize); } else { - uint8_t *rsa_result = asym_op->rsa.cipher.data; - switch (asym_op->rsa.padding.type) { case RTE_CRYPTO_RSA_PADDING_NONE: - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.cipher.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.cipher.length = alg_bytesize; HEXDUMP("RSA signature", cookie->output_array[0], alg_bytesize); @@ -534,13 +532,12 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, } } else { if (asym_op->rsa.op_type == RTE_CRYPTO_ASYM_OP_DECRYPT) { - uint8_t *rsa_result = asym_op->rsa.message.data; - switch (asym_op->rsa.padding.type) { case RTE_CRYPTO_RSA_PADDING_NONE: - rte_memcpy(rsa_result, + rte_memcpy(asym_op->rsa.message.data, cookie->output_array[0], alg_bytesize); + asym_op->rsa.message.length = alg_bytesize; HEXDUMP("RSA Decrypted Message", cookie->output_array[0], alg_bytesize); @@ -550,11 +547,10 @@ rsa_collect(struct rte_crypto_asym_op *asym_op, return RTE_CRYPTO_OP_STATUS_ERROR; } } else { - uint8_t *rsa_result = asym_op->rsa.sign.data; - - rte_memcpy(rsa_result, - cookie->output_array[0], - alg_bytesize); + rte_memcpy(asym_op->rsa.sign.data, + cookie->output_array[0], + alg_bytesize); + asym_op->rsa.sign.length = alg_bytesize; HEXDUMP("RSA Signature", cookie->output_array[0], alg_bytesize); }