From patchwork Fri Oct 14 07:54:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Theil X-Patchwork-Id: 118197 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82484A00C2; Fri, 14 Oct 2022 09:54:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B13742CA2; Fri, 14 Oct 2022 09:54:27 +0200 (CEST) Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67]) by mails.dpdk.org (Postfix) with ESMTP id 703AF410F1 for ; Fri, 14 Oct 2022 09:54:25 +0200 (CEST) Received: from isengard.fritz.box (p54aef542.dip0.t-ipconnect.de [84.174.245.66]) by smail.rz.tu-ilmenau.de (Postfix) with ESMTPA id 2D61C580099; Fri, 14 Oct 2022 09:54:25 +0200 (CEST) From: Markus Theil To: dev@dpdk.org Cc: Markus Theil Subject: [PATCH v2 2/2] eal: prevent OOB read in rte_lcore_to_socket_id Date: Fri, 14 Oct 2022 09:54:21 +0200 Message-Id: <20221014075421.10300-2-markus.theil@tu-ilmenau.de> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221014075421.10300-1-markus.theil@tu-ilmenau.de> References: <20221014062100.5761-1-markus.theil@tu-ilmenau.de> <20221014075421.10300-1-markus.theil@tu-ilmenau.de> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org rte_lcore_to_socket_id did not check the lcore_id range before accessing an array with RTE_MAX_LCORE elements. Signed-off-by: Markus Theil --- lib/eal/common/eal_common_lcore.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 812e62bcb3..af53efcc24 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common/eal_common_lcore.c @@ -111,6 +111,9 @@ unsigned int rte_get_next_lcore(unsigned int i, int skip_main, int wrap) unsigned int rte_lcore_to_socket_id(unsigned int lcore_id) { + if (unlikely(lcore_id >= RTE_MAX_LCORE)) + return -1; + return lcore_config[lcore_id].socket_id; }