| Message ID | 20221013093402.24572-1-dongzhou@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Raslan Darawsheh |
| Headers | show |
| Series | net/mlx5: fix thread workspace memory leak | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-aarch64-compile-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-aarch64-unit-testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-x86_64-unit-testing | success | Testing PASS |
| ci/iol-x86_64-compile-testing | success | Testing PASS |
| ci/intel-Testing | success | Testing PASS |
| ci/github-robot: build | success | github build: passed |
Hi, > -----Original Message----- > From: Bill Zhou <dongzhou@nvidia.com> > Sent: Thursday, October 13, 2022 12:34 PM > To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad > <matan@nvidia.com> > Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; > Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix thread workspace memory leak > > The thread workspace push/pop should be paired. In the "flow_list_create" > routine, if error happened the workspace pop was missed. This patch shares > the workspace pop for all return paths. > > Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation") > Cc: xuemingl@nvidia.com > Cc: stable@dpdk.org > > Signed-off-by: Dong Zhou <dongzhou@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e4744b0..6fb1d53 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -7028,8 +7028,8 @@ struct mlx5_list_entry * rte_errno = ret; /* Restore rte_errno. */ ret = rte_errno; rte_errno = ret; - mlx5_flow_pop_thread_workspace(); error_before_hairpin_split: + mlx5_flow_pop_thread_workspace(); rte_free(translated_actions); return 0; }
The thread workspace push/pop should be paired. In the "flow_list_create" routine, if error happened the workspace pop was missed. This patch shares the workspace pop for all return paths. Fixes: 0064bf431899 ("net/mlx5: fix nested flow creation") Cc: xuemingl@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dong Zhou <dongzhou@nvidia.com> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)