diff mbox series

net/mlx5: fix thread termination check on Windows

Message ID 20221012064949.2320-1-talshn@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: fix thread termination check on Windows |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Tal Shnaiderman Oct. 12, 2022, 6:49 a.m. UTC 
  The mlx5_is_thread_alive function always returns false
(terminated) regardless to the actual thread state.

Fixed to return the correct thread state.

Bugzilla ID: 1089
Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
 drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Slava Ovsiienko Oct. 12, 2022, 7:55 a.m. UTC | #1 
> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Matan
> Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Raslan
> Darawsheh <rasland@nvidia.com>; paul203948@gmail.com; Idan Hackmon
> <idanhac@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
> 
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
> 
> Fixed to return the correct thread state.
> 
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Raslan Darawsheh Oct. 18, 2022, 11:47 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Wednesday, October 12, 2022 9:50 AM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
> Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> paul203948@gmail.com; Idan Hackmon <idanhac@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix thread termination check on Windows
> 
> The mlx5_is_thread_alive function always returns false
> (terminated) regardless to the actual thread state.
> 
> Fixed to return the correct thread state.
> 
> Bugzilla ID: 1089
> Fixes: 5d55a494f4e62f2 ("net/mlx5: split multi-thread flow handling per OS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/windows/mlx5_flow_os.c b/drivers/net/mlx5/windows/mlx5_flow_os.c
index 48d7da41b1..5013e9f012 100644
--- a/drivers/net/mlx5/windows/mlx5_flow_os.c
+++ b/drivers/net/mlx5/windows/mlx5_flow_os.c
@@ -262,7 +262,7 @@  mlx5_is_thread_alive(HANDLE thread_handle)
 
 	if (result == WAIT_OBJECT_0)
 		return false;
-	return false;
+	return true;
 }
 
 static int