[v9,7/8] app/procinfo: support descriptor dump
Checks
Commit Message
This patch support Rx/Tx descriptor dump
The command is like:
dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx --
--show-rx-descriptor queue_id:offset:num
dpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx --
--show-tx-descriptor queue_id:offset:num
queue_id: A queue identifier on this port.
offset: The offset of the descriptor starting from tail.
num: The number of the descriptors to dump.
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
app/proc-info/main.c | 80 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
Comments
> -----Original Message-----
> From: Dongdong Liu <liudongdong3@huawei.com>
> +static void
> +nic_descriptor_display(uint16_t port_id, struct desc_param *desc,
> + desc_dump_t desc_dump)
> +{
> + static const char *nic_desc_border = "###";
> + uint16_t queue_id = desc->queue_id;
> + uint16_t offset = desc->offset;
> + uint16_t num = desc->num;
> +
> + printf("%s NIC descriptor for port %u %s\n",
> + nic_desc_border, port_id, nic_desc_border);
> +
> + desc_dump(port_id, queue_id, offset, num, stdout); }
> +
> int
> main(int argc, char **argv)
> {
> @@ -1732,6 +1806,12 @@ main(int argc, char **argv)
> metrics_display(i);
> #endif
>
> + if (enable_shw_rx_desc_dump)
> + nic_descriptor_display(i, &rx_desc_param,
> + rte_eth_rx_descriptor_dump);
I don't think you need the function nic_descriptor_display() to dump the descriptors.
You can call the rte_eth_rx_descriptor_dump() directly here. And same comment for below code too.
This way you can have the RX/TX descriptor scase specific dump printfs in these sections.
Also, the printf in the nic_descriptor_display() is not telling if your dumping TX descriptors or Rx descriptors.
If you want to keep nic_descriptor_display() that's fine but you need to make sure printf to be RX/TX specific.
> + if (enable_shw_tx_desc_dump)
> + nic_descriptor_display(i, &tx_desc_param,
> + rte_eth_tx_descriptor_dump);
> }
>
> #ifdef RTE_LIB_METRICS
> --
> 2.22.0
Hi Reshma
Many thanks for your review.
On 2022/10/10 17:08, Pattan, Reshma wrote:
>
>
>> -----Original Message-----
>> From: Dongdong Liu <liudongdong3@huawei.com>
>> +static void
>> +nic_descriptor_display(uint16_t port_id, struct desc_param *desc,
>> + desc_dump_t desc_dump)
>> +{
>> + static const char *nic_desc_border = "###";
>> + uint16_t queue_id = desc->queue_id;
>> + uint16_t offset = desc->offset;
>> + uint16_t num = desc->num;
>> +
>> + printf("%s NIC descriptor for port %u %s\n",
>> + nic_desc_border, port_id, nic_desc_border);
>> +
>> + desc_dump(port_id, queue_id, offset, num, stdout); }
>> +
>
>
>> int
>> main(int argc, char **argv)
>> {
>> @@ -1732,6 +1806,12 @@ main(int argc, char **argv)
>> metrics_display(i);
>> #endif
>>
>> + if (enable_shw_rx_desc_dump)
>> + nic_descriptor_display(i, &rx_desc_param,
>> + rte_eth_rx_descriptor_dump);
>
> I don't think you need the function nic_descriptor_display() to dump the descriptors.
> You can call the rte_eth_rx_descriptor_dump() directly here. And same comment for below code too.
> This way you can have the RX/TX descriptor scase specific dump printfs in these sections.
> Also, the printf in the nic_descriptor_display() is not telling if your dumping TX descriptors or Rx descriptors.
> If you want to keep nic_descriptor_display() that's fine but you need to make sure printf to be RX/TX specific.
Good point, will do.
Thanks,
Dongdong
>
>> + if (enable_shw_tx_desc_dump)
>> + nic_descriptor_display(i, &tx_desc_param,
>> + rte_eth_tx_descriptor_dump);
>> }
>>
>> #ifdef RTE_LIB_METRICS
>> --
>> 2.22.0
>
> .
>
@@ -54,6 +54,9 @@
#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \
STATS_BDR_FMT, s, w, STATS_BDR_FMT)
+typedef int (*desc_dump_t)(uint16_t port_id, uint16_t queue_id,
+ uint16_t offset, uint16_t num, FILE *file);
+
/* mask of enabled ports */
static unsigned long enabled_port_mask;
/* Enable stats. */
@@ -117,6 +120,21 @@ static uint32_t enable_shw_rss_reta;
/* Enable show module eeprom information. */
static uint32_t enable_shw_module_eeprom;
+/* Enable dump Rx/Tx descriptor. */
+static uint32_t enable_shw_rx_desc_dump;
+static uint32_t enable_shw_tx_desc_dump;
+
+#define DESC_PARAM_NUM 3
+
+struct desc_param {
+ uint16_t queue_id; /* A queue identifier on this port. */
+ uint16_t offset; /* The offset of the descriptor starting from tail. */
+ uint16_t num; /* The number of the descriptors to dump. */
+};
+
+static struct desc_param rx_desc_param;
+static struct desc_param tx_desc_param;
+
/* display usage */
static void
proc_info_usage(const char *prgname)
@@ -148,6 +166,14 @@ proc_info_usage(const char *prgname)
" --firmware-version: to display ethdev firmware version\n"
" --show-rss-reta: to display ports redirection table\n"
" --show-module-eeprom: to display ports module eeprom information\n"
+ " --show-rx-descriptor queue_id:offset:num to display ports Rx descriptor information. "
+ "queue_id: A Rx queue identifier on this port. "
+ "offset: The offset of the descriptor starting from tail. "
+ "num: The number of the descriptors to dump.\n"
+ " --show-tx-descriptor queue_id:offset:num to display ports Tx descriptor information. "
+ "queue_id: A Tx queue identifier on this port. "
+ "offset: The offset of the descriptor starting from tail. "
+ "num: The number of the descriptors to dump.\n"
" --iter-mempool=name: iterate mempool elements to display content\n"
" --dump-regs=file-prefix: dump registers to file with the file-prefix\n",
prgname);
@@ -200,6 +226,19 @@ parse_xstats_ids(char *list, uint64_t *ids, int limit) {
return length;
}
+static int
+parse_descriptor_param(char *list, struct desc_param *desc)
+{
+ int ret;
+
+ ret = sscanf(list, "%hu:%hu:%hu", &desc->queue_id, &desc->offset,
+ &desc->num);
+ if (ret != DESC_PARAM_NUM)
+ return -EINVAL;
+
+ return 0;
+}
+
static int
proc_info_preparse_args(int argc, char **argv)
{
@@ -264,6 +303,8 @@ proc_info_parse_args(int argc, char **argv)
{"firmware-version", 0, NULL, 0},
{"show-rss-reta", 0, NULL, 0},
{"show-module-eeprom", 0, NULL, 0},
+ {"show-rx-descriptor", required_argument, NULL, 1},
+ {"show-tx-descriptor", required_argument, NULL, 1},
{NULL, 0, 0, 0}
};
@@ -367,6 +408,24 @@ proc_info_parse_args(int argc, char **argv)
return -1;
}
nb_xstats_ids = ret;
+ } else if (!strncmp(long_option[option_index].name,
+ "show-rx-descriptor", MAX_LONG_OPT_SZ)) {
+ int ret = parse_descriptor_param(optarg,
+ &rx_desc_param);
+ if (ret < 0) {
+ printf("Rx descriptor param parse error.\n");
+ return -1;
+ }
+ enable_shw_rx_desc_dump = 1;
+ } else if (!strncmp(long_option[option_index].name,
+ "show-tx-descriptor", MAX_LONG_OPT_SZ)) {
+ int ret = parse_descriptor_param(optarg,
+ &tx_desc_param);
+ if (ret < 0) {
+ printf("Tx descriptor param parse error.\n");
+ return -1;
+ }
+ enable_shw_tx_desc_dump = 1;
}
break;
default:
@@ -1644,6 +1703,21 @@ show_module_eeprom_info(void)
}
}
+static void
+nic_descriptor_display(uint16_t port_id, struct desc_param *desc,
+ desc_dump_t desc_dump)
+{
+ static const char *nic_desc_border = "###";
+ uint16_t queue_id = desc->queue_id;
+ uint16_t offset = desc->offset;
+ uint16_t num = desc->num;
+
+ printf("%s NIC descriptor for port %u %s\n",
+ nic_desc_border, port_id, nic_desc_border);
+
+ desc_dump(port_id, queue_id, offset, num, stdout);
+}
+
int
main(int argc, char **argv)
{
@@ -1732,6 +1806,12 @@ main(int argc, char **argv)
metrics_display(i);
#endif
+ if (enable_shw_rx_desc_dump)
+ nic_descriptor_display(i, &rx_desc_param,
+ rte_eth_rx_descriptor_dump);
+ if (enable_shw_tx_desc_dump)
+ nic_descriptor_display(i, &tx_desc_param,
+ rte_eth_tx_descriptor_dump);
}
#ifdef RTE_LIB_METRICS