From patchwork Fri Oct 7 17:43:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Boyer, Andrew" X-Patchwork-Id: 117611 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AF04A04FD; Fri, 7 Oct 2022 19:47:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11CB342C09; Fri, 7 Oct 2022 19:45:14 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2053.outbound.protection.outlook.com [40.107.92.53]) by mails.dpdk.org (Postfix) with ESMTP id 7D27E42BDB for ; Fri, 7 Oct 2022 19:45:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWfBr5efvm2OUch/R8x1RaLJq6xGs5Vhv2UPTlmDYObXoVNzZ4BdscfUye/hpcfimn84tqIaWTmlRv0NEmPl4HG049s4zu0Q4GIXx0/N20JmwKkx0q4KOcy+jkj2pBrV76mJAICN3o80ps2z/Nx7LulsnYTWsDns6kZrIPiwbt9W2kz+BLuTRokafcnzgbfuL6XtWVgQXEXv89pkMzPb2B8kVWbNfvXa+Kttje6A+NbIS4SkihhCbTSbOnncv2Hl+HEMtnUMY62uu7Mtd0hJioyLIV09TC8DDwsorhypTiKdETU1gFcf+XwQeaM4t2F1/1zlgN1hzBu1x259ot1ing== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4IbUbm1maboOS8MtFY/vuuNq/lASa8Zxb9GD2E7/Mm0=; b=KdWy5u7fnm5tYZVjNi5oBUD8D4hdguunnAU/1n5PyReOOZ/WQYhfb01EtUf8vHW0EOZ98nSg+LxyVydqcJ+hzDk0MR4kbyKLi414sFx3o6JUWY7l24+AIKD1oyRdiPkY0DIdiBAzYeYKIEejVHvYO4dtjj7tkgwrRXJhQgP9dOtSuGGJoEVYvZLLYAJPjz9LPa2Hm92GQTOUc9spbERKO1iXDd3kew21xqplJKHOx7BS5OjQnl/koqYqP1Es3aG3/n84WRvscYjssf4U6NFCyUxtUU657dY1ZOUIE7PWuIXrrsXF9AV+Igrt6zTkE6TIw2mCPOulqQ1VNv3mq/aR9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4IbUbm1maboOS8MtFY/vuuNq/lASa8Zxb9GD2E7/Mm0=; b=mm6vzVCofNNLlEKuf1c+31W+GnlXmZrYREwHUxKU/TVwokvkISbVuey5TjKE0FQS25YylyppFX0fyA1i3ahN3CvCTs9WByEQe/pYFpl7WaUoGhk98lpQchSHUBabeCHNsbkdqL0vh6M0tVrtjsBlUTncoMRWK7EwqdoHLiZ67Yc= Received: from MW4PR03CA0332.namprd03.prod.outlook.com (2603:10b6:303:dc::7) by SN7PR12MB6909.namprd12.prod.outlook.com (2603:10b6:806:263::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Fri, 7 Oct 2022 17:45:06 +0000 Received: from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::85) by MW4PR03CA0332.outlook.office365.com (2603:10b6:303:dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.26 via Frontend Transport; Fri, 7 Oct 2022 17:45:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:45:05 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct 2022 12:45:02 -0500 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH 30/35] net/ionic: add alignment and socket info in allocations Date: Fri, 7 Oct 2022 10:43:31 -0700 Message-ID: <20221007174336.54354-31-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT068:EE_|SN7PR12MB6909:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a539fca-9142-4eb3-5bd0-08daa88babad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kl86n/I8fwett3+QnzpBNTKhMgCIe/WyMlu+znnFlxz+80OA6UZp+N/eZlpta7t2ZbjDpo+HHnTfXM/1z9YIgIvlsWgbuJEZAj34nyVZf37efJvCdpRvL6p5Vw+w9HzRr5rFQ9jq2PWk2Mt+8m3cvLjy3hlvuuFdOijKCJ7da15VSkTPc1sMp3TnIa8EK8JDzPuTwRaNXcC0WOkDGCgSXOHSt9V9IhigRuDNtk27WlbWn8Y/2Px9zHin3wAZay4Uifzz5wjSgpNUnWR/6XKuESTrmwWCn7dM62DCmHeGQHFsmibUeyJFvvoaUOzHTlCxj6UZVdbhW1w2AbImLnuM//wRrEXuHOQQ7Zu0egBX0cAg1MtFOFSlIhXMWPFVVhPseOv3dft+hvtCMkUdgajDB5BjUZ8AvU5ZwPSMs0MWuUVfy6XJJnTn5smHiBhenYC8DeGWeRtifKnEq8o0vjUsfxuYNQ1XPY5VnL84DnLeE0+Fz6mwjp9akSOPMgCO50+8h3TIp1hTaM2INZLeyLVBTao6f9jej5VrjQJL7h67zwYSFOrci82hOpjEeS1PU566ZDRFErGXmiwMfE7h+8ylSPQVzjAyZV2u5gn3JFsPpjZKZ3RXrk1PhyWszYD7/ciWRDGAaeFV7mBWXTPLr3mluQ2bRIT6kjBLh796uO5NHahz6aLfOn0HINsgx5t6BswQ30hBvGMmmFpEJm4OgPqnegPsexGewEVAv9BjpFzuyQZyzaMJeWdpO+Fvch5B7h0nZO7i45Fswou+KWgPTIakmAgvw0Cd5v+OXywgzLOPcGLP6bto3VLGgEe3KGzel4J0 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(44832011)(5660300002)(41300700001)(186003)(47076005)(316002)(16526019)(6666004)(356005)(82310400005)(86362001)(2616005)(70206006)(70586007)(2906002)(6916009)(81166007)(336012)(1076003)(40460700003)(82740400003)(8676002)(8936002)(83380400001)(4326008)(426003)(36756003)(26005)(40480700001)(478600001)(36860700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:45:05.8813 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a539fca-9142-4eb3-5bd0-08daa88babad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6909 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This will avoid memory access penalties on NUMA systems. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 5 +++-- drivers/net/ionic/ionic_lif.c | 13 ++++++++----- drivers/net/ionic/ionic_rx_filter.c | 3 +-- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index 43fa5f8bbf..36fb09b810 100644 --- a/drivers/net/ionic/ionic_ethdev.c +++ b/drivers/net/ionic/ionic_ethdev.c @@ -1005,7 +1005,8 @@ eth_ionic_dev_init(struct rte_eth_dev *eth_dev, void *init_params) /* Allocate memory for storing MAC addresses */ eth_dev->data->mac_addrs = rte_calloc("ionic", adapter->max_mac_addrs, - RTE_ETHER_ADDR_LEN, 0); + RTE_ETHER_ADDR_LEN, + RTE_CACHE_LINE_SIZE); if (eth_dev->data->mac_addrs == NULL) { IONIC_PRINT(ERR, "Failed to allocate %u bytes needed to " "store MAC addresses", @@ -1083,7 +1084,7 @@ eth_ionic_dev_probe(void *bus_dev, struct rte_device *rte_dev, goto err; } - adapter = rte_zmalloc("ionic", sizeof(*adapter), 0); + adapter = rte_zmalloc("ionic", sizeof(*adapter), RTE_CACHE_LINE_SIZE); if (!adapter) { IONIC_PRINT(ERR, "OOM"); err = -ENOMEM; diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index fbeec8ef2e..cf9605c791 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -598,7 +598,8 @@ ionic_qcq_alloc(struct ionic_lif *lif, total_size += rte_mem_page_size(); } - new = rte_zmalloc("ionic", struct_size, 0); + new = rte_zmalloc_socket("ionic", struct_size, + RTE_CACHE_LINE_SIZE, socket_id); if (!new) { IONIC_PRINT(ERR, "Cannot allocate queue structure"); return -ENOMEM; @@ -1037,17 +1038,19 @@ ionic_lif_alloc(struct ionic_lif *lif) return -ENOMEM; } - lif->txqcqs = rte_calloc("ionic", + lif->txqcqs = rte_calloc_socket("ionic", adapter->max_ntxqs_per_lif, - sizeof(*lif->txqcqs), 0); + sizeof(*lif->txqcqs), + RTE_CACHE_LINE_SIZE, socket_id); if (!lif->txqcqs) { IONIC_PRINT(ERR, "Cannot allocate tx queues array"); return -ENOMEM; } - lif->rxqcqs = rte_calloc("ionic", + lif->rxqcqs = rte_calloc_socket("ionic", adapter->max_nrxqs_per_lif, - sizeof(*lif->rxqcqs), 0); + sizeof(*lif->rxqcqs), + RTE_CACHE_LINE_SIZE, socket_id); if (!lif->rxqcqs) { IONIC_PRINT(ERR, "Cannot allocate rx queues array"); return -ENOMEM; diff --git a/drivers/net/ionic/ionic_rx_filter.c b/drivers/net/ionic/ionic_rx_filter.c index fdedb9e288..5f9b569f64 100644 --- a/drivers/net/ionic/ionic_rx_filter.c +++ b/drivers/net/ionic/ionic_rx_filter.c @@ -55,8 +55,7 @@ ionic_rx_filter_save(struct ionic_lif *lif, uint32_t flow_id, struct ionic_rx_filter *f; uint32_t key; - f = rte_zmalloc("ionic", sizeof(*f), 0); - + f = rte_zmalloc("ionic", sizeof(*f), RTE_CACHE_LINE_SIZE); if (!f) return -ENOMEM;