From patchwork Fri Oct 7 17:43:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 117598 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 792F8A04FD; Fri, 7 Oct 2022 19:46:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 559CA42BC8; Fri, 7 Oct 2022 19:44:53 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45]) by mails.dpdk.org (Postfix) with ESMTP id D283642684 for ; Fri, 7 Oct 2022 19:44:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2T+F4SiZydozfxvCZ+fiOWQ0gK2Fnva72DSqSJiqnO2IYVe0/SCGlRBxdrlDZoL0T4Dd3tni02X5X4WZSxOESu7sfheS0glT73BWBuy2jpmnWktaBGzntqZYsN4msEgEwTCJ5odRiZU5eaz5NyD2bw7S5rvEuzQmaaMRxCQcxc1bVttDYMOoZdXoenl+RGo8VloEK6VmLHCbZPXhFLV3wEfpjUjKV8zJzQADphKy9+tHTXHWFlx/qS2HRWs9RFL6j2miWzKvizEULBRBiHd5AA0KRH7ohJXI6LKyKLn9IkC9ZNBA3acN0EBEaDjKX4tfcf+AuluLfiVzYTGqoAEdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zbJ8OETcZL2YXjMs2URjDHyEnQijTUyw/o964mXprU=; b=d0Edp13veUHuGWn4Ps6ovs+h2MUKtFrB5qcdALM4Day8IWKnxEcZqKuIjLZN8tDY0FdVMJx3tRlQ7t6KcWKFpGmZMQJj5hKbNC3LVn5TmksqhlUk7qMAq5sNchzGBjiPdtagOiVu6BNB1qXMNRqakLlUZTmBTzxXFQrAFo9j0Nf/6BBZAWbnfNYVduMXiXOrqbP34JwpYTTGYAQt2M+uoO0R2G6lwnTKYr2LI83ldmanvaBSXRELY6h46PvJH9pFAdVueFfgMk+6qm/vJhAgu/sOVAssponjJZVrgYVxIVrUVC7byih/VADr+ToF3cWBZ4uFCre1wiqhbBo7UgSekQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zbJ8OETcZL2YXjMs2URjDHyEnQijTUyw/o964mXprU=; b=LeArII9ds20C83kdgGiJiNteAWqhj0STnS3IvFJ2MaPCGiyd2y8gjm/ibvlTvBQ+VAghx9+5YusYcxhkBynaDN7xu3/l4JJNmtk8ll3ZOpDcUA7tsp+YB2mWbIXdy0mObaPtrtFzbfkj6BQhbcPxbIsCYqvf9E5DI68ckW3q+qE= Received: from MW4PR04CA0379.namprd04.prod.outlook.com (2603:10b6:303:81::24) by DM6PR12MB4387.namprd12.prod.outlook.com (2603:10b6:5:2ac::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct 2022 17:44:48 +0000 Received: from CO1NAM11FT050.eop-nam11.prod.protection.outlook.com (2603:10b6:303:81:cafe::a6) by MW4PR04CA0379.outlook.office365.com (2603:10b6:303:81::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24 via Frontend Transport; Fri, 7 Oct 2022 17:44:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT050.mail.protection.outlook.com (10.13.174.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:48 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct 2022 12:44:47 -0500 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH 18/35] net/ionic: do one-time init of receive descriptors Date: Fri, 7 Oct 2022 10:43:19 -0700 Message-ID: <20221007174336.54354-19-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221007174336.54354-1-andrew.boyer@amd.com> References: <20221007174336.54354-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT050:EE_|DM6PR12MB4387:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f8269bc-dcb4-4734-3e5e-08daa88ba10e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +cFHuLJ+Sje7gXl0sSBB+Gzk5C6jGfAPXgickZI8Lc6wPO7TWsWfrb5q/gVOVVeneuNK7CIbWD2JQKg/XSIqG580K89hu/OpAPe/UGcPY4TpeMQLqc7IrNe/dR38igCvese+iW3EvOEonxFzoZlMd3qO/js6UxYxvHIDC8DoctlMuGlfiyh7S7e7ZWag+R0u2JTRcTJOzy1b0JdnhhRj9upRe0bpvXbwnsjDXKMIejswp/FC8RoJ5SZmV5CSfynMWck/47e4E66lB3hQY1WhNmkriHRG43/oI8gwu6bvfL0XaY1fh8yV9gFFR+63MRo/6H+Z5dLuFrA8N7ivnz7CZGnHTcY9JUG0JfC0KKwwDekgf82tDmGGqVP9HOxog22nVs5thEf+aiROsr9xq14By/0Xkp7cGtqS+OLi7wG6DraQNW6fmEJTIN92qm5OqigjSu6478pQBmXTlmRmNh3NDDLfNQuj5hPK/DurWc1n/eoAe8He4DV7KYS2y9N8YT5R2JMfBRMGxTdcCj1GpwTIuZWG+R1ylSLPkPa7WAwIzYIu0SLLnWqB3Kd3r4BFx3HNzfHV6ecm+47cx3IKK59iWiQAFnp8rKWJmHr0M9I3wOehQl6vHfEz6uNFO1hHO/UbLrCeD/KhWwdThMcdRavKEm6IzKJW9up2lJug78/aWcaOuRzg7vqzTZ95xGelR1eYaqCqTe0f6mqYJjhuBTi1L4GBuyJ6jACUhPh08lbpMAWQwgedIkyVOv5q/YWvsIBAk5Bh0EAvB5Jm2Oy9yhpdeqsygNi/2UJzZ+situenIAM= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(8936002)(44832011)(5660300002)(2906002)(41300700001)(81166007)(40480700001)(356005)(70206006)(2616005)(70586007)(6666004)(426003)(86362001)(26005)(4326008)(8676002)(82310400005)(40460700003)(82740400003)(1076003)(336012)(36860700001)(83380400001)(47076005)(478600001)(186003)(16526019)(316002)(6916009)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 17:44:48.0769 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f8269bc-dcb4-4734-3e5e-08daa88ba10e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT050.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4387 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These fields don't need to be set in the hot path. This improves performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 38 ++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 0c1cc842cf..2a34465e46 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -941,9 +941,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) desc = &desc_base[q->head_idx]; dma_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(rxm)); desc->addr = dma_addr; - desc->len = rxq->hdr_seg_size; - desc->opcode = (q->num_segs > 1) ? IONIC_RXQ_DESC_OPCODE_SG : - IONIC_RXQ_DESC_OPCODE_SIMPLE; rxm->next = NULL; prev_rxm_seg = rxm; @@ -963,7 +960,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) data_iova = rte_mbuf_data_iova(rxm_seg); dma_addr = rte_cpu_to_le_64(data_iova); elem->addr = dma_addr; - elem->len = rxq->seg_size; elem++; rxm_seg->next = NULL; @@ -981,6 +977,38 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq) return 0; } +/* + * Perform one-time initialization of descriptor fields + * which will not change for the life of the queue. + */ +static void __rte_cold +ionic_rx_init_descriptors(struct ionic_rx_qcq *rxq) +{ + struct ionic_queue *q = &rxq->qcq.q; + struct ionic_rxq_desc *desc, *desc_base = q->base; + struct ionic_rxq_sg_desc *sg_desc, *sg_desc_base = q->sg_base; + uint32_t i, j; + uint8_t opcode; + + opcode = (q->num_segs > 1) ? + IONIC_RXQ_DESC_OPCODE_SG : IONIC_RXQ_DESC_OPCODE_SIMPLE; + + /* + * NB: Only the first segment needs to leave headroom (hdr_seg_size). + * Later segments (seg_size) do not. + */ + for (i = 0; i < q->num_descs; i++) { + desc = &desc_base[i]; + desc->len = rte_cpu_to_le_16(rxq->hdr_seg_size); + desc->opcode = opcode; + + sg_desc = &sg_desc_base[i]; + for (j = 0; j < q->num_segs - 1u; j++) + sg_desc->elems[j].len = + rte_cpu_to_le_16(rxq->seg_size); + } +} + /* * Start Receive Units for specified queue. */ @@ -1010,6 +1038,8 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id) IONIC_PRINT(DEBUG, "Starting RX queue %u, %u descs, size %u segs %u", rx_queue_id, q->num_descs, rxq->frame_size, q->num_segs); + ionic_rx_init_descriptors(rxq); + err = ionic_lif_rxq_init(rxq); if (err) return err;