From patchwork Fri Oct 7 03:27:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 117531 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4EA3A00C2; Fri, 7 Oct 2022 05:28:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EA9E40E5A; Fri, 7 Oct 2022 05:28:35 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50083.outbound.protection.outlook.com [40.107.5.83]) by mails.dpdk.org (Postfix) with ESMTP id BB96E40A80 for ; Fri, 7 Oct 2022 05:28:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRKO0NLY72QGpEBgKLDB1psAIhrnibGuMPBR8fUqhWpFtDjOQYrfmWSoTadzjCe4W0P6Q8JWrl5n6+FAl1oNCuNQHTEbYRASEVcX08VlmBh0OgquICpFGEJMYOUJht/lwiL/0+HwLm8hYJYMq8cukQtEo2FXKOaLP2FazvVy1QAz2wowsOFI9Z4HUw0J2ZsdI/D8JULZxgCgK6FQclD9Y+T9yS7kmCRQ/TRWgo4IDNMgjhWTkFSQP7iZp6MmiAY1aPJcakHw4Bd1fiYAi7Pp7PfWtuE1eaj+KUea1u91KppUUEuYWTdLA1S7HyNJsqvQCFqdfX0beIbTg3wiDnWYqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DCeVcUu++YCihS2xyT8Ppj8mY9flBQ3f5HzHHR2/Sdg=; b=gMoXZEflvzJ/0jxkqhrSfvJsi6r2lItozK4DSsYH/MFRaheb1JYjM4bGTTVVHKMO39bVENgXLbEa0qf+AuawdM00V+DWFcm+BnlBQQ3BPKmdMdlU6+fpvuM+aGckdDEfkToTN14yU39/Zrn1xwMCWQQLCJ9lA1HbGEW0ePzucyj+gfHay1v9V4v8vj2PdB7w4/d+1E1pfqj4d9snd35IcAMIGzua4mrb/u/D6RI545YlgnNPv2sqQBuDaFkGZTWp5zdAfUJP82exY1SpGk1+ylxfe7mv9E2bjmQfz+czoHXPjvIMS6o6obUuODfRR8vmQN7zzhlwePAjyepXb9Z8gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DCeVcUu++YCihS2xyT8Ppj8mY9flBQ3f5HzHHR2/Sdg=; b=eg9DA+xw0kD19e3pMVwbXzvH/nRFaHNRwBG3w8B2rooq7pb9gIfAldXhXIeGYmatjIYZg37+a8NusIR/tcpB07Yh1cw3SHmJNz9INe+60LEXZif9PHVFpy1OMbs7ECJxOb4kmNFVFV4cQzEjVwVvJFMV38nDq2JWYxA5/wVbdh4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) by AS8PR04MB8641.eurprd04.prod.outlook.com (2603:10a6:20b:428::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.38; Fri, 7 Oct 2022 03:28:33 +0000 Received: from AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e]) by AS8PR04MB8198.eurprd04.prod.outlook.com ([fe80::9ee7:dafa:ba51:c71e%7]) with mapi id 15.20.5676.032; Fri, 7 Oct 2022 03:28:33 +0000 From: Gagandeep Singh To: ferruh.yigit@amd.com, dev@dpdk.org Cc: Vanshika Shukla , Hemant Agrawal Subject: [PATCH v2 01/16] bus/dpaa: use non-block mode for FD open Date: Fri, 7 Oct 2022 08:57:28 +0530 Message-Id: <20221007032743.2129353-2-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221007032743.2129353-1-g.singh@nxp.com> References: <20220928052516.1279442-1-g.singh@nxp.com> <20221007032743.2129353-1-g.singh@nxp.com> X-ClientProxiedBy: SG2P153CA0033.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::20) To AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8198:EE_|AS8PR04MB8641:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d26c785-170b-424d-10f5-08daa8140370 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XhTonqnUoiNKoFc3y/oO/hRx/9oH9i2nAQOLQKCM4La44SGe+tiKfUU5AihrjT7d8TmAKPh/qyKr/01LqCSGAdthWfvQ6Pd5lEz4Cm5TGjq5StIFKHVItHZ1nsnRjZ+oXkTS68zhPaZ68Ad7H62zQHnVK16TU+f4bs00tqKND4YtGD3ecjoZWdviB425Vkl0Y3DLYZjuPfQr8phewqnV7dDHts/zHsWSr28adzw6p7n5Fw5lHUIZQsEN4Wvng/GNm7YKytv1nWuf/RY7oiYLYtwWA4vxmwq0if3zvE2YGpF/TNKmL8CjQgBzPQr7v+s5F+Sdm6sSNw0Dx2twOuNXlk4G2uDuaxYdr5jLx1DZ+IoWYIHRWBQxgCPJLlGTah952OMs8No71i/WB0ZJGNhp8fem/XKL459fvvTam2CDbnGwrH0DuYTUvlq+ZVLvobt2vcLUAtkLKEiXcRfn4al/puEjtYgbb2bZA0pozXxnNb7+ZoQqG9szPs2VBVoSIk9MexZpm3F3KJYb9S+SqcoTrt5DjbxPTNJ+CBNCIG5z81JVigTz2koqGsjmQ0qT7meXsktnyiw9mpgj9IyWMKxU/eZwdgvnYJ2LypZtk+qg5ElFZPqwRtll5HRSHQn5IfYZA9R0I4bjRwpV0oo2qpisj4RdjLMj3OEQqCM4lVCGk+RMwwX/grZU84J+PsL3kQi1wJnHCQ8afWnVgs3jBs79R0BO1nD8bpjyqGISVDQxSXKGpo8MIgZKdOA7EuGUfg2OYnnRemgny8CNDMXIBRFBuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(451199015)(36756003)(54906003)(6486002)(6512007)(52116002)(26005)(83380400001)(6506007)(86362001)(5660300002)(8936002)(41300700001)(2906002)(38100700002)(316002)(38350700002)(8676002)(4326008)(478600001)(186003)(1076003)(6666004)(66476007)(66556008)(2616005)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Xmos1+6C1e22jtF7R20s6zfeyTCWVPAlVwXqaG1TsKKul0yx7q30V3pQQvdCaKu6qoot5qgJT3qBCNzc5N6WJyd0MUrUmoAeD8OO/E8YdV7AE/1vHxxRtRqLQLpkAbbkq5XS1IPoUsEDntvBnMrkpiUUWHIhTppFzljJ6GfNSriKIr7ANiS0ixbA38hIdxO8hSgy9Q/zp6/rzvwyIFypmUPfh26zZ4KVOgt5I56pKkjIbrCh5afSZ2wl526aAhfsexEFf+QdtyzcdCWPRGh//gZYoLQNYmK/764bGM2lj4JqIzvrdVvrXB2I2k9hkOEx/B7FqzU89ldXIAfLC3q68GssoQKuIiqZZywi3mdKJZ6EP0vqk2SWwXw1qtZNNvT6qj988UMKrtR1dvDKXk5mmd515MlwzJlJuYAYU+qAo7al1mYQMCbMkr+WY37kJlYOFIgZnEKfgkBVdKnsqNkz7SuLkLV2G1ai7GLxvKloXMxWh2DpdXyWLIMzaXD2nblOjbMILZitEC47VqBWPxH/n6rjVCN4NUyavsvtU0m9ODVchQuqC15WSDrkYbkMMCNUNEatMogeSduQ0rO/YDqsl7pbsvRnVTzdcIpWZO2iFA6QWG35qubqYSWg6X5yY1K0H/+Q2vPn4S06t3R35juc5zezUxJFmvKKwLOhxPCFp4pFMWSz8sq3HWtjxermPOiU3HiC7i5gRqxbhM8tonDM2cvT4sZfKWOqSwQZYqFLjQyv6cGYF5ioCUrT5pWQEF3BQ9kWOHAhsN06fv0fm0+3MQ93fMnHOgAHtc7hGERlZ91cBq383oNdU6gqtsmwrIog5JNLpCAQ3Io6Xm9Sf9ybmjVYuszF5jSy4iEcbNTg5ZY5PxJO10F0IAz8+IxIQijagy1tzaopo8qdNo990K7v26yp5GsuOEdyTShaC41/Eqq6yys/oK74yBlUw64/Nh4qHvXRp/9JZkCOMXvaTdjtExBeL2MNU+tAOeMccdVzq9q0QpYLb8Karpu8BwVz9kT9WUh3hpuTHbm3Vavuc80lzD1jOL7f71UXsno1PQNK1K3swV3KiwItx4qjTvWm58aEH66gCAJMF/Pd2fJs8PQWn3WR5XrV8YjlZRIGh3+afG9etknjal6P5oZFp7fzazHuYtgGQJQTuc2OPTbzb4Zd8hZPeMfGXDWeg+qzotLUTyKdiBDkh49zjYsdcVKOY/Za4FO668sBtfVLKcUGlvh5IClgS09CBEXMbmpnXvmVh2AU85UO+V3bHC2KYDeOu9HHc7lxgBLfAuPAiGODRBBkVtDCGYSiR4QzDNgAvFTsGhbJZd4TpW4AhbQVlg7tyVSfYdo/7d0dmR9HPEDov2RfhO+PPb1anLBniRYKVpxXE1wCct6ZeHIIqOyrug2W+i7FrPbfSgfUED9W5L63vdhhzK/Qnp1HCix31eFwbocLGUugZRACPtlfGjyZYd6YkIWRjflAb7q7Tp/lPAX9vFp11bhGJqDs/aMVLj439fWkPVYpb4ZtIln3qTeGmAKNR7iKR8rDFByFuMtAU4hwyJ9sQfMUvobiExW0rMELjyluW05DLBQ24gg6aPYuVoN5q8Tc X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d26c785-170b-424d-10f5-08daa8140370 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8198.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2022 03:28:33.8709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h+u3ya/vhWOFgP0lTmYJ7/kZmSSpeEAOspz+Pru/Y7SBQsY03QIiSPQswB6YPDCC X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8641 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Vanshika Shukla This patch sets qman portal file descriptors used for interrupts IO processing in non-blocking mode to avoid any unwanted blocks while IO operations over the FD. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 6 +++--- drivers/net/dpaa/dpaa_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index dfbafe581a..7a129a2d86 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2008-2016 Freescale Semiconductor Inc. - * Copyright 2017,2019 NXP + * Copyright 2017-2022 NXP * */ @@ -64,7 +64,7 @@ static int fsl_qman_portal_init(uint32_t index, int is_shared) qpcfg.addr_virt[DPAA_PORTAL_CE] = map.addr.cena; qpcfg.addr_virt[DPAA_PORTAL_CI] = map.addr.cinh; - qmfd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY); + qmfd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY | O_NONBLOCK); if (qmfd == -1) { pr_err("QMan irq init failed\n"); process_portal_unmap(&map.addr); @@ -174,7 +174,7 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd) q_pcfg->addr_virt[DPAA_PORTAL_CE] = q_map.addr.cena; q_pcfg->addr_virt[DPAA_PORTAL_CI] = q_map.addr.cinh; - q_fd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY); + q_fd = open(QMAN_PORTAL_IRQ_PATH, O_RDONLY | O_NONBLOCK); if (q_fd == -1) { pr_err("QMan irq init failed\n"); goto err; diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index f21cbba0d9..abcb1bc9ec 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1496,7 +1496,7 @@ static int dpaa_dev_queue_intr_disable(struct rte_eth_dev *dev, temp1 = read(rxq->q_fd, &temp, sizeof(temp)); if (temp1 != sizeof(temp)) - DPAA_PMD_ERR("irq read error"); + DPAA_PMD_DEBUG("read did not return anything"); qman_fq_portal_thread_irq(rxq->qp);