[v4,4/9] net/gve: add support for link update
Checks
Commit Message
Support dev_ops link_update.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
doc/guides/nics/features/gve.ini | 2 ++
drivers/net/gve/gve_ethdev.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 32 insertions(+)
Comments
On 9/27/2022 8:32 AM, Junfeng Guo wrote:
>
> Support dev_ops link_update.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
> doc/guides/nics/features/gve.ini | 2 ++
> drivers/net/gve/gve_ethdev.c | 30 ++++++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini
> index 44aec28009..d03e3ac89e 100644
> --- a/doc/guides/nics/features/gve.ini
> +++ b/doc/guides/nics/features/gve.ini
> @@ -4,6 +4,8 @@
> ; Refer to default.ini for the full list of available PMD features.
> ;
> [Features]
> +Speed capabilities = Y
'Speed capabilities' is when device reports supported speeds in
'rte_eth_dev_info_get()', so it shouldn't be in this patch.
Please check 'doc/guides/nics/features.rst' for more details.
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Thursday, October 6, 2022 22:23
> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: ferruh.yigit@xilinx.com; dev@dpdk.org; Li, Xiaoyun
> <xiaoyun.li@intel.com>; awogbemila@google.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>
> Subject: Re: [PATCH v4 4/9] net/gve: add support for link update
>
> On 9/27/2022 8:32 AM, Junfeng Guo wrote:
>
> >
> > Support dev_ops link_update.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > ---
> > doc/guides/nics/features/gve.ini | 2 ++
> > drivers/net/gve/gve_ethdev.c | 30
> ++++++++++++++++++++++++++++++
> > 2 files changed, 32 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/gve.ini
> b/doc/guides/nics/features/gve.ini
> > index 44aec28009..d03e3ac89e 100644
> > --- a/doc/guides/nics/features/gve.ini
> > +++ b/doc/guides/nics/features/gve.ini
> > @@ -4,6 +4,8 @@
> > ; Refer to default.ini for the full list of available PMD features.
> > ;
> > [Features]
> > +Speed capabilities = Y
>
> 'Speed capabilities' is when device reports supported speeds in
> 'rte_eth_dev_info_get()', so it shouldn't be in this patch.
>
> Please check 'doc/guides/nics/features.rst' for more details.
Thanks for the comments!
Will check the features file and update accordingly.
@@ -4,6 +4,8 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Speed capabilities = Y
+Link status = Y
Linux = Y
x86-32 = Y
x86-64 = Y
@@ -34,10 +34,39 @@ gve_dev_configure(__rte_unused struct rte_eth_dev *dev)
return 0;
}
+static int
+gve_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete)
+{
+ struct gve_priv *priv = dev->data->dev_private;
+ struct rte_eth_link link;
+ int err;
+
+ memset(&link, 0, sizeof(link));
+ link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;
+ link.link_autoneg = RTE_ETH_LINK_AUTONEG;
+
+ if (!dev->data->dev_started) {
+ link.link_status = RTE_ETH_LINK_DOWN;
+ link.link_speed = RTE_ETH_SPEED_NUM_NONE;
+ } else {
+ link.link_status = RTE_ETH_LINK_UP;
+ PMD_DRV_LOG(DEBUG, "Get link status from hw");
+ err = gve_adminq_report_link_speed(priv);
+ if (err) {
+ PMD_DRV_LOG(ERR, "Failed to get link speed.");
+ priv->link_speed = RTE_ETH_SPEED_NUM_UNKNOWN;
+ }
+ link.link_speed = priv->link_speed;
+ }
+
+ return rte_eth_linkstatus_set(dev, &link);
+}
+
static int
gve_dev_start(struct rte_eth_dev *dev)
{
dev->data->dev_started = 1;
+ gve_link_update(dev, 0);
return 0;
}
@@ -70,6 +99,7 @@ static const struct eth_dev_ops gve_eth_dev_ops = {
.dev_start = gve_dev_start,
.dev_stop = gve_dev_stop,
.dev_close = gve_dev_close,
+ .link_update = gve_link_update,
};
static void