From patchwork Tue Sep 27 04:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Suresh Narayane, Harshad" X-Patchwork-Id: 116962 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6E25A00C2; Tue, 27 Sep 2022 10:34:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DC2441133; Tue, 27 Sep 2022 10:34:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 17F1D410D0 for ; Tue, 27 Sep 2022 10:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664267640; x=1695803640; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TKiQDb8cOvctN0JE47IWrv85pJpNU1Kdp0Cai/HwDpc=; b=JJpp7cEL7kI3CHMbu7ugTqscVwLoTooEQEDEHn9rtxXRRTlr/u7vdnqV M3nRjPVTab0lOESdhPIAb0l1XwY0VoyEauIXTC8aGDuVc0SlSIuLyor3f Wd1Ov4lfIzJwjPQcHUzkgN9/Ac3li1+D5bdXubGzTik4aNyP7N+anaJe2 /vArEIM1Kp5+X0wmzKnUkmYDw1TEIcgQSPBE/2cW3J2j6t1d7d1UiAWaS BHnTN7WvdsptuY9K9sSYjwY/aey/EGM+LjdU1J/nKCvjJDc+PwjCBC3O/ gGZB2FwjsYHrKt9+jfxTiOYo7APJrO5E+i4I0OjYsPIBKJwt01sV0Srgf Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="288408953" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="288408953" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 01:33:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="725425973" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="725425973" Received: from ena-1.iind.intel.com (HELO localhost.localdomain) ([10.190.200.207]) by fmsmga002.fm.intel.com with ESMTP; 27 Sep 2022 01:33:57 -0700 From: Harshad Narayane To: dev@dpdk.org Cc: Kamalakannan R , Cristian Dumitrescu Subject: [PATCH] net/softnic: fix file close Date: Tue, 27 Sep 2022 00:42:09 -0400 Message-Id: <20220927044209.367093-1-harshad.suresh.narayane@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Coverity issue: 380976 Fixes: e3be2495 ("net/softnic: add pipeline code generation command") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_cli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c index 7891f2b24f..e46383352b 100644 --- a/drivers/net/softnic/rte_eth_softnic_cli.c +++ b/drivers/net/softnic/rte_eth_softnic_cli.c @@ -230,6 +230,7 @@ cmd_softnic_pipeline_codegen(struct pmd_internals *softnic __rte_unused, code_file = fopen(tokens[3], "w"); if (!code_file) { snprintf(out, out_size, "Cannot open file %s.\n", tokens[3]); + fclose(spec_file); return; }