app/eventdev: fix incorrect cleanup check
Checks
Commit Message
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
During cleanup `rte_event_port_quiesce` should be called
irrespective of whether an event has been dequeued or not
to flush any prefetched events.
Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-eventdev/test_pipeline_common.c | 3 ---
1 file changed, 3 deletions(-)
Comments
On Mon, Sep 26, 2022 at 8:35 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> During cleanup `rte_event_port_quiesce` should be called
> irrespective of whether an event has been dequeued or not
> to flush any prefetched events.
>
> Fixes: 7da008df0c8d ("app/eventdev: use port quiescing")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> app/test-eventdev/test_pipeline_common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 4f40d37659..22a3918ed8 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
> {
> int i;
>
> - if (!(deq - enq))
> - return;
> -
> if (deq) {
> for (i = enq; i < deq; i++) {
> if (ev[i].op == RTE_EVENT_OP_RELEASE)
> --
> 2.25.1
>
@@ -696,9 +696,6 @@ pipeline_worker_cleanup(uint8_t dev, uint8_t port, struct rte_event ev[],
{
int i;
- if (!(deq - enq))
- return;
-
if (deq) {
for (i = enq; i < deq; i++) {
if (ev[i].op == RTE_EVENT_OP_RELEASE)