From patchwork Thu Sep 22 13:03:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 116649 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5ADB8A0543; Thu, 22 Sep 2022 15:04:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 873E3410EE; Thu, 22 Sep 2022 15:04:23 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2126.outbound.protection.outlook.com [40.107.94.126]) by mails.dpdk.org (Postfix) with ESMTP id D4C9540156; Thu, 22 Sep 2022 15:04:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZPD0UQDqBYbXy4GV2jJdKj/Op5iHq63uUPqh774wHf7Yx5wQiz3Rmgq14Pu6eUfg0/RyiQsQNKXDSNg2WbU+AHNkMo/hdn6rqU8ByyUkPswFyyi1JWN9FxckAGzjQUICFAGW3KvV8Xqqa1VpEbl8NDOw6o7sG9NJ1cs8EFsHvwac2YRjolIrPRUTjhk3VRZitKt72xwMrWHF8qfDPByJGOUS84gaCiKzLHWtgVxhJJ8dCGJ1ZvFNm8kMMuztyDKXiEhKnOq4UoE787tBx0+RqF0jekg577CEfC4K/E91xLPRazQaAnNOVNMJ5Y6xvEKeTc5WuujazlX/K5uz7doWlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hbuH2paKYpsCFtei2AtNUraxIyNms/T+S7Fpb00asfE=; b=iZYzXmr55TPuev4+n1p8I0Fpj5oxIJg9oYcDNZf+sIwpE3NmUBAf7btUk6nXbfqZy+6uidRRNMZ1HQ/7DWEpzDpGtqNhYszhTCAD9KbFyzQoHsqwuDmbhCr1gZCh0QDNsYASk9gpRaVTBRnqQLJEj+8BYI7D6zCEu/MyxtOm9zjbvdnvtG26+JSnaHZEdsujzy8UJcqv2P1lsfxNHN/RBV39Wco7YCmI+zTjisKGeENBzkGmJ6hWkn7/iipwLTu/COu8CLzzWgCx0VYdoPm03C6yFUieMg0nkeYaY48JFBQH0w1Q/syP72kHSFC8VpIvUseCFnkaN7Gt8t9V2tWEhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hbuH2paKYpsCFtei2AtNUraxIyNms/T+S7Fpb00asfE=; b=nRIV4kffU5G9LRDNQoV+icWjy4HprxJYoKMH1AcHBBpe5lWxnngqBO1hSxrjBLFOZkaZdOvkMq/OB6mGX4UkJPLQbEaf2Fa71tjskhPtnZq623iKezbq8STffI4vqbt/ufaGQR82QFNUXMba36AA9c+Ah5eYve1pN7hgxTcA8Do= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) by DM6PR13MB3626.namprd13.prod.outlook.com (2603:10b6:5:24b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Thu, 22 Sep 2022 13:04:20 +0000 Received: from DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1]) by DM6PR13MB4431.namprd13.prod.outlook.com ([fe80::e198:fd7c:5eb4:89c1%5]) with mapi id 15.20.5654.014; Thu, 22 Sep 2022 13:04:20 +0000 From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: dev@dpdk.org Cc: oss-drivers@corigine.com, Jin Liu , Chaoyong He , stable@dpdk.org, =?utf-8?q?Niklas_S?= =?utf-8?q?=C3=B6derlund?= Subject: [PATCH 1/2] net/nfp: fix return value of nfp card init function Date: Thu, 22 Sep 2022 15:03:13 +0200 Message-Id: <20220922130314.694790-2-niklas.soderlund@corigine.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220922130314.694790-1-niklas.soderlund@corigine.com> References: <20220922130314.694790-1-niklas.soderlund@corigine.com> X-ClientProxiedBy: FR0P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::20) To DM6PR13MB4431.namprd13.prod.outlook.com (2603:10b6:5:1bb::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR13MB4431:EE_|DM6PR13MB3626:EE_ X-MS-Office365-Filtering-Correlation-Id: d5e97c38-e68f-47bb-61f2-08da9c9af661 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /MQwDq7IFFZh+jSMdI8k/zubZc16udpdT0USjDw9ecPYBFIMYEvEyDYKJSDvN9x24m8OXmQ5tY4KXNfc+dBKUWM5Oo8oepQqzpRaYCerFlxVa39RqNWmc7V6hw7cUgtafJvFmUQuRWGWCebq0zWcpd86suvzP5ksAzpo3o63LiF7MI3Rk3jhFNUEQHpp3UcBE9K2mmQ/fOyK8shlc4X/mw/024xqL4gCHoFqDMbaTJ8p8U57JMIP4ndLho772FVATwMndGYvs9L0xhRkyRbK0ug+WYG30e+hJIS0dS/iij9aW5maB29I4v7JAjgG5eeIUxMWvBBoxnRWMJ+x85cgtrwECwsa7gdyB02aS2e4z800c7RXEhs+sgHtwPX/LS3b6dIRTlOEwZLsLZAhkhbNDEQ01H50OK9F7eUFhP//s9PFR53jPXNtiXNL7SrnBCHFLjTKO5j2RJ92Rw2FwUIlzPBlKQbn1cU7ljeVdUuRm1ZV8DzKt3AYviN3VOnJE28elM2N2vndZYmK9GWMirNKOb1zV4mxmKTalVRiabymyPBaMECw7k+Yak27HKERumxSsJHuVgvEViBe+tqNa39D1+Oc5JCdD99K7cvYZzw3idCxPl15JiRJJuTKjEpcBEtMmQkibQoMxLDyTFhDu/L1bCiZMU6nl04guOnp3weega6BigL2UFytt38pTFdC9KzsFIrjZOTy9HvDkf2Rhu2yA1M3WK/M+zESJevpki36QmJlicoHB6+zwiLs0OGoxEfImBnwOmnh9phfFNJYJ3komM+tzlk96RwYo8o8kvHdA3M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR13MB4431.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39830400003)(346002)(376002)(396003)(366004)(136003)(451199015)(86362001)(36756003)(6486002)(478600001)(6506007)(6512007)(6666004)(52116002)(8676002)(66556008)(66476007)(83380400001)(26005)(4326008)(66946007)(2906002)(5660300002)(8936002)(186003)(4744005)(41300700001)(107886003)(54906003)(6916009)(316002)(38100700002)(66574015)(2616005)(38350700002)(450100002)(1076003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?l+UDfcDrWalJ7JEV6w7NFLdPgtME?= =?utf-8?q?2Ttv9vIECJ19O9quEY2Lrsobpzc94bzskzs2fKiJDGzz+BPGX+KVjbqPln/BnBb+6?= =?utf-8?q?U+sh3V6rTDZpRyJak4/AGy8/9DL3A9t6gcd1GBEMTSlnlY0Ob5cknB/EWaOnqswMP?= =?utf-8?q?c8S/9v4GJeI5rnTE0+a8GEDfpx16qOmfShHcZvD28UhfxfW2sbuTXoHESyk3GedH6?= =?utf-8?q?v3mHP5zJtoUEfGotkB3J+EDhBvjJYomcw8MKVlS1WPakAzuHiLmDIWrjrbIOTb6e8?= =?utf-8?q?bk2qWiC1MuIxKICMCOI3KVmLOGurfJTbTErq1O5uvWF3OAdJFiP8QPFrfM45CAEJm?= =?utf-8?q?eBFINDh7jECkIyBuiLZtmtV0N258l+Xyjcqm4ILw9Yk96E4gGpyIMnPjT3i5PH1fv?= =?utf-8?q?PkkVnXK0QsfvLBNWzOLbb4aGt+JKXQUdz8kV0PqA5vvfoRNrbsAwjwP30kb49Iyb4?= =?utf-8?q?OnUg3jB6hh9ld6SzEfhasiowh6yk/rrGwWw5tHvWm8f7WScQ7RrJDZX1UftheRimy?= =?utf-8?q?wjxrstE7dG0GpkkxH+O8Yoev7mRyx7h7Hyonq32kkvYxVfX+NeNf0ybutabpKCApf?= =?utf-8?q?6VAYPkzs9nO1xapmv3KZEFSKQhPHv0Abaw8vd7pQ3uiQprTNrfT1DcXfVdF/8dpP3?= =?utf-8?q?SMzVnNs2c39OGMnLDPuqhIORlHnyJQRXDc25+MAuhBheMtkRNtbsxuNEBulh901EK?= =?utf-8?q?vxC6sOrKI1ilBNNAn3GmPJOKGG8oFraGm5H50nkQDjX/RX1UDDuJdn38xzRQc3CeQ?= =?utf-8?q?sP3zwevjWriLspWvHOVu8hHrpS9/ljV+H+pht1hFuhOLL3OwlJVNDvOF1lNjLOlfh?= =?utf-8?q?HSlmPYQEaw9Xk7tIg9zImM+yQyxvz72PmzMyL+vEXs8KP/SX8M6AJ4PblKAHgNSTE?= =?utf-8?q?mGPwbDstUNzqXurn8dRfP75rSr4QuDSpcxwgCZz4Bo3SFdqhNVHPeb7tbqNl0B/8A?= =?utf-8?q?ic/oqfWV9+Y9tA7cdTpYw+9ld27K4JkYS1rtemkuEu7BB48jPY7zExGOd47bgt94w?= =?utf-8?q?Hbz7RuSe0jTQW7YoegRegu+a48Hjvsvaop6m3LKsQvcKRab1Hk5U7g/i67tg52RaB?= =?utf-8?q?sZ1W5O5F8YGvBCEKtSll9uDUwfrmxmCiCDhsTOjo6YhEbb7LASICT4PNnb6qAylnc?= =?utf-8?q?3Edj+7VWk9YMqPlpV0jiuRbSJTSaQp8kkOvkF8quTm2rafoRrmPr/8qHcgmQ0DnLt?= =?utf-8?q?O/TbXiMgSy9RWHGzRopCal1BAH8wFOoJgljn2uXqTUKOUTL6LrQmUHSCF+S+moRx8?= =?utf-8?q?fTDRJMrX5o4X0fNZNcNGXqbPsSaMpRJH7F4QXRviHTETPaj+En317qyqO3p9kzpJP?= =?utf-8?q?eVXBSWr7K1Sll6TphyNdetud9ZENrqYpEEuZhilylSCoENT4Ifp6AOENKlqugIeM3?= =?utf-8?q?brkG3cOxN4Twi4Tt96bqN3WN/A2Wn49VjR2XXj9Lwg4UoALDYrY62qfKaerhiLUgJ?= =?utf-8?q?n4+Rl5Th3Ya0vMlnwbuHhYTgL3lEleHFuKJv8MOnUOXQHn+PwwMx2dJUxhWxd9+o3?= =?utf-8?q?nD+96CNvJthyGCbleCY9M/FY3tttP6rqvg=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5e97c38-e68f-47bb-61f2-08da9c9af661 X-MS-Exchange-CrossTenant-AuthSource: DM6PR13MB4431.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 13:04:20.1476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6TtPgpRMISNeyYG1Tv2OzAIfgokMXBICgySmDKhwQnNEwTMRkFNv54ZtvLy+Ec/BHSvbl+1paA3IMyXwc9Qwa8PFr7HhLsXJJ1s/+oYAcis= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3626 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jin Liu The return value of 'nfp_pf_init' function is variable ret, but there is one statement, if error occurs, assign error num to variable err, it is incorrect, fixed it. Fixes: 5c464d6a2771 ("net/nfp: support NFP3800 card") Cc: stable@dpdk.org Signed-off-by: Jin Liu Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 2e546cfc5ffc..bc69840777eb 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -924,7 +924,7 @@ nfp_pf_init(struct rte_pci_device *pci_dev) break; default: PMD_INIT_LOG(ERR, "nfp_net: no device ID matching"); - err = -ENODEV; + ret = -ENODEV; goto ctrl_area_cleanup; }