[v3] dumpcap: fix interface parameter check.
Checks
Commit Message
Correction in handling 'IF' condition for -i parameter.
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> Subject: [PATCH v3] dumpcap: fix interface parameter check.
>
> Correction in handling 'IF' condition for -i parameter.
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
15/09/2022 10:44, Pattan, Reshma:
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> >
> > Correction in handling 'IF' condition for -i parameter.
> > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
> > Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Sorry for not noticing, it was merged in DPDK 22.11-rc1.
@@ -240,7 +240,7 @@ static void select_interface(const char *arg)
{
uint16_t port;
- if (strcmp(arg, "*"))
+ if (!strcmp(arg, "*"))
select_all_interfaces();
else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
add_interface(port, arg);