From patchwork Fri Sep 2 03:00:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawen Wu X-Patchwork-Id: 115768 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF7C6A0542; Fri, 2 Sep 2022 05:01:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B87C942B7B; Fri, 2 Sep 2022 05:01:03 +0200 (CEST) Received: from smtpbg.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by mails.dpdk.org (Postfix) with ESMTP id D3D1D427F4; Fri, 2 Sep 2022 05:01:00 +0200 (CEST) X-QQ-mid: bizesmtp70t1662087657tv66i7q0 Received: from wxdbg.localdomain.com ( [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 02 Sep 2022 11:00:56 +0800 (CST) X-QQ-SSF: 01400000000000G0T000000A0000000 X-QQ-FEAT: Vi+pOBAqRtdoGsmo+1b4Jw4WsUJntc0UUppQ1oo4FBB8vbH/FkCm9I45dcAPl Qbgfuy6jScijrO+Ka0oG9HdDLNipcLjKvCKzVQ13HcNoqO5Jqjlnf8bmHPBeIh5wQyQFoCF iC1HpUW3UBw6USckBXNBxNuU1BpSr6lXqQFTyjnQ5T1C+sx00lSKq3WN2OtxWOm362NGT3v ++vuI/rs2hmrC7dYnU8txt8ji+4bRNPna6VTmwZYygbTJ4L5zXSVrpIqT6on+5J3jgzbEZL /g8X6XoS/r0brsYRlcVMZi6Hit0vkkKvWJbGqdHsel2nNd45h5TN+Y/ztlN3LzMtnCZen2A o1r7xhznhYL/9ArVHbqgQhtlWP3T5R3n9sFBqeXoOAv7QNbS288uulS3RqbwnWw5m8r+vkE N3/7rPf4VRo= X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 6/9] net/ngbe: remove semaphore between SW/FW Date: Fri, 2 Sep 2022 11:00:08 +0800 Message-Id: <20220902030011.377523-7-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220902030011.377523-1-jiawenwu@trustnetic.com> References: <20220902030011.377523-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvr:qybglogicsvr5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Since firmware does not use the semaphore between software and firmware. Remove useless unilateral semaphore setting. Fixes: f501a195bded ("net/ngbe: initialize and validate EEPROM") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/base/ngbe_eeprom.c | 32 ----------------------------- 1 file changed, 32 deletions(-) diff --git a/drivers/net/ngbe/base/ngbe_eeprom.c b/drivers/net/ngbe/base/ngbe_eeprom.c index 6375ee9b29..104501fa7a 100644 --- a/drivers/net/ngbe/base/ngbe_eeprom.c +++ b/drivers/net/ngbe/base/ngbe_eeprom.c @@ -105,37 +105,6 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw) status = 0; } - /* Now get the semaphore between SW/FW through the SWESMBI bit */ - if (status == 0) { - for (i = 0; i < timeout; i++) { - /* Set the SW EEPROM semaphore bit to request access */ - wr32m(hw, NGBE_MNGSWSYNC, - NGBE_MNGSWSYNC_REQ, NGBE_MNGSWSYNC_REQ); - - /* - * If we set the bit successfully then we got the - * semaphore. - */ - swsm = rd32(hw, NGBE_MNGSWSYNC); - if (swsm & NGBE_MNGSWSYNC_REQ) - break; - - usec_delay(50); - } - - /* - * Release semaphores and return error if SW EEPROM semaphore - * was not granted because we don't have access to the EEPROM - */ - if (i >= timeout) { - DEBUGOUT("SWESMBI Software EEPROM semaphore not granted."); - ngbe_release_eeprom_semaphore(hw); - status = NGBE_ERR_EEPROM; - } - } else { - DEBUGOUT("Software semaphore SMBI between device drivers not granted."); - } - return status; } @@ -147,7 +116,6 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw) **/ void ngbe_release_eeprom_semaphore(struct ngbe_hw *hw) { - wr32m(hw, NGBE_MNGSWSYNC, NGBE_MNGSWSYNC_REQ, 0); wr32m(hw, NGBE_SWSEM, NGBE_SWSEM_PF, 0); ngbe_flush(hw); }