From patchwork Wed Aug 24 16:24:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Laatz X-Patchwork-Id: 115383 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0634A0543; Wed, 24 Aug 2022 18:23:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54C1F42802; Wed, 24 Aug 2022 18:23:07 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id BACA6415D7 for ; Wed, 24 Aug 2022 18:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661358183; x=1692894183; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=v3UphZ98e5s70i0JAns9ZiwO304zuzaVTbveNkabfCs=; b=d9pz5GKCKA6SZMfV6z0Y7EYHqF1MV8HHVR0W4m/irYFNP7ctpUwE58BY uRHA8mXUB2Q1V3kkjHBZ+D/j5WD35Gr6h/kM5vL9if94Soacj6KnDV37h Y2J8X4mmNqh0UjD1uC6sW8NTPxaKvTt6JF5vAD6fEhdXRARzJ7E9K6wmI ylS3e/RngIZyFYgwnz/W/F5XNxNqcj6llbDMO4laH14TFUGXUIWmm+yMQ 9BVncwwCeBNw1rovdBP3jpA27t5kIjBWObcNDhdNtns+C9P/b93gu4FXF VRzSVcIKr4TNqixwP++M/sM6t/WpAsit/Lvc/vbAP1zgB7knjBn7yaCQj Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10449"; a="292755993" X-IronPort-AV: E=Sophos;i="5.93,260,1654585200"; d="scan'208";a="292755993" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2022 09:21:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,260,1654585200"; d="scan'208";a="699128521" Received: from silpixa00401122.ir.intel.com ([10.237.213.42]) by FMSMGA003.fm.intel.com with ESMTP; 24 Aug 2022 09:21:52 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: anatoly.burakov@intel.com Subject: [PATCH v2 2/3] eal: add cpuset lcore telemetry entries Date: Wed, 24 Aug 2022 17:24:41 +0100 Message-Id: <20220824162442.631456-3-kevin.laatz@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220824162442.631456-1-kevin.laatz@intel.com> References: <24c49429394294cfbf0d9c506b205029bac77c8b.1657890378.git.anatoly.burakov@intel.com> <20220824162442.631456-1-kevin.laatz@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Anatoly Burakov Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 +++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_common_lcore_telemetry.c index e6b58788c8..646b0fbb55 100644 --- a/lib/eal/common/eal_common_lcore_telemetry.c +++ b/lib/eal/common/eal_common_lcore_telemetry.c @@ -19,6 +19,8 @@ int __rte_lcore_telemetry_enabled; #ifdef RTE_LCORE_POLL_BUSYNESS +#include "eal_private.h" + struct lcore_telemetry { int busyness; /**< Calculated busyness (gets set/returned by the API) */ @@ -254,6 +256,48 @@ lcore_handle_poll_busyness(const char *cmd __rte_unused, return 0; } +static int +lcore_handle_cpuset(const char *cmd __rte_unused, + const char *params __rte_unused, + struct rte_tel_data *d) +{ + char corenum[64]; + int i; + + rte_tel_data_start_dict(d); + + RTE_LCORE_FOREACH(i) { + const struct lcore_config *cfg = &lcore_config[i]; + const rte_cpuset_t *cpuset = &cfg->cpuset; + struct rte_tel_data *ld; + unsigned int cpu; + + if (!rte_lcore_is_enabled(i)) + continue; + + /* create an array of integers */ + ld = rte_tel_data_alloc(); + if (ld == NULL) + return -ENOMEM; + rte_tel_data_start_array(ld, RTE_TEL_INT_VAL); + + /* add cpu ID's from cpuset to the array */ + for (cpu = 0; cpu < CPU_SETSIZE; cpu++) { + if (!CPU_ISSET(cpu, cpuset)) + continue; + rte_tel_data_add_array_int(ld, cpu); + } + + /* add array to the per-lcore container */ + snprintf(corenum, sizeof(corenum), "%d", i); + + /* tell telemetry library to free this array automatically */ + rte_tel_data_add_dict_container(d, corenum, ld, 0); + } + + return 0; +} + RTE_INIT(lcore_init_telemetry) { __rte_lcore_telemetry_enabled = true; @@ -268,6 +312,9 @@ RTE_INIT(lcore_init_telemetry) rte_telemetry_register_cmd("/eal/lcore/busyness_disable", lcore_poll_busyness_disable, "disable lcore poll busyness measurement"); + + rte_telemetry_register_cmd("/eal/lcore/cpuset", lcore_handle_cpuset, + "list physical core affinity for each lcore"); } #else