diff mbox series

linux/igb_uio: make module parameters visible in sysfs

Message ID 20220821221213.9591-1-shinae@alkira.net (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series linux/igb_uio: make module parameters visible in sysfs |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-testing warning apply patch failure

Commit Message

Shinae Woo Aug. 21, 2022, 10:12 p.m. UTC 
  - explicitly set default value for intr_mode
- give read permission on wc_activate
- applying patch gives below visibility

```
$ more /sys/module/igb_uio/parameters/* | cat
::::::::::::::
/sys/module/igb_uio/parameters/intr_mode
::::::::::::::
msix
::::::::::::::
/sys/module/igb_uio/parameters/wc_activate
::::::::::::::
0
```

Signed-off-by: Shinae Woo <shinae@alkira.net>
---
 linux/igb_uio/igb_uio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Hemminger July 6, 2023, 2:40 a.m. UTC | #1 
On Sun, 21 Aug 2022 15:12:13 -0700
Shinae Woo <shinae@alkira.net> wrote:

> - explicitly set default value for intr_mode
> - give read permission on wc_activate
> - applying patch gives below visibility
> 
> ```
> $ more /sys/module/igb_uio/parameters/* | cat
> ::::::::::::::
> /sys/module/igb_uio/parameters/intr_mode
> ::::::::::::::
> msix
> ::::::::::::::
> /sys/module/igb_uio/parameters/wc_activate
> ::::::::::::::
> 0
> ```
> 
> Signed-off-by: Shinae Woo <shinae@alkira.net>

Looks ok.
This would have to go against dpdk-kmods tree.
Checkpatch is being overly picky here

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
diff mbox series

Patch

diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 33e0e02..c927ae6 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -44,7 +44,7 @@  struct rte_uio_pci_dev {
 };
 
 static int wc_activate;
-static char *intr_mode;
+static char *intr_mode = RTE_INTR_MODE_MSIX_NAME;
 static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX;
 /* sriov sysfs */
 static ssize_t
@@ -663,7 +663,7 @@  MODULE_PARM_DESC(intr_mode,
 "    " RTE_INTR_MODE_LEGACY_NAME "     Use Legacy interrupt\n"
 "\n");
 
-module_param(wc_activate, int, 0);
+module_param(wc_activate, int, S_IRUGO);
 MODULE_PARM_DESC(wc_activate,
 "Activate support for write combining (WC) (default=0)\n"
 "    0 - disable\n"