[03/13] ethdev: remove experimental tag from flow transfer proxy API

Message ID 20220812191827.3187441-4-ivan.malov@oktetlabs.ru (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ethdev: proceed with flow subsystem rework |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Ivan Malov Aug. 12, 2022, 7:18 p.m. UTC
  rte_flow_pick_transfer_proxy() was first added to DPDK 21.11.
Since then, no one has requested any fixes. At the same time,
the API is required by series [1] in OvS for the new release.

[1] http://patchwork.ozlabs.org/project/openvswitch/list/?series=310415

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 doc/guides/rel_notes/release_22_11.rst | 3 +++
 lib/ethdev/rte_flow.h                  | 4 ----
 lib/ethdev/version.map                 | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)
  

Comments

Ori Kam Aug. 15, 2022, 12:58 p.m. UTC | #1
Hi,

> -----Original Message-----
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> Sent: Friday, 12 August 2022 22:18
> 
> rte_flow_pick_transfer_proxy() was first added to DPDK 21.11.
> Since then, no one has requested any fixes. At the same time,
> the API is required by series [1] in OvS for the new release.
> 
> [1] http://patchwork.ozlabs.org/project/openvswitch/list/?series=310415
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
>  doc/guides/rel_notes/release_22_11.rst | 3 +++
>  lib/ethdev/rte_flow.h                  | 4 ----
>  lib/ethdev/version.map                 | 2 +-
>  3 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_11.rst
> b/doc/guides/rel_notes/release_22_11.rst
> index f039b857e2..b74e90d27f 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -95,6 +95,9 @@ API Changes
>    - ``RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR``
>    - ``RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT``
> 
> +* ethdev: promoted ``rte_flow_pick_transfer_proxy()``
> +  from experimental to stable.
> +
> 
>  ABI Changes
>  -----------
> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
> index e5d2d87403..bc68fd5631 100644
> --- a/lib/ethdev/rte_flow.h
> +++ b/lib/ethdev/rte_flow.h
> @@ -4792,9 +4792,6 @@ rte_flow_tunnel_item_release(uint16_t port_id,
>  			     struct rte_flow_error *error);
> 
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>   * Get a proxy port to manage "transfer" flows.
>   *
>   * Managing "transfer" flows requires that the user communicate them
> @@ -4819,7 +4816,6 @@ rte_flow_tunnel_item_release(uint16_t port_id,
>   * @return
>   *   0 on success, a negative error code otherwise
>   */
> -__rte_experimental
>  int
>  rte_flow_pick_transfer_proxy(uint16_t port_id, uint16_t *proxy_port_id,
>  			     struct rte_flow_error *error);
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index 2ecc1af571..25e54f9d3e 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -132,6 +132,7 @@ DPDK_23 {
>  	rte_flow_error_set;
>  	rte_flow_flush;
>  	rte_flow_isolate;
> +	rte_flow_pick_transfer_proxy;
>  	rte_flow_query;
>  	rte_flow_validate;
> 
> @@ -253,7 +254,6 @@ EXPERIMENTAL {
>  	rte_eth_macaddrs_get;
>  	rte_flow_flex_item_create;
>  	rte_flow_flex_item_release;
> -	rte_flow_pick_transfer_proxy;
> 
>  	# added in 22.03
>  	rte_eth_dev_priority_flow_ctrl_queue_configure;
> --
> 2.30.2

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
  

Patch

diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
index f039b857e2..b74e90d27f 100644
--- a/doc/guides/rel_notes/release_22_11.rst
+++ b/doc/guides/rel_notes/release_22_11.rst
@@ -95,6 +95,9 @@  API Changes
   - ``RTE_FLOW_ITEM_TYPE_PORT_REPRESENTOR``
   - ``RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT``
 
+* ethdev: promoted ``rte_flow_pick_transfer_proxy()``
+  from experimental to stable.
+
 
 ABI Changes
 -----------
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index e5d2d87403..bc68fd5631 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -4792,9 +4792,6 @@  rte_flow_tunnel_item_release(uint16_t port_id,
 			     struct rte_flow_error *error);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get a proxy port to manage "transfer" flows.
  *
  * Managing "transfer" flows requires that the user communicate them
@@ -4819,7 +4816,6 @@  rte_flow_tunnel_item_release(uint16_t port_id,
  * @return
  *   0 on success, a negative error code otherwise
  */
-__rte_experimental
 int
 rte_flow_pick_transfer_proxy(uint16_t port_id, uint16_t *proxy_port_id,
 			     struct rte_flow_error *error);
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 2ecc1af571..25e54f9d3e 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -132,6 +132,7 @@  DPDK_23 {
 	rte_flow_error_set;
 	rte_flow_flush;
 	rte_flow_isolate;
+	rte_flow_pick_transfer_proxy;
 	rte_flow_query;
 	rte_flow_validate;
 
@@ -253,7 +254,6 @@  EXPERIMENTAL {
 	rte_eth_macaddrs_get;
 	rte_flow_flex_item_create;
 	rte_flow_flex_item_release;
-	rte_flow_pick_transfer_proxy;
 
 	# added in 22.03
 	rte_eth_dev_priority_flow_ctrl_queue_configure;