Message ID | 20220724150750.1190-1-dexia.li@jaguarmicro.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Qi Zhang |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94707A0093; Sun, 24 Jul 2022 17:08:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 343F34021E; Sun, 24 Jul 2022 17:08:10 +0200 (CEST) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2055.outbound.protection.outlook.com [40.107.215.55]) by mails.dpdk.org (Postfix) with ESMTP id 233BD400D4 for <dev@dpdk.org>; Sun, 24 Jul 2022 17:08:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jGISDNlGMwzD9YdynMdmpt1sJwBfIH7ftn+ogPhnWrPBO8fGpMOUD9lqbAcXjxG4hDkRBUlBB1JlAI6sIoT8+Xs6LHMcyIIIGPiVLeRM8v/vEXvg13CVGnsn37oAEOipZ1p3BjVWyar7VoHUeei/Aw8JJSs1GDuBLwXdFprTp02B1u8Fj9AJTHbjqDn+zRBUoFcxSXz0ok0ZkHx7H6gYNDUsd7r3QRikfU5R/KyaS6WRMCaIGTfbJVwIEashDQOcg3v5wd5Agfk+dTV0UrU0oC6PZbHOctFioKbej8MkACZ3fZB7YMNrdn7GEcLmXgL8hkrDiBdWg++wHffYONz5eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HYV8tXF074ynx/J7OgmmW5E0KQn5xN3y/hI6D9JyUlM=; b=aNcTQxV10Lb+FYfgYTqajZaQB6bGomG1Mf9PIphb5WsmcfRXWDrDykHW4SI/fhf5RWkBufIxj8j7K5gvTr/BEVTYRadu+G2h4x9eIWH0DYrRPUQMp/DCNt3r3rlA5FoxNap9uN7el8eRzTf02onuBRJJWnME1PXS1QK9D6o+9LTreQm9hu57gB/VUUjC2fXqaDfd3tau9XZCjosqqeVVFqocjRA4Zi7DuvMj+M8TTbrHgm41L6/tP1cEij4jqKkKCkTze6Oer2AqE62LfRuAg1Qjhp/ObYc+DiFqKCKl+NH7ECWmABSe0JYic0+Ld8qHsg0uGdK4t3VakCyfpUdoJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=jaguarmicro.com; dmarc=pass action=none header.from=jaguarmicro.com; dkim=pass header.d=jaguarmicro.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jaguarmicro.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HYV8tXF074ynx/J7OgmmW5E0KQn5xN3y/hI6D9JyUlM=; b=E9YIhhWlT7Bl7GbyEWPv3Ufsh9W49gZk+vDPdvSPg2foUnTBX49y3SOu+xX3RIGaK5jGYCOxMu6fEgNqfLN2VvVXQkDwCQ/XdTUyZb+i8iU+aZM6+4AtJ+/jeY5X/oxITHqFUYEo2HLUNVVHGoPce5u2BmUpU3FA0Ui4ajJOYa+hDQ3TQwIfNMDDgU+Gvn1Q+Lg3BMAAOs4DV/cH1t0OUys/QUWhrs0JXQxUHvgin0JnMO1+iJD8sTQLmP83PvIHIkEIIAFjlPqnE8/gHBEHm98EXDnKTgZ9dCpqY2HK1xsPpYnVPvBa4FI2tpQ3PHkQLxVY8/h1pbIJ1CQ4BIQC0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=jaguarmicro.com; Received: from HK0PR06MB2673.apcprd06.prod.outlook.com (2603:1096:203:31::17) by SG2PR06MB2828.apcprd06.prod.outlook.com (2603:1096:4:1f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Sun, 24 Jul 2022 15:08:05 +0000 Received: from HK0PR06MB2673.apcprd06.prod.outlook.com ([fe80::6178:cdda:50fd:f976]) by HK0PR06MB2673.apcprd06.prod.outlook.com ([fe80::6178:cdda:50fd:f976%7]) with mapi id 15.20.5458.019; Sun, 24 Jul 2022 15:08:05 +0000 From: Dexia Li <dexia.li@jaguarmicro.com> To: dev@dpdk.org Cc: Dexia Li <dexia.li@jaguarmicro.com> Subject: [PATCH] net/iavf: eth pattern support smac and dmac match Date: Sun, 24 Jul 2022 23:07:50 +0800 Message-Id: <20220724150750.1190-1-dexia.li@jaguarmicro.com> X-Mailer: git-send-email 2.33.0.windows.2 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SGXP274CA0020.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::32) To HK0PR06MB2673.apcprd06.prod.outlook.com (2603:1096:203:31::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c53cb47-4b17-4634-c301-08da6d864f90 X-MS-TrafficTypeDiagnostic: SG2PR06MB2828:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jCC0mh5Ar76m5I8K8n9SNsjh991sBr0GFHL4cwrEffT2ieQjabnjWDOEOxTZ8vaLCeywg5FUi/Is7QCFeHjVJt59QnJ4WebrH6CjSCfAVtzHBMvIVqFlH1idprHAtwsAejnWI6VzDcWI386wd8rMOGiNnM4m63pWE6fmMfvp88MzWO0Ltt0sxY7fNE2VRPiF+PPVgPPqXo7zZjj/4y9j8aF2xQ5dtxW/3lgBgcgbzAFna5ubgBIxciiM4AMjUcgyx0UisRFxwpzLP9/f0NpqwRQ5273HBS2oYONEpGN4f2gzafj4z7Lapg7qe2OEDjSbFOt2Erz8Zs+K7GAWmJMJdjQ+IdEK1wBz97Zv/pUEJprBEFkp7N8ThHDcOPeXfa4SgNwmXLX7vbZcgcpFFIn7SNfeqg8XpOPu6rNq6EQXBsje+hSLzdYaw2mdKlQHzzKoZ4Q6KrKEoAbuWyt1lk5MxWKRXwWlc/hJ/Lo++1+VvTaiFl3k50XQ93SmuwydPnz3Yem8bu127w4WxhWuHW4iDzucoEqKUaCplPYc1aZY6HbJHwlXHTcjxub3a8zuNx7XufFyrSX0sdVmGV14wehd6lq6laAJKDphjHxzv+zKE+lQUQGMW4uK2cvhnhK7HI1DNQNPek7IGdWwZu8N19wb27t138aHqXB+P1KCVEyn+HV6IZ2VQevznEMfQ7yqD2zak9mX6jjpo47wbEb8dgFJ75+MBWIcOvF5bJ9jXngY2lOHi3697Tq/o+qAMiWoVpXwsGSCrlQylqPhnqvbQMGxKBbuWqvsRgJpLJ5NDq2A0fw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR06MB2673.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(136003)(376002)(366004)(396003)(39830400003)(6916009)(316002)(41300700001)(6666004)(52116002)(6506007)(10290500003)(478600001)(6486002)(2906002)(66946007)(8676002)(66476007)(66556008)(5660300002)(4326008)(44832011)(4744005)(26005)(8936002)(86362001)(36756003)(38100700002)(38350700002)(6512007)(107886003)(186003)(1076003)(2616005)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5wTonCbdt0qxl1mcwqTlININu/VlWB1EJreZjNzT/AgnwF1ps+SDo/gS15KCYlcxSUyYQ0aovkwSmB1bMIB/TLLMUmADgdDvszbERWCtXAfrQejD+VetJAZ6U6ALtogcbqrT4675O/pKwhQbz5jXYHh/VdWU85/baKABfqspSDGa5iFg1OA2JAWpfnlYAjHC4tOXN58hLGr8p2yBWeZDxry3Xh+ZU5bmI7JwqSUMBj70cjcDmuSm9i3cPqSgblk+ZSaTUidBZIUj2TdA6M3wOigJDPZU0Y+AG1xpX2YkMSKWSXuSITZD7Bohxpq3LTjaynot0qkjtA7K9etn+wYvTJQch7QfmDcjlhrTSpaxvpjUcXlgnqg7HC4Ho8rAdUUCIlk0U3TXsVcXojDBfSmyb8UwCET6NqH7w6gaUVyIOOXxPsGtcH0XM326GoffdVJU88eXORtI7u38zyOhLJRYOl6tCppMC2MxdJiL6OzcCAA+1OOe0PQrjcHshYWSNm/R93OWPw6InS9VO7lpB4cdLZYT4wNJhZCrCuPz4ui9ZDvgMxMvKKYqHNUlmJtE2Rfx1TdI/EoyxnDwsH9srQ3SYyEuw7TuifxkXKJIpMkejFPygf0AvbkpOOjVCbKCsCYa4IdYfFig57X7MXX36CnOZcE6FaUiU6TXZe8HN/yLGPNPhm1oU+hyAmXoUPqLbreII4Th65SJuqnlf+4AvbHLIIaul4vfJydf8UB7EkHccKoN5PWDiviUsUo2IsLpEu+f5RCCxAG9lq4sik23CImm5eG5hTuelExg3fcjQJIQ7M9+9I/Fp2yOprvqi8QmpIpUK6L+655a7xi/hr+5VlYBeiRF2KSIEq+gn+v+Ei1r4wNeYJi5czdKb5fMjI1LKfaQubV+70SFyJaeVDSShm89w55E6WDcS46a309svkDgSpE6Tf/NWDXQaavubTn17NMTsuZwStHc+/rj+Z4PpSFBwWoaY22lA2hMWBzbSy5kqWyp/CqPtknS9bcFK7uas97zfc79D+cl/G76c5Uke7+LPdHD7nJCWiX3R6EN3r+xX/C088b9PwJTyiK2C7PTHv3qPtnG6yxC7VDUhb26Oclnc7tlXeF0NhOPRSpOQFUmzgF6etCVqWa9UlIjAmK1UpLahMcG5DGyZPzPyW/bpxVwbTheFmfkduuqOQ6v3DGHHTfYrOHJvuCr4R01hwE2feygj3rJ/zWdp+ve4go0n1rTfJACkLczrKYt6N/4QcYwOx7DSA7TqVC3qgSU5B42FSJ2L3wZ9zwBilLa5U2YENY1fyaBVdEFyJ9SZArzI+DdhKQ9HFWir7B0tpYebObZoSuKjX8OZLw/vvt1lsv4L6Qx+Rj3GC3swxLtMgfU4pA2rycdzAOpAykfogrrF81wzV0Vv8lhpBRywcyjzFEVnqXT3FN7gj5LXKswmIkiV2Wuuh9EJmvYAGlWRf1QXohidzVGWgn3fL1kINoXczTeR9Tj0Bb2T4KHcgiFu3MErYlh/jo+kM8p60+HxdPEV8mVK0g24S6p9+X3VRM14pXPYWAMCmHI5I3LieADD4hgy2CqA6Ux52waOmry6NkN7M+OvnWW/6iqwyA+Lbxowy3MQN76OA== X-OriginatorOrg: jaguarmicro.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c53cb47-4b17-4634-c301-08da6d864f90 X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB2673.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2022 15:08:05.6622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tGK5jzwq4tcHjr3XHxvm7GnazDUqO+JCUXhRXRd7nSffSzSchBHCHAXLX/hUdoom+eXadBheTjCBTkxVi19yQMOqq66cG3UZ9eDQkqIRRBk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2828 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net/iavf: eth pattern support smac and dmac match
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
ci/intel-Testing | success | Testing PASS |
ci/iol-aarch64-compile-testing | success | Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-aarch64-unit-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-intel-Functional | success | Functional Testing PASS |
ci/iol-x86_64-compile-testing | success | Testing PASS |
ci/iol-x86_64-unit-testing | success | Testing PASS |
ci/github-robot: build | success | github build: passed |
Commit Message
Dexia Li
July 24, 2022, 3:07 p.m. UTC
Position src and dst mac bit in iavf fdir eth inset, thus
eth pattern can support src and dst mac match.
Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com>
---
drivers/net/iavf/iavf_fdir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Sunday, July 24, 2022 11:08 PM > To: dev@dpdk.org > Cc: Dexia Li <dexia.li@jaguarmicro.com> > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern can support > src and dst mac match. Hi Dexia, As this rely on kernel PF support. May I know how you prove this feature, which kernel pf driver version you used. Thanks Qi > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > --- > drivers/net/iavf/iavf_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index > 4789d46ab2..2e6b3a9097 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -29,7 +29,7 @@ > #define IAVF_GTPU_EH_UPLINK 1 > > #define IAVF_FDIR_INSET_ETH (\ > - IAVF_INSET_ETHERTYPE) > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > -- > 2.33.0.windows.2
Hi Zhang Qi, When I test ovs parial offload using iavf, then found it can not offloaded. Ovs flow like this: ovs-ofctl add-flow br-int in_port=1,dl_type=0x0800,dl_dst=52:51:00:00:00:21,action=output:2 I use ice 1.6.7 Pf driver. After modified this code, this flow can be offloaded. Thanks Dexia -----邮件原件----- 发件人: Zhang, Qi Z <qi.z.zhang@intel.com> 发送时间: 2022年7月25日 7:37 收件人: Dexia Li <dexia.li@jaguarmicro.com>; dev@dpdk.org 主题: RE: [PATCH] net/iavf: eth pattern support smac and dmac match > -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Sunday, July 24, 2022 11:08 PM > To: dev@dpdk.org > Cc: Dexia Li <dexia.li@jaguarmicro.com> > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern > can support src and dst mac match. Hi Dexia, As this rely on kernel PF support. May I know how you prove this feature, which kernel pf driver version you used. Thanks Qi > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > --- > drivers/net/iavf/iavf_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c > b/drivers/net/iavf/iavf_fdir.c index > 4789d46ab2..2e6b3a9097 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -29,7 +29,7 @@ > #define IAVF_GTPU_EH_UPLINK 1 > > #define IAVF_FDIR_INSET_ETH (\ > - IAVF_INSET_ETHERTYPE) > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > -- > 2.33.0.windows.2
> -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Monday, July 25, 2022 11:12 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org > Subject: 答复: [PATCH] net/iavf: eth pattern support smac and dmac match > > Hi Zhang Qi, > When I test ovs parial offload using iavf, then found it can not > offloaded. > Ovs flow like this: ovs-ofctl add-flow br-int > in_port=1,dl_type=0x0800,dl_dst=52:51:00:00:00:21,action=output:2 > I use ice 1.6.7 Pf driver. > After modified this code, this flow can be offloaded. OK, as this is already proved, I don't see any issue for this change. Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi > > Thanks > Dexia > > -----邮件原件----- > 发件人: Zhang, Qi Z <qi.z.zhang@intel.com> > 发送时间: 2022年7月25日 7:37 > 收件人: Dexia Li <dexia.li@jaguarmicro.com>; dev@dpdk.org > 主题: RE: [PATCH] net/iavf: eth pattern support smac and dmac match > > > > -----Original Message----- > > From: Dexia Li <dexia.li@jaguarmicro.com> > > Sent: Sunday, July 24, 2022 11:08 PM > > To: dev@dpdk.org > > Cc: Dexia Li <dexia.li@jaguarmicro.com> > > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern > > can support src and dst mac match. > > Hi Dexia, > As this rely on kernel PF support. > May I know how you prove this feature, which kernel pf driver > version you used. > Thanks > Qi > > > > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > > --- > > drivers/net/iavf/iavf_fdir.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_fdir.c > > b/drivers/net/iavf/iavf_fdir.c index > > 4789d46ab2..2e6b3a9097 100644 > > --- a/drivers/net/iavf/iavf_fdir.c > > +++ b/drivers/net/iavf/iavf_fdir.c > > @@ -29,7 +29,7 @@ > > #define IAVF_GTPU_EH_UPLINK 1 > > > > #define IAVF_FDIR_INSET_ETH (\ > > - IAVF_INSET_ETHERTYPE) > > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > > -- > > 2.33.0.windows.2
diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index 4789d46ab2..2e6b3a9097 100644 --- a/drivers/net/iavf/iavf_fdir.c +++ b/drivers/net/iavf/iavf_fdir.c @@ -29,7 +29,7 @@ #define IAVF_GTPU_EH_UPLINK 1 #define IAVF_FDIR_INSET_ETH (\ - IAVF_INSET_ETHERTYPE) + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) #define IAVF_FDIR_INSET_ETH_IPV4 (\ IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \