diff mbox series

[RFC,v2,v2,29/29] dev: hide device object

Message ID	20220709082644.664675-30-david.marchand@redhat.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com> Subject: [RFC v2 v2 29/29] dev: hide device object Date: Sat, 9 Jul 2022 10:26:44 +0200 Message-Id: <20220709082644.664675-30-david.marchand@redhat.com> In-Reply-To: <20220709082644.664675-1-david.marchand@redhat.com> References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220709082644.664675-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Bus and device cleanup for 22.11 \| [RFC,v2,v2,00/29] Bus and device cleanup for 22.11 [RFC,v2,v2,01/29] common/mlx5: rework check on driver registration [RFC,v2,v2,02/29] raw/ifpga: remove PCI bus accessor [RFC,v2,v2,03/29] kni: stop populating PCI info in examples [RFC,v2,v2,04/29] examples/ethtool: prefer device name [RFC,v2,v2,05/29] dev: hide debug messages in device iterator [RFC,v2,v2,06/29] dev: move unrelated macros from header [RFC,v2,v2,07/29] devargs: remove dependency on bus header [RFC,v2,v2,08/29] bus: remove unneeded inclusion of bus header [RFC,v2,v2,09/29] bus: move IOVA definition from header [RFC,v2,v2,10/29] drivers/bus: remove back reference to bus objects [RFC,v2,v2,11/29] drivers/bus: hide specific structures [RFC,v2,v2,12/29] bus: introduce accessors [RFC,v2,v2,13/29] bus: hide bus object [RFC,v2,v2,14/29] bbdev: mark driver header [RFC,v2,v2,15/29] ethdev: mark some headers as driver only [RFC,v2,v2,16/29] rawdev: mark driver header [RFC,v2,v2,17/29] drivers: export drivers headers [RFC,v2,v2,18/29] bus/auxiliary: make driver-only headers private [RFC,v2,v2,19/29] bus/dpaa: make driver-only headers private [RFC,v2,v2,20/29] bus/fslmc: make driver-only headers private [RFC,v2,v2,21/29] bus/ifpga: cleanup exported symbols [RFC,v2,v2,22/29] bus/ifpga: make driver-only headers private [RFC,v2,v2,23/29] bus/pci: make driver-only headers private [RFC,v2,v2,24/29] bus/vdev: make driver-only headers private [RFC,v2,v2,25/29] bus/vmbus: make driver-only headers private [RFC,v2,v2,26/29] dev: introduce driver name [RFC,v2,v2,27/29] dev: hide driver object [RFC,v2,v2,28/29] dev: introduce device accessors [RFC,v2,v2,29/29] dev: hide device object

Checks

Context	Check	Description
ci/Intel-compilation	success	Compilation OK
ci/intel-Testing	success	Testing PASS

Commit Message

David Marchand July 9, 2022, 8:26 a.m. UTC

  Make rte_device opaque for non internal users.
This will make extending this object possible without breaking the ABI.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/eal/common/eal_private.h |  2 +-
 lib/eal/include/dev_driver.h | 14 ++++++++++++++
 lib/eal/include/rte_dev.h    | 13 +------------
 lib/vhost/vdpa.c             |  1 +
 4 files changed, 17 insertions(+), 13 deletions(-)

diff mbox series

Patch

diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 44d14241f0..3ca9ce2ffc 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -10,7 +10,7 @@ 
 #include <stdio.h>
 #include <sys/queue.h>
 
-#include <rte_dev.h>
+#include <dev_driver.h>
 #include <rte_lcore.h>
 #include <rte_memory.h>
 
diff --git a/lib/eal/include/dev_driver.h b/lib/eal/include/dev_driver.h
index 015188abd5..01c3e30994 100644
--- a/lib/eal/include/dev_driver.h
+++ b/lib/eal/include/dev_driver.h
@@ -12,6 +12,8 @@  extern "C" {
 #include <rte_common.h>
 #include <rte_dev.h>
 
+struct rte_devargs;
+
 /**
  * A structure describing a device driver.
  */
@@ -21,6 +23,18 @@  struct rte_driver {
 	const char *alias;              /**< Driver alias. */
 };
 
+/**
+ * A structure describing a generic device.
+ */
+struct rte_device {
+	RTE_TAILQ_ENTRY(rte_device) next; /**< Next device */
+	const char *name;             /**< Device name */
+	const struct rte_driver *driver; /**< Driver assigned after probing */
+	const struct rte_bus *bus;    /**< Bus handle assigned on scan */
+	int numa_node;                /**< NUMA node connection */
+	struct rte_devargs *devargs;  /**< Arguments for latest probing */
+};
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/eal/include/rte_dev.h b/lib/eal/include/rte_dev.h
index a80447a645..3077cf3f0f 100644
--- a/lib/eal/include/rte_dev.h
+++ b/lib/eal/include/rte_dev.h
@@ -25,6 +25,7 @@  extern "C" {
 
 struct rte_bus;
 struct rte_driver;
+struct rte_device;
 
 /**
  * The device event type.
@@ -127,18 +128,6 @@  __rte_experimental
 int
 rte_dev_numa_node(const struct rte_device *dev);
 
-/**
- * A structure describing a generic device.
- */
-struct rte_device {
-	RTE_TAILQ_ENTRY(rte_device) next; /**< Next device */
-	const char *name;             /**< Device name */
-	const struct rte_driver *driver; /**< Driver assigned after probing */
-	const struct rte_bus *bus;    /**< Bus handle assigned on scan */
-	int numa_node;                /**< NUMA node connection */
-	struct rte_devargs *devargs;  /**< Arguments for latest probing */
-};
-
 /**
  * Query status of a device.
  *
diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c
index bdebcbe565..aaf3f267e9 100644
--- a/lib/vhost/vdpa.c
+++ b/lib/vhost/vdpa.c
@@ -10,6 +10,7 @@ 
 
 #include <sys/queue.h>
 
+#include <dev_driver.h>
 #include <rte_common.h>
 #include <rte_class.h>
 #include <rte_malloc.h>