net/iavf: increase the reset complete wait count

Message ID 20220527021315.110411-1-qiming.yang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series net/iavf: increase the reset complete wait count |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Qiming Yang May 27, 2022, 2:13 a.m. UTC
  Kernel iavf driver has sent patch to increase the completion
wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Cc: stable@dpdk.org

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/iavf/iavf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Qi Zhang May 27, 2022, 4:27 a.m. UTC | #1
> -----Original Message-----
> From: Qiming Yang <qiming.yang@intel.com>
> Sent: Friday, May 27, 2022 10:13 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: increase the reset complete wait count
> 
> Kernel iavf driver has sent patch to increase the completion wait time to
> reduce the "Reset never finished" case.
> Follow this action in DPDK iavf driver.

Could you add a link to the corresponding kernel patch, so people can know why we need this change
  
Qiming Yang May 27, 2022, 4:49 a.m. UTC | #2
sure

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: 2022年5月27日 12:28
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: increase the reset complete wait count
> 
> 
> 
> > -----Original Message-----
> > From: Qiming Yang <qiming.yang@intel.com>
> > Sent: Friday, May 27, 2022 10:13 AM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: increase the reset complete wait count
> >
> > Kernel iavf driver has sent patch to increase the completion wait time
> > to reduce the "Reset never finished" case.
> > Follow this action in DPDK iavf driver.
> 
> Could you add a link to the corresponding kernel patch, so people can
> know why we need this change
  

Patch

diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index f1c2daa06e..025ab3ff60 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -18,7 +18,7 @@ 
 
 #define IAVF_AQ_LEN               32
 #define IAVF_AQ_BUF_SZ            4096
-#define IAVF_RESET_WAIT_CNT       50
+#define IAVF_RESET_WAIT_CNT       500
 #define IAVF_BUF_SIZE_MIN         1024
 #define IAVF_FRAME_SIZE_MAX       9728
 #define IAVF_QUEUE_BASE_ADDR_UNIT 128