[v3,10/10] net/cnxk: fix telemetry possible null pointer access
Checks
Commit Message
The return value of rte_tel_data_alloc() may be null pointer, in this
patch, the null check function is added.
Fixes: 5ea354a1f2cc ("net/cnxk: support telemetry")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
drivers/net/cnxk/cnxk_ethdev_telemetry.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 5/5/22 11:02, Chengwen Feng wrote:
> The return value of rte_tel_data_alloc() may be null pointer, in this
> patch, the null check function is added.
>
> Fixes: 5ea354a1f2cc ("net/cnxk: support telemetry")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
@@ -49,6 +49,8 @@ ethdev_tel_handle_info(const char *cmd __rte_unused,
rte_tel_data_add_dict_int(d, "n_ports", n_ports);
i_data = rte_tel_data_alloc();
+ if (i_data == NULL)
+ return -ENOMEM;
rte_tel_data_start_array(i_data, RTE_TEL_U64_VAL);
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {