From patchwork Fri Apr 29 20:00:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Don Wallwork X-Patchwork-Id: 110530 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0974FA0507; Fri, 29 Apr 2022 22:02:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99DBE415D7; Fri, 29 Apr 2022 22:01:59 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by mails.dpdk.org (Postfix) with ESMTP id 08120410E3 for ; Fri, 29 Apr 2022 22:01:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tcb8caX2xSZpmeiZOZwgNl65qUw2T51DLAYWzDdor4u5YOcKYUm7gfpHaAusn4WzVIT0DCc4ikHpGCKHgBdqj148sWxC3NmVNM2YN0mUVxu3slcDdoVG161b5DzOHvPBbKaBJClZfhc1drNXwCjbkX/N+4mvsXdTRJNyNsQ0hk5nfdp6l13Kg+squMuw3KUEq1zJpY0zq9Uzm6ZM2PGMSMlhoXs9Xo9Zq5X99moNQ1rS6acnnde7rfdqPEG3v6TRSd0wgxluG66onfITkBYdHbMWP/9nQWi+cclcWyRzbN4Xug444j5RmBemp2YqhXZ7TqPwUTUgUwHt4ZbSY9/SBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ISUujvtu/Tk/nmjmtx5YkFp3mUB+i5XvazskfnbDKOk=; b=OH4pHlbhfuQoZo2BOzA2Iqb46h0dJS0IBhxG/W0DnyHVJAOcFyRqKvt8astEWgvdJe/Coh6WXcG2Slem+PF05eSV9vl6OMuvtlz3LZYzEa09iS0QfcjdsBdlyweZD9n/FUTAJWPwY5Xc6/42r9wmKHQqTVsSvF0DmqN/IknR2G2rCR5H57le9BDRoDnmmBUYDa9w1AsJgxE2d+6oa0OVD8hmOzxXw9tslSOptmaMepLjzwR/nYywwdjS/12L+F6ZGHRjNY2UD4GXfnGb0mdL858sUCzHX5tZ86Pbrs8qybihLpKWq2su+S1rSeOQxIxdpHeAHfA0DMsuC0PTy9rspw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xsightlabs.com; dmarc=pass action=none header.from=xsightlabs.com; dkim=pass header.d=xsightlabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xsightlabs.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ISUujvtu/Tk/nmjmtx5YkFp3mUB+i5XvazskfnbDKOk=; b=ytjrGwcocuXaa6k1EGS32nQUQuYYbwSLO5DIEivNTpBY33ftE0Lersyhc96wYRp2dHfjIoYtyT6wJZS9jfuRF3L9PIgyicIFzOCwwWHwU7MbEMPp4YH0CAMfts5Ib42MJV6t60kSu/T8UIk5QeL5CxOdSiMphVHTT1/tNG+rUHE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xsightlabs.com; Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) by PAXP193MB1247.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:de::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Fri, 29 Apr 2022 20:01:56 +0000 Received: from DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::3c11:328c:a5e5:7253]) by DB9P193MB1482.EURP193.PROD.OUTLOOK.COM ([fe80::3c11:328c:a5e5:7253%5]) with mapi id 15.20.5206.014; Fri, 29 Apr 2022 20:01:56 +0000 From: Don Wallwork To: dev@dpdk.org Cc: donw@xsightlabs.com, stephen@networkplumber.org, mb@smartsharesystems.com, anatoly.burakov@intel.com, dmitry.kozliuk@gmail.com, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, nd@arm.com Subject: [RFC v2] eal: allow worker lcore stacks to be allocated from hugepage memory Date: Fri, 29 Apr 2022 16:00:37 -0400 Message-Id: <20220429200037.29114-1-donw@xsightlabs.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220426122000.24743-1-donw@xsightlabs.com> References: <20220426122000.24743-1-donw@xsightlabs.com> X-ClientProxiedBy: BL1PR13CA0016.namprd13.prod.outlook.com (2603:10b6:208:256::21) To DB9P193MB1482.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:2a6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4b758761-fb84-45f3-294e-08da2a1b1cab X-MS-TrafficTypeDiagnostic: PAXP193MB1247:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YTTxO2nUjaveU6f/hzmr3Edv/OPobb4ei8xPpSkoQGPITge8LeQmn+oEiEeASWVW72NYKXbG6zfckyeCV/xia5uSHIMs+gjG/GOkSPFGnSgE2BZwHJMDrqNyKD26P2uymAqfThv49o24Nc1X6ceb4l0JADzdL1yhJb9b7uNji9Hfd3KWj5lyIQMlzihCxwzBKEcugZaKCUc7N69lcaMzHaAFX1P2OLfs5pzTmJjyzwyW6c2hah7gIRUyRo/qyhWk87adU+wgXl8LZsgyGRBEnM/KGRjly4oYqrVgFmycNL5lLLaj6XE+lAky9OiJW3JuLBsMzcIF8fRhVgx4biqkRi99AmCXod9rIit8qdbY+uIBbPo5VFrFiiV8V3XCAH81DXW+B4IgbzZNBO/LOO4FUReIQmz0yBu0unJEUNY3xW5FkJrlK2MTpFI7bCaem8fPjKCFzc/7geUix5VGL+dqCfhAamEYTDXXEUpy1t3F9kCP4Xyv99f7oDL06j/ZHDudXQeYOiwDY3GXsC+DSzAUU1kLhXEEO3NXpxRT2VkeXzSGH6xtGezm6sYJTEqskyYuf9NyZ+fZLZs/1r8s4MQlfdx0obwcKe94x2V2g2DDq5VbeFz5ynTKTt61MkzqhbcHbOP0i7MyDn0YvY80LJpjroaZdjNrD2OqgD8CqDDjJ2c48am+OlyaodWSFV/NED5k X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P193MB1482.EURP193.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(52116002)(6512007)(6666004)(26005)(2906002)(6916009)(8676002)(4326008)(86362001)(508600001)(6486002)(66556008)(66476007)(83380400001)(66946007)(36756003)(5660300002)(1076003)(186003)(38350700002)(2616005)(8936002)(38100700002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: U1fXLpzdHIjhgXb0dMBWUQq3DHP6/t75SBlA6Wo/Oznc6me10DQYTCNK+j0bP7YQGVRp0bIHqpncknI+IlVSsmhVhCwuodRQCkXwPT6LO9zJyq7LzPg7y1V/QDmVzYLbHUAmDFWrMntbYVYNYS6GgovLqAxHbxI7TmF8XMoAxRSKONzcPUUUIkUl18zwtIvDmCWKSfi+/daMWltlYX8eZH7tn+ebR1aJVBcUo98UrZIsLW3ketP5H5rgcy23DBoQakSva+Ex1yBT19Y8zIMvz2162JPef1vK4JWV+Qt2G/fsjE1vgoXsINi5dMdwFwB5xTkztKOdwKwAI/TGBojoue0bzYzTH/dPRgCcCc79wsS7yD1MeSZ3ctwC9M0NVOMvP1XU9YwXeZTnnwjo/cdNlEMO0rd166ImDkDwnM3qSFH2HuQcm6kA25wANcOUy3bsGCpDEbrmpIzTCfV5kAt9VzeViVe8LENZJxFICQo6Jee0YJwYOeiO4FMHfAby5umNuOlmMiAqNOVJS4N0R19siMrLoeR9StTi37s7BqBVbQtYGFOtv4ytXEZuOLMcsMDUmCOced4NHwX/FDSrWFfOKtNzcuVcZBbtpTEu4uX4Rt1YjfuI3aTjWxjCrniv/xjjcvQkpl59pLP226k7uv4bMAQ5YWT8CViTP+oNI9Pya3JJxMNA8UUEhFraUegh+9Roxb5ShaH/ZjI1Xp839OLpHE1QoHEiTuLuXdvQ+EZpJwshgINFe/gj/0cHQFeR6HqwAH7INot/V7+XQYdNy+X1NvGAHdycHGwc+073R4V5n/Q39ycqvw/KYTwF5PeoP49XFRp7ubInuRU5h9bAtGuNdhlko5gyC4plBM9g5zY8ioHOTjfvVacPaC4puhvsT3aaL32hPoEnxUP0v+OIqtyYTQUY6Cs1ijiRoR3YsPDHMAWyZGVZy2V6DfZqzfYUp2nyO/YpDOxpJoTMB4Gsh0igYquTbC+PmuZP/UzZwxAF7lBZBERyHjM+pVPUk2Txg5TVSUwJbn8cupxzHi+7zutFQNKOBzGipDfV+4zCuPTm47cX5gtekd/ElrUp4ctB+AneQbiLYp5j8EcYgox8km9jNoRaFvEf3+3JLYDS7/tQoFTXY1pjoJFCYdEmHcwt6U9Q2bb7eNdbLj/uWb1u7kH3zOgfDVKt/WvIUKXJwO0tcbVDaxLNbPZCV59nzGy9eFptkLYbLJ2eUg/c8QD9Foiziky4i5gc16cFLNq2st5h+Ymcx5iH/BNxFkpG1148+CnBNs5J2PfeAilb3PR9cRMxDjArw2WhuZO+S71u065ekEoiylG8xJgzySsfLCF6dZdp53TChTpVc0AXYOpUSPt4ZoipgjNQCCeAcv30tXDkWPCNTG0a0SxYMG5Jiw4ojxpUKoZiLdQJ4gExvOqZdyVuEoyA0gHa7GBdaSBB8w9VReAp2ac5E0UZttyIftU0avAmPm8+JzgyybwjOOeM5myst65WprPIsypzmv74nDSzUKzne2tHl+rZt5GNGOyf/hNxwgJNnW+SUmihmTYCmrXBxtzIqfOTO/ubVMlZRq8X8HhVzDXWiBxYsVNQHpYGo/q+vhRFbLOc2nfgbOpAj2tuIX2xCJ3YzLMUBhCUMnfn/lcJb53h+n1qB/YjQLtCkbUl7XWsWk1tuwwQRLZYhMAWvrIwZJlknVLrn3vREz2umNCokHIJLnMq+PMyLwhXOcIKaCvcVR9aRstSFwtNOKC4bg== X-OriginatorOrg: xsightlabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b758761-fb84-45f3-294e-08da2a1b1cab X-MS-Exchange-CrossTenant-AuthSource: DB9P193MB1482.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 20:01:56.1527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 646a3e34-83ea-4273-9177-ab01923abaa9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bYvDBeSIXjhg/Lq4BsSQ0qW1EL94MAXG5y2XeuO9p9h+DSTB5uVb6c5cXdPkkGlZwKk3BHrPWUeUf/gWzfm3Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP193MB1247 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. EAL option '--huge-worker-stack [stack-size-kbytes]' is added to allow the feature to be enabled at runtime. If the size is not specified, the system pthread stack size will be used. Signed-off-by: Don Wallwork Acked-by: Morten Brørup --- lib/eal/common/eal_common_options.c | 26 ++++++++++++ lib/eal/common/eal_internal_cfg.h | 4 ++ lib/eal/common/eal_options.h | 2 + lib/eal/linux/eal.c | 65 ++++++++++++++++++++++++++++- 4 files changed, 95 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index f247a42455..7473ba6969 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -103,6 +103,7 @@ eal_long_options[] = { {OPT_TELEMETRY, 0, NULL, OPT_TELEMETRY_NUM }, {OPT_NO_TELEMETRY, 0, NULL, OPT_NO_TELEMETRY_NUM }, {OPT_FORCE_MAX_SIMD_BITWIDTH, 1, NULL, OPT_FORCE_MAX_SIMD_BITWIDTH_NUM}, + {OPT_HUGE_WORKER_STACK, 2, NULL, OPT_HUGE_WORKER_STACK_NUM }, {0, 0, NULL, 0 } }; @@ -1618,6 +1619,22 @@ eal_parse_huge_unlink(const char *arg, struct hugepage_file_discipline *out) return -1; } +static int +eal_parse_huge_worker_stack(const char *arg, size_t *huge_worker_stack_size) +{ + size_t worker_stack_size; + if (arg == NULL) { + *huge_worker_stack_size = USE_OS_STACK_SIZE; + return 0; + } + worker_stack_size = atoi(arg); + if (worker_stack_size == 0) + return -1; + + *huge_worker_stack_size = worker_stack_size * 1024; + return 0; +} + int eal_parse_common_option(int opt, const char *optarg, struct internal_config *conf) @@ -1921,6 +1938,15 @@ eal_parse_common_option(int opt, const char *optarg, } break; + case OPT_HUGE_WORKER_STACK_NUM: + if (eal_parse_huge_worker_stack(optarg, + &conf->huge_worker_stack_size) < 0) { + RTE_LOG(ERR, EAL, "invalid parameter for --" + OPT_HUGE_WORKER_STACK"\n"); + return -1; + } + break; + /* don't know what to do, leave this to caller */ default: return 1; diff --git a/lib/eal/common/eal_internal_cfg.h b/lib/eal/common/eal_internal_cfg.h index b71faadd18..8ac91ab3a2 100644 --- a/lib/eal/common/eal_internal_cfg.h +++ b/lib/eal/common/eal_internal_cfg.h @@ -48,6 +48,9 @@ struct hugepage_file_discipline { bool unlink_existing; }; +/** Worker hugepage stack size should default to OS value. */ +#define USE_OS_STACK_SIZE ((size_t)~0) + /** * internal configuration */ @@ -102,6 +105,7 @@ struct internal_config { unsigned int no_telemetry; /**< true to disable Telemetry */ struct simd_bitwidth max_simd_bitwidth; /**< max simd bitwidth path to use */ + size_t huge_worker_stack_size; /**< worker thread stack size in kbytes */ }; void eal_reset_internal_config(struct internal_config *internal_cfg); diff --git a/lib/eal/common/eal_options.h b/lib/eal/common/eal_options.h index 8e4f7202a2..3cc9cb6412 100644 --- a/lib/eal/common/eal_options.h +++ b/lib/eal/common/eal_options.h @@ -87,6 +87,8 @@ enum { OPT_NO_TELEMETRY_NUM, #define OPT_FORCE_MAX_SIMD_BITWIDTH "force-max-simd-bitwidth" OPT_FORCE_MAX_SIMD_BITWIDTH_NUM, +#define OPT_HUGE_WORKER_STACK "huge-worker-stack" + OPT_HUGE_WORKER_STACK_NUM, OPT_LONG_MAX_NUM }; diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 1ef263434a..e8c872ef7b 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -1144,8 +1144,69 @@ rte_eal_init(int argc, char **argv) lcore_config[i].state = WAIT; /* create a thread for each lcore */ - ret = pthread_create(&lcore_config[i].thread_id, NULL, - eal_thread_loop, (void *)(uintptr_t)i); + if (internal_conf->huge_worker_stack_size == 0) { + ret = pthread_create(&lcore_config[i].thread_id, NULL, + eal_thread_loop, + (void *)(uintptr_t)i); + } else { + /* Allocate NUMA aware stack memory and set + * pthread attributes + */ + pthread_attr_t attr; + size_t stack_size; + void *stack_ptr; + + if (pthread_attr_init(&attr) != 0) { + rte_eal_init_alert("Cannot init pthread " + "attributes"); + rte_errno = EFAULT; + return -1; + } + if (internal_conf->huge_worker_stack_size == + USE_OS_STACK_SIZE) { + if (pthread_attr_getstacksize(&attr, + &stack_size) != 0) { + rte_errno = EFAULT; + return -1; + } + } else { + stack_size = + internal_conf->huge_worker_stack_size; + } + stack_ptr = + rte_zmalloc_socket("lcore_stack", + stack_size, + stack_size, + rte_lcore_to_socket_id(i)); + + if (stack_ptr == NULL) { + rte_eal_init_alert("Cannot allocate stack " + "memory for worker lcore"); + rte_errno = ENOMEM; + return -1; + } + + if (pthread_attr_setstack(&attr, + stack_ptr, + stack_size) != 0) { + rte_eal_init_alert("Cannot set pthread " + "stack attributes"); + rte_errno = EFAULT; + return -1; + } + + /* create a thread for each lcore */ + ret = pthread_create(&lcore_config[i].thread_id, &attr, + eal_thread_loop, + (void *)(uintptr_t)i); + + if (pthread_attr_destroy(&attr) != 0) { + rte_eal_init_alert("Cannot destroy pthread " + "attributes"); + rte_errno = EFAULT; + return -1; + } + } if (ret != 0) rte_panic("Cannot create thread\n");