diff mbox series

[v1,18/19] timer: remove unneeded header includes

Message ID	20220421190859.264174-19-sean.morrissey@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Sean Morrissey <sean.morrissey@intel.com> To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com> Cc: dev@dpdk.org, Sean Morrissey <sean.morrissey@intel.com> Subject: [PATCH v1 18/19] timer: remove unneeded header includes Date: Thu, 21 Apr 2022 19:08:58 +0000 Message-Id: <20220421190859.264174-19-sean.morrissey@intel.com> In-Reply-To: <20220421190859.264174-1-sean.morrissey@intel.com> References: <20220421190859.264174-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	remove IWYU flagged headers \| [v1,00/19] remove IWYU flagged headers [v1,01/19] cmdline: remove unneeded header includes [v1,02/19] eal: remove unneeded header includes [v1,03/19] ethdev: remove unneeded header includes [v1,04/19] gpudev: remove unneeded header includes [v1,05/19] gso: remove unneeded header includes [v1,06/19] hash: remove unneeded header includes [v1,07/19] ip_frag: remove unneeded header includes [v1,08/19] jobstats: remove unneeded header includes [v1,09/19] mempool: remove unneeded header includes [v1,10/19] meter: remove unneeded header includes [v1,11/19] net: remove unneeded header includes [v1,12/19] power: remove unneeded header includes [v1,13/19] rawdev: remove unneeded header includes [v1,14/19] regexdev: remove unneeded header includes [v1,15/19] sched: remove unneeded header includes [v1,16/19] stack: remove unneeded header includes [v1,17/19] table: remove unneeded header includes [v1,18/19] timer: remove unneeded header includes [v1,19/19] vhost: remove unneeded header includes

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Sean Morrissey April 21, 2022, 7:08 p.m. UTC

  These header includes have been flagged by the iwyu_tool
and removed.

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
 lib/timer/rte_timer.c | 3 ---
 lib/timer/rte_timer.h | 2 --
 2 files changed, 5 deletions(-)

Comments

Stephen Hemminger April 21, 2022, 8:08 p.m. UTC | #1

On Thu, 21 Apr 2022 19:08:58 +0000
Sean Morrissey <sean.morrissey@intel.com> wrote:

> diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c
> index c51a393e5c..f52ccc33ed 100644
> --- a/lib/timer/rte_timer.c
> +++ b/lib/timer/rte_timer.c
> @@ -5,12 +5,9 @@
>  #include <stdio.h>
>  #include <stdint.h>
>  #include <stdbool.h>
> -#include <inttypes.h>
>  #include <assert.h>
> -#include <sys/queue.h>
>  
>  #include <rte_common.h>
> -#include <rte_cycles.h>
>  #include <rte_eal_memconfig.h>
>  #include <rte_memory.h>
>  #include <rte_lcore.h>

This doesn't look right.

rte_timer.c relies on rte_get_timer_cycles() which is defined in
rte_cycles.h

Perhaps iwyu is getting confused, or thinking that is already covered
by another include file?

Sean Morrissey April 22, 2022, 8:44 a.m. UTC | #2

On 21/04/2022 21:08, Stephen Hemminger wrote:
> On Thu, 21 Apr 2022 19:08:58 +0000
> Sean Morrissey <sean.morrissey@intel.com> wrote:
>
>> diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c
>> index c51a393e5c..f52ccc33ed 100644
>> --- a/lib/timer/rte_timer.c
>> +++ b/lib/timer/rte_timer.c
>> @@ -5,12 +5,9 @@
>>   #include <stdio.h>
>>   #include <stdint.h>
>>   #include <stdbool.h>
>> -#include <inttypes.h>
>>   #include <assert.h>
>> -#include <sys/queue.h>
>>   
>>   #include <rte_common.h>
>> -#include <rte_cycles.h>
>>   #include <rte_eal_memconfig.h>
>>   #include <rte_memory.h>
>>   #include <rte_lcore.h>
> This doesn't look right.
>
> rte_timer.c relies on rte_get_timer_cycles() which is defined in
> rte_cycles.h
>
> Perhaps iwyu is getting confused, or thinking that is already covered
> by another include file?

IWYU can throw false positives.

Please let me fix all build issues with this patchset and get back to 
you. It could re-introduce the header in question. If not I will 
investigate where IWYU believes the include is coming from.

Typically the headers removed by this tool are usually already included 
from a daisy chain of includes from another header.

diff mbox series

Patch

diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c
index c51a393e5c..f52ccc33ed 100644
--- a/lib/timer/rte_timer.c
+++ b/lib/timer/rte_timer.c
@@ -5,12 +5,9 @@ 
 #include <stdio.h>
 #include <stdint.h>
 #include <stdbool.h>
-#include <inttypes.h>
 #include <assert.h>
-#include <sys/queue.h>
 
 #include <rte_common.h>
-#include <rte_cycles.h>
 #include <rte_eal_memconfig.h>
 #include <rte_memory.h>
 #include <rte_lcore.h>
diff --git a/lib/timer/rte_timer.h b/lib/timer/rte_timer.h
index 0f820555c0..503438a36b 100644
--- a/lib/timer/rte_timer.h
+++ b/lib/timer/rte_timer.h
@@ -36,9 +36,7 @@ 
 
 #include <stdio.h>
 #include <stdint.h>
-#include <stddef.h>
 #include <rte_common.h>
-#include <rte_config.h>
 #include <rte_spinlock.h>
 
 #ifdef __cplusplus