[1/5] net/hns3: refactor adapter state dump

Message ID 20220414130056.37428-2-humin29@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series refactor for device info dump |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

humin (Q) April 14, 2022, 1 p.m. UTC
  This patch refactor adapter state dump.

Fixes: 1a03c659cb9d ("net/hns3: dump device basic info")

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_ethdev_dump.c | 41 ++++++++++++++++-------------
 1 file changed, 23 insertions(+), 18 deletions(-)
  

Patch

diff --git a/drivers/net/hns3/hns3_ethdev_dump.c b/drivers/net/hns3/hns3_ethdev_dump.c
index beffdd9e32..8b7a90a67e 100644
--- a/drivers/net/hns3/hns3_ethdev_dump.c
+++ b/drivers/net/hns3/hns3_ethdev_dump.c
@@ -13,26 +13,31 @@ 
 #include "hns3_rxtx.h"
 
 static const char *
-get_adapter_state_name(uint32_t state)
-{
-	static const char * const state_name[] = {
-		"UNINITIALIZED",
-		"INITIALIZED",
-		"CONFIGURING",
-		"CONFIGURED",
-		"STARTING",
-		"STARTED",
-		"STOPPING",
-		"CLOSING",
-		"CLOSED",
-		"REMOVED",
-		"NSTATES"
+get_adapter_state_name(enum hns3_adapter_state state)
+{
+	const struct {
+		enum hns3_adapter_state state;
+		const char *name;
+	} adapter_state_name[] = {
+		{HNS3_NIC_UNINITIALIZED, "UNINITIALIZED"},
+		{HNS3_NIC_INITIALIZED, "INITIALIZED"},
+		{HNS3_NIC_CONFIGURING, "CONFIGURING"},
+		{HNS3_NIC_CONFIGURED, "CONFIGURED"},
+		{HNS3_NIC_STARTING, "STARTING"},
+		{HNS3_NIC_STARTED, "STARTED"},
+		{HNS3_NIC_STOPPING, "STOPPING"},
+		{HNS3_NIC_CLOSING, "CLOSING"},
+		{HNS3_NIC_CLOSED, "CLOSED"},
+		{HNS3_NIC_REMOVED, "REMOVED"},
+		{HNS3_NIC_NSTATES, "NSTATES"},
 	};
+	uint32_t i;
 
-	if (state < RTE_DIM(state_name))
-		return state_name[state];
-	else
-		return "unknown";
+	for (i = 0; i < RTE_DIM(adapter_state_name); i++)
+		if (state == adapter_state_name[i].state)
+			return adapter_state_name[i].name;
+
+	return "Unknown";
 }
 
 static const char *