[v2] ci: remove redundant drivers enabling

Message ID 20220301100455.2150858-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] ci: remove redundant drivers enabling |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Thomas Monjalon March 1, 2022, 10:04 a.m. UTC
  No need to explicitly enable drivers bus/vdev and mempool/ring.

bus/vdev is always enabled since
commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")

mempool/ring is always enabled since
commit 81c2337e044d ("build: make ring mempool driver mandatory")

The driver net/null is kept to allow running test-null.sh.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: precise net/null justification in commit log
---
 .ci/linux-build.sh            | 2 +-
 devtools/test-meson-builds.sh | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

David Marchand March 1, 2022, 10:57 a.m. UTC | #1
On Tue, Mar 1, 2022 at 11:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> No need to explicitly enable drivers bus/vdev and mempool/ring.
>
> bus/vdev is always enabled since
> commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
>
> mempool/ring is always enabled since
> commit 81c2337e044d ("build: make ring mempool driver mandatory")
>
> The driver net/null is kept to allow running test-null.sh.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
  
Thomas Monjalon March 6, 2022, 9:27 a.m. UTC | #2
01/03/2022 11:57, David Marchand:
> On Tue, Mar 1, 2022 at 11:05 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > No need to explicitly enable drivers bus/vdev and mempool/ring.
> >
> > bus/vdev is always enabled since
> > commit 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
> >
> > mempool/ring is always enabled since
> > commit 81c2337e044d ("build: make ring mempool driver mandatory")
> >
> > The driver net/null is kept to allow running test-null.sh.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: David Marchand <david.marchand@redhat.com>

Applied
  

Patch

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 05aa21ec69..69940dec8b 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -89,7 +89,7 @@  OPTS="$OPTS --default-library=$DEF_LIB"
 OPTS="$OPTS --buildtype=debugoptimized"
 OPTS="$OPTS -Dcheck_includes=true"
 if [ "$MINI" = "true" ]; then
-    OPTS="$OPTS -Denable_drivers=bus/vdev,mempool/ring,net/null"
+    OPTS="$OPTS -Denable_drivers=net/null"
     OPTS="$OPTS -Ddisable_libs=*"
 fi
 meson build --werror $OPTS
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index c07fd16fdc..a653b253cb 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -221,7 +221,7 @@  for c in gcc clang ; do
 done
 
 build build-mini cc skipABI $use_shared -Ddisable_libs=* \
-	-Denable_drivers=bus/vdev,mempool/ring,net/null
+	-Denable_drivers=net/null
 
 # test compilation with minimal x86 instruction set
 # Set the install path for libraries to "lib" explicitly to prevent problems