diff mbox series

vhost: use colon in version.map

Message ID 20220215055552.16656-1-penyu@amazon.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series vhost: use colon in version.map |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Peng Yu Feb. 15, 2022, 5:55 a.m. UTC 
  The punctuation after the `global` keyword should be colon, not
semicolon. The default gcc linker accepts both colon and semicolon, but
the gold linker will report syntax error if we use semicolon after the
`global` keyword.

Signed-off-by: Peng Yu <penyu@amazon.com>
---
 lib/vhost/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chenbo Xia March 3, 2022, 11:32 a.m. UTC | #1 
> -----Original Message-----
> From: Peng Yu <penyu@amazon.com>
> Sent: Tuesday, February 15, 2022 1:56 PM
> To: dev@dpdk.org
> Cc: Peng Yu <penyu@amazon.com>; Ray Kinsella <mdr@ashroe.eu>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
> Subject: [PATCH] vhost: use colon in version.map
> 
> The punctuation after the `global` keyword should be colon, not
> semicolon. The default gcc linker accepts both colon and semicolon, but
> the gold linker will report syntax error if we use semicolon after the
> `global` keyword.
> 
> Signed-off-by: Peng Yu <penyu@amazon.com>
> ---
>  lib/vhost/version.map | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vhost/version.map b/lib/vhost/version.map
> index 1202ba9c1a..0a66c5840c 100644
> --- a/lib/vhost/version.map
> +++ b/lib/vhost/version.map
> @@ -90,7 +90,7 @@ EXPERIMENTAL {
>  };
> 
>  INTERNAL {
> -	global;
> +	global:
> 
>  	rte_vdpa_register_device;
>  	rte_vdpa_relay_vring_used;
> --
> 2.16.6

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Ferruh Yigit March 4, 2022, 1:57 p.m. UTC | #2 
On 3/3/2022 11:32 AM, Xia, Chenbo wrote:
>> -----Original Message-----
>> From: Peng Yu <penyu@amazon.com>
>> Sent: Tuesday, February 15, 2022 1:56 PM
>> To: dev@dpdk.org
>> Cc: Peng Yu <penyu@amazon.com>; Ray Kinsella <mdr@ashroe.eu>; Maxime Coquelin
>> <maxime.coquelin@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: [PATCH] vhost: use colon in version.map
>>
>> The punctuation after the `global` keyword should be colon, not
>> semicolon. The default gcc linker accepts both colon and semicolon, but
>> the gold linker will report syntax error if we use semicolon after the
>> `global` keyword.
>>
>> Signed-off-by: Peng Yu <penyu@amazon.com>
> 
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 1202ba9c1a..0a66c5840c 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -90,7 +90,7 @@  EXPERIMENTAL {
 };
 
 INTERNAL {
-	global;
+	global:
 
 	rte_vdpa_register_device;
 	rte_vdpa_relay_vring_used;