diff mbox series

[v3,18/36] net/dpaa*: remove unnecessary NULL checks

Message ID	20220209191748.377729-19-stephen@networkplumber.org (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@oss.nxp.com> Subject: [PATCH v3 18/36] net/dpaa*: remove unnecessary NULL checks Date: Wed, 9 Feb 2022 11:17:30 -0800 Message-Id: <20220209191748.377729-19-stephen@networkplumber.org> In-Reply-To: <20220209191748.377729-1-stephen@networkplumber.org> References: <20220124000518.319850-1-stephen@networkplumber.org> <20220209191748.377729-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	remove unnecessary null checks \| [v3,00/36] remove unnecessary null checks [v3,01/36] lib: update documentation of XXX_free() functions [v3,02/36] devtools/cocci: add script to fix unnecessary null checks [v3,03/36] eal: remove unnecessary NULL checks [v3,04/36] ethdev: remove unnecessary NULL checks [v3,05/36] examples: remove unnecessary NULL checks [v3,06/36] vhost: remove unnecessary NULL checks [v3,07/36] app: remove unnecessary NULL checks [v3,08/36] baseband/: remove unnecessary NULL checks [v3,09/36] bus/: remove unnecessary NULL checks [v3,10/36] common/: remove unnecessary NULL checks [v3,11/36] compress/: remove unnecessary NULL checks [v3,12/36] crypto: remove unnecessary NULL checks [v3,13/36] event/sw: remove unnecessary NULL checks [v3,14/36] net/axgbe: remove unnecessary NULL checks [v3,15/36] net/bnx: remove unnecessary NULL checks [v3,16/36] net/cnxk: remove unnecessary NULL checks [v3,17/36] net/cxgbe: remove unnecessary NULL checks [v3,18/36] net/dpaa: remove unnecessary NULL checks [v3,19/36] net/ena: remove unnecessary NULL checks [v3,20/36] net/hinic: remove unnecessary NULL checks [v3,21/36] net/hns3: remove unnecessary NULL checks [v3,22/36] net/i: remove unnecessary NULL checks [v3,23/36] net/mlx: remove unnecessary NULL checks [v3,24/36] net/mvpp2: remove unnecessary NULL checks [v3,25/36] net/netvsc: remove unnecessary NULL checks [v3,26/36] net/octeontx: remove unnecessary NULL checks [v3,27/36] net/qede: remove unnecessary NULL checks [v3,28/36] net/txgbe: remove unnecessary NULL checks [v3,29/36] net/vdev_netvsc: remove unnecessary NULL checks [v3,30/36] net/virtio: remove unnecessary NULL checks [v3,31/36] net/other: remove unnecessary NULL checks [v3,32/36] raw/: remove unnecessary NULL checks [v3,33/36] regex/: remove unnecessary NULL checks [v3,34/36] vdpa/*: remove unnecessary NULL checks [v3,35/36] compressdev: remove unnecessary NULL checks [v3,36/36] other: remove unnecessary NULL checks

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 9, 2022, 7:17 p.m. UTC

  Remove redundant NULL pointer checks before free functions
found by nullfree.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/net/dpaa/dpaa_ethdev.c   | 3 +--
 drivers/net/dpaa/fmlib/fm_lib.c  | 3 +--
 drivers/net/dpaa2/dpaa2_ethdev.c | 3 +--
 drivers/net/dpaa2/dpaa2_mux.c    | 3 +--
 drivers/net/dpaa2/dpaa2_ptp.c    | 3 +--
 5 files changed, 5 insertions(+), 10 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index b0c78ac0a14e..bddb3bb15ccc 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -474,8 +474,7 @@  static int dpaa_eth_dev_close(struct rte_eth_dev *dev)
 	}
 
 	/* release configuration memory */
-	if (dpaa_intf->fc_conf)
-		rte_free(dpaa_intf->fc_conf);
+	rte_free(dpaa_intf->fc_conf);
 
 	/* Release RX congestion Groups */
 	if (dpaa_intf->cgr_rx) {
diff --git a/drivers/net/dpaa/fmlib/fm_lib.c b/drivers/net/dpaa/fmlib/fm_lib.c
index 0d1ca12378d8..1d6816050c2f 100644
--- a/drivers/net/dpaa/fmlib/fm_lib.c
+++ b/drivers/net/dpaa/fmlib/fm_lib.c
@@ -408,8 +408,7 @@  fm_port_close(t_handle h_fm_port)
 	_fml_dbg("Calling...\n");
 
 	close(p_dev->fd);
-	if (p_dev->h_user_priv)
-		free(p_dev->h_user_priv);
+	free(p_dev->h_user_priv);
 	free(p_dev);
 
 	_fml_dbg("Finishing.\n");
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 09105f049e89..e824ae15b5ed 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -508,8 +508,7 @@  dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev)
 		/* cleaning up queue storage */
 		for (i = 0; i < priv->nb_rx_queues; i++) {
 			dpaa2_q = (struct dpaa2_queue *)priv->rx_vq[i];
-			if (dpaa2_q->q_storage)
-				rte_free(dpaa2_q->q_storage);
+			rte_free(dpaa2_q->q_storage);
 		}
 		/* cleanup tx queue cscn */
 		for (i = 0; i < priv->nb_tx_queues; i++) {
diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
index cd2f7b8aa544..bd4596b89149 100644
--- a/drivers/net/dpaa2/dpaa2_mux.c
+++ b/drivers/net/dpaa2/dpaa2_mux.c
@@ -353,8 +353,7 @@  dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
 	return 0;
 
 init_err:
-	if (dpdmux_dev)
-		rte_free(dpdmux_dev);
+	rte_free(dpdmux_dev);
 
 	return -1;
 }
diff --git a/drivers/net/dpaa2/dpaa2_ptp.c b/drivers/net/dpaa2/dpaa2_ptp.c
index 3a4536dd69c1..4e6d375d1cbb 100644
--- a/drivers/net/dpaa2/dpaa2_ptp.c
+++ b/drivers/net/dpaa2/dpaa2_ptp.c
@@ -170,8 +170,7 @@  dpaa2_create_dprtc_device(int vdev_fd __rte_unused,
 	return 0;
 
 init_err:
-	if (dprtc_dev)
-		rte_free(dprtc_dev);
+	rte_free(dprtc_dev);
 
 	return -1;
 }