diff mbox series

[v3] raw/ntb: clear all valid DB bits when DB init

Message ID 20220209044716.3709178-1-junfeng.guo@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v3] raw/ntb: clear all valid DB bits when DB init |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Junfeng Guo Feb. 9, 2022, 4:47 a.m. UTC 
  Before registering the doorbell interrupt handler callback function,
all the valid doorbell bits within the NTB private data struct should
be cleared to avoid the confusion of the handshake timing sequence
diagram when setting up the NTB connection in back-to-back mode.

Fixes: 62012a76811e ("raw/ntb: add handshake process")
Cc: stable@dpdk.org

Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
---
 drivers/raw/ntb/ntb.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jingjing Wu Feb. 10, 2022, 6:50 a.m. UTC | #1 
> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo@intel.com>
> Sent: Wednesday, February 9, 2022 12:47 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng <junfeng.guo@intel.com>
> Subject: [PATCH v3] raw/ntb: clear all valid DB bits when DB init
> 
> Before registering the doorbell interrupt handler callback function,
> all the valid doorbell bits within the NTB private data struct should
> be cleared to avoid the confusion of the handshake timing sequence
> diagram when setting up the NTB connection in back-to-back mode.
> 
> Fixes: 62012a76811e ("raw/ntb: add handshake process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>  drivers/raw/ntb/ntb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
Better to add changes compared to previous version, which would help reviewers.

> diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
> index 46ac02e5ab..cc611dfbb9 100644
> --- a/drivers/raw/ntb/ntb.c
> +++ b/drivers/raw/ntb/ntb.c
> @@ -1398,6 +1398,8 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device
> *pci_dev)
> 
>  	/* Init doorbell. */
>  	hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t);
> +	/* Clear all valid doorbell bits before registering intr handler */
> +	(*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask);

Check if hw->ntb_ops->db_clear is NULL before call it.

> 
>  	intr_handle = pci_dev->intr_handle;
>  	/* Register callback func to eal lib */
> --
> 2.25.1
Junfeng Guo Feb. 10, 2022, 7:08 a.m. UTC | #2 
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Thursday, February 10, 2022 14:51
> To: Guo, Junfeng <junfeng.guo@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v3] raw/ntb: clear all valid DB bits when DB init
> 
> 
> 
> > -----Original Message-----
> > From: Guo, Junfeng <junfeng.guo@intel.com>
> > Sent: Wednesday, February 9, 2022 12:47 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Guo, Junfeng
> <junfeng.guo@intel.com>
> > Subject: [PATCH v3] raw/ntb: clear all valid DB bits when DB init
> >
> > Before registering the doorbell interrupt handler callback function,
> > all the valid doorbell bits within the NTB private data struct should
> > be cleared to avoid the confusion of the handshake timing sequence
> > diagram when setting up the NTB connection in back-to-back mode.
> >
> > Fixes: 62012a76811e ("raw/ntb: add handshake process")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> > ---
> >  drivers/raw/ntb/ntb.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> Better to add changes compared to previous version, which would help
> reviewers.

Sure, I'll add the version change commit in the coming version. Thanks!

> 
> > diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
> > index 46ac02e5ab..cc611dfbb9 100644
> > --- a/drivers/raw/ntb/ntb.c
> > +++ b/drivers/raw/ntb/ntb.c
> > @@ -1398,6 +1398,8 @@ ntb_init_hw(struct rte_rawdev *dev, struct
> rte_pci_device
> > *pci_dev)
> >
> >  	/* Init doorbell. */
> >  	hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t);
> > +	/* Clear all valid doorbell bits before registering intr handler */
> > +	(*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask);
> 
> Check if hw->ntb_ops->db_clear is NULL before call it.

OK, will add it in the coming version. Thanks for review! 

> 
> >
> >  	intr_handle = pci_dev->intr_handle;
> >  	/* Register callback func to eal lib */
> > --
> > 2.25.1
diff mbox series

Patch

diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
index 46ac02e5ab..cc611dfbb9 100644
--- a/drivers/raw/ntb/ntb.c
+++ b/drivers/raw/ntb/ntb.c
@@ -1398,6 +1398,8 @@  ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev)
 
 	/* Init doorbell. */
 	hw->db_valid_mask = RTE_LEN2MASK(hw->db_cnt, uint64_t);
+	/* Clear all valid doorbell bits before registering intr handler */
+	(*hw->ntb_ops->db_clear)(dev, hw->db_valid_mask);
 
 	intr_handle = pci_dev->intr_handle;
 	/* Register callback func to eal lib */