ci: remove outdated default reference tag for ABI
Checks
Commit Message
The variable REF_GIT_TAG is set in the CI configuration
like .travis.yml or .github/workflows/build.yml.
The default value is outdated and probably unused.
It is removed completely to avoid forgetting an update in future.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
.ci/linux-build.sh | 1 -
1 file changed, 1 deletion(-)
Comments
Thomas Monjalon <thomas@monjalon.net> writes:
> The variable REF_GIT_TAG is set in the CI configuration
> like .travis.yml or .github/workflows/build.yml.
> The default value is outdated and probably unused.
> It is removed completely to avoid forgetting an update in future.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
I think the default was there for labs that run the build script
manually. Maybe there are no such users, though. I believe the lab has
its own script for doing such ABI checks (but can't remember off the top
of my head).
CC'd Lincoln and Owen just to confirm.
Assuming the UNH/other lab doesn't use this feature of the linux build
script,
Acked-by: Aaron Conole <aconole@redhat.com>
On Tue, Feb 8, 2022 at 10:09 AM Aaron Conole <aconole@redhat.com> wrote:
> I think the default was there for labs that run the build script
> manually. Maybe there are no such users, though. I believe the lab has
> its own script for doing such ABI checks (but can't remember off the top
> of my head).
Just confirming: the UNH lab does use our own separate script (which
calls the devtools check-abi.sh and gen-abi.sh scripts).
08/02/2022 16:08, Aaron Conole:
> Thomas Monjalon <thomas@monjalon.net> writes:
>
> > The variable REF_GIT_TAG is set in the CI configuration
> > like .travis.yml or .github/workflows/build.yml.
> > The default value is outdated and probably unused.
> > It is removed completely to avoid forgetting an update in future.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> I think the default was there for labs that run the build script
> manually. Maybe there are no such users, though. I believe the lab has
> its own script for doing such ABI checks (but can't remember off the top
> of my head).
>
> CC'd Lincoln and Owen just to confirm.
>
> Assuming the UNH/other lab doesn't use this feature of the linux build
> script,
>
> Acked-by: Aaron Conole <aconole@redhat.com>
I could also remove this variable:
LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
It is confusing to see an old version here,
while we use the version 1.8.
If no objection, I'll send a v2.
On Wed, Feb 9, 2022 at 2:38 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 08/02/2022 16:08, Aaron Conole:
> > Thomas Monjalon <thomas@monjalon.net> writes:
> >
> > > The variable REF_GIT_TAG is set in the CI configuration
> > > like .travis.yml or .github/workflows/build.yml.
> > > The default value is outdated and probably unused.
> > > It is removed completely to avoid forgetting an update in future.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> >
> > I think the default was there for labs that run the build script
> > manually. Maybe there are no such users, though. I believe the lab has
> > its own script for doing such ABI checks (but can't remember off the top
> > of my head).
> >
> > CC'd Lincoln and Owen just to confirm.
> >
> > Assuming the UNH/other lab doesn't use this feature of the linux build
> > script,
> >
> > Acked-by: Aaron Conole <aconole@redhat.com>
>
> I could also remove this variable:
> LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
>
> It is confusing to see an old version here,
> while we use the version 1.8.
>
> If no objection, I'll send a v2.
+1.
@@ -119,7 +119,6 @@ if [ "$ABI_CHECKS" = "true" ]; then
export PATH=$(pwd)/libabigail/bin:$PATH
REF_GIT_REPO=${REF_GIT_REPO:-https://dpdk.org/git/dpdk}
- REF_GIT_TAG=${REF_GIT_TAG:-v19.11}
if [ "$(cat reference/VERSION 2>/dev/null)" != "$REF_GIT_TAG" ]; then
rm -rf reference