[v1] gpudev: remove unnecessary rte_gpu_wmb
Checks
Commit Message
From: Elena Agostini <eagostini@nvidia.com>
Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts.
It causes a performance degradation in case of NVIDIA GPU V100.
This change doesn't affect any functionality as the status resides
in CPU registered memory.
Fixes: c7ebd65c1372 ("gpudev: add communication list")
Signed-off-by: Elena Agostini <eagostini@nvidia.com>
---
lib/gpudev/gpudev.c | 1 -
1 file changed, 1 deletion(-)
Comments
25/11/2021 23:40, eagostini@nvidia.com:
> From: Elena Agostini <eagostini@nvidia.com>
>
> Remove unnecessary rte_gpu_wmb from rte_gpu_comm_populate_list_pkts.
> It causes a performance degradation in case of NVIDIA GPU V100.
>
> This change doesn't affect any functionality as the status resides
> in CPU registered memory.
>
> Fixes: c7ebd65c1372 ("gpudev: add communication list")
>
> Signed-off-by: Elena Agostini <eagostini@nvidia.com>
Applied, thanks.
@@ -877,7 +877,6 @@ rte_gpu_comm_populate_list_pkts(struct rte_gpu_comm_list *comm_list_item,
RTE_GPU_VOLATILE(comm_list_item->num_pkts) = num_mbufs;
rte_gpu_wmb(comm_list_item->dev_id);
RTE_GPU_VOLATILE(comm_list_item->status) = RTE_GPU_COMM_LIST_READY;
- rte_gpu_wmb(comm_list_item->dev_id);
return 0;
}