diff mbox series

examples/power: revert "add wakeup log"

Message ID 20211123155749.12555-1-david.hunt@intel.com (mailing list archive)
State Accepted, archived
Headers
Series examples/power: revert "add wakeup log" |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Hunt, David Nov. 23, 2021, 3:57 p.m. UTC 
  This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.

Wakeup happens quite often (several hundred times a second) in
l3fwd-power example app in PMD power management mode, so this
message is appearing too often to be useful. This patch reverts
that info message addition.

Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 examples/l3fwd-power/main.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Pattan, Reshma Nov. 24, 2021, 12:17 p.m. UTC | #1 
> -----Original Message-----
> From: David Hunt <david.hunt@intel.com>
> This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.
> 
> Wakeup happens quite often (several hundred times a second) in l3fwd-power
> example app in PMD power management mode, so this message is appearing
> too often to be useful. This patch reverts that info message addition.
> 
> Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
Tested-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Thomas Monjalon Nov. 24, 2021, 1:02 p.m. UTC | #2 
24/11/2021 13:17, Pattan, Reshma:
> > From: David Hunt <david.hunt@intel.com>
> > This reverts commit 931e3a994597acb9ffa827376206e8aa324476b7.
> > 
> > Wakeup happens quite often (several hundred times a second) in l3fwd-power
> > example app in PMD power management mode, so this message is appearing
> > too often to be useful.

It was my initial thought but I merged it anyway because you acked.

> > This patch reverts that info message addition.
> > 
> > Fixes: 931e3a994597 ("examples/l3fwd-power: add wakeup log")
> > 
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> Tested-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied
diff mbox series

Patch

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index 5c5825166d..b8b3be2b8a 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -1156,9 +1156,6 @@  main_telemetry_loop(__rte_unused void *dummy)
 			ep_nep[nb_rx == 0]++;
 			fp_nfp[nb_rx == MAX_PKT_BURST]++;
 			poll_count++;
-			RTE_LOG(INFO, L3FWD_POWER,
-				"lcore %u has woken up on port %d queue %d\n",
-				rte_lcore_id(), portid, queueid);
 			if (unlikely(nb_rx == 0))
 				continue;