[v2] app/flow-perf: add missing default option
Checks
Commit Message
Currently, if an invalid parameter is passed to the application
it will cause a crash due to missing default in options.
For example:
./dpdk-test-flow-perf -a 01:00.0 -- --invalid
This adds missing default for options, and prints the
invalid option.
Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton")
Cc: wisamm@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
---
app/test-flow-perf/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: Raslan Darawsheh <rasland@nvidia.com>
> Sent: Tuesday, November 16, 2021 4:12 PM
> To: dev@dpdk.org
> Cc: Wisam Monther <wisamm@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v2] app/flow-perf: add missing default option
>
> Currently, if an invalid parameter is passed to the application it will cause a
> crash due to missing default in options.
>
> For example:
> ./dpdk-test-flow-perf -a 01:00.0 -- --invalid
>
> This adds missing default for options, and prints the invalid option.
>
> Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton")
> Cc: wisamm@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
Acked-by: Wisam Jaddo <wisamm@nvidia.com>
BRs,
Wisam Jaddo
> > Currently, if an invalid parameter is passed to the application it will cause a
> > crash due to missing default in options.
> >
> > For example:
> > ./dpdk-test-flow-perf -a 01:00.0 -- --invalid
> >
> > This adds missing default for options, and prints the invalid option.
> >
> > Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton")
> > Cc: wisamm@nvidia.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
> Acked-by: Wisam Jaddo <wisamm@nvidia.com>
Applied with title "fix parsing of invalid option", thanks.
@@ -715,6 +715,7 @@ args_parse(int argc, char **argv)
{ "policy-mtr", 1, 0, 0 },
{ "meter-profile", 1, 0, 0 },
{ "packet-mode", 0, 0, 0 },
+ { 0, 0, 0, 0 },
};
RTE_ETH_FOREACH_DEV(i)
@@ -951,7 +952,7 @@ args_parse(int argc, char **argv)
default:
usage(argv[0]);
rte_exit(EXIT_FAILURE, "Invalid option: %s\n",
- argv[optind]);
+ argv[optind - 1]);
break;
}
}