diff mbox series

[v2] net/ice: fix pointer of the meta data

Message ID 20211112053418.14292-1-alvinx.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/ice: fix pointer of the meta data |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Alvin Zhang Nov. 12, 2021, 5:34 a.m. UTC 
  This patch fixes coverity issue by directly passing the address
of the meta data to subfunction.

Coverity issue: 373867

Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/ice/ice_hash.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Qi Zhang Nov. 12, 2021, 5:44 a.m. UTC | #1 
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Friday, November 12, 2021 1:34 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix pointer of the meta data
> 
> This patch fixes coverity issue by directly passing the address of the meta data
> to subfunction.
> 
> Coverity issue: 373867
> 
> Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 4b682a4..afbb357 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1055,10 +1055,9 @@  struct rss_attr_type {
 static int
 ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
 		const struct rte_flow_action actions[],
-		uint64_t pattern_hint, void **meta,
+		uint64_t pattern_hint, struct ice_rss_meta *rss_meta,
 		struct rte_flow_error *error)
 {
-	struct ice_rss_meta *rss_meta = (struct ice_rss_meta *)*meta;
 	struct ice_rss_hash_cfg *cfg = pattern_match_item->meta;
 	enum rte_flow_action_type action_type;
 	const struct rte_flow_action_rss *rss;
@@ -1196,7 +1195,7 @@  struct rss_attr_type {
 
 	/* Check rss action. */
 	ret = ice_hash_parse_action(pattern_match_item, actions, phint,
-				    (void **)&rss_meta_ptr, error);
+				    rss_meta_ptr, error);
 
 error:
 	if (!ret && meta)