diff mbox series

usertools/devbind: remove octeontx2 DMA device

Message ID 20211107225708.3087968-1-thomas@monjalon.net (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series usertools/devbind: remove octeontx2 DMA device |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing warning Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thomas Monjalon Nov. 7, 2021, 10:57 p.m. UTC 
  The DMA raw driver for octeontx2 was removed in DPDK 21.11.
The binding ability is also removed in the same release
to be consistent.

Fixes: a59745ebccf0 ("raw/octeontx2_dma: remove driver")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

---

Is there a reason to keep it?
---
 usertools/dpdk-devbind.py | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Radha Mohan Nov. 9, 2021, 3:57 a.m. UTC | #1 
On Sun, Nov 7, 2021 at 5:57 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The DMA raw driver for octeontx2 was removed in DPDK 21.11.
> The binding ability is also removed in the same release
> to be consistent.
>
> Fixes: a59745ebccf0 ("raw/octeontx2_dma: remove driver")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> ---
>
> Is there a reason to keep it?

Need to modify.

> ---
>  usertools/dpdk-devbind.py | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index af9a0ad5ab..95921b2281 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -41,8 +41,6 @@
>                   'SVendor': None, 'SDevice': None}
>  octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
>                   'SVendor': None, 'SDevice': None}
> -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> -                 'SVendor': None, 'SDevice': None}
>  octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
>                   'SVendor': None, 'SDevice': None}
>  cnxk_bphy = {'Class': '08', 'Vendor': '177d', 'Device': 'a089',
> @@ -80,8 +78,8 @@
>  mempool_devices = [cavium_fpa, octeontx2_npa]
>  compress_devices = [cavium_zip]
>  regex_devices = [octeontx2_ree]
> -misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
> -                intel_ntb_icx, octeontx2_dma]
> +misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
> +                intel_ntb_icx, intel_ntb_skx]
>
>  # global dict ethernet devices present. Dictionary indexed by PCI address.
>  # Each device within this is itself a dictionary of device properties
> --
> 2.33.0
>

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb00f43702..643860b3ae 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -41,7 +41,7 @@
                  'SVendor': None, 'SDevice': None}
 octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
                  'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
+cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
                  'SVendor': None, 'SDevice': None}
 octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
                  'SVendor': None, 'SDevice': None}
@@ -71,13 +71,14 @@
 network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
 baseband_devices = [acceleration_class]
 crypto_devices = [encryption_class, intel_processor_class]
-dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
+dma_devices = [intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx
+               cnxk_dma]
 eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
 mempool_devices = [cavium_fpa, octeontx2_npa]
 compress_devices = [cavium_zip]
 regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
-                intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+                intel_ntb_skx, intel_ntb_icx]
Thomas Monjalon Nov. 9, 2021, 8:10 a.m. UTC | #2 
09/11/2021 04:57, Radha Mohan:
> On Sun, Nov 7, 2021 at 5:57 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > The DMA raw driver for octeontx2 was removed in DPDK 21.11.
> > The binding ability is also removed in the same release
> > to be consistent.
> >
> > Fixes: a59745ebccf0 ("raw/octeontx2_dma: remove driver")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > ---
> >
> > Is there a reason to keep it?
> 
> Need to modify.

Please send your patch and I will drop this one.
diff mbox series

Patch

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index af9a0ad5ab..95921b2281 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -41,8 +41,6 @@ 
                  'SVendor': None, 'SDevice': None}
 octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
                  'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
-                 'SVendor': None, 'SDevice': None}
 octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
                  'SVendor': None, 'SDevice': None}
 cnxk_bphy = {'Class': '08', 'Vendor': '177d', 'Device': 'a089',
@@ -80,8 +78,8 @@ 
 mempool_devices = [cavium_fpa, octeontx2_npa]
 compress_devices = [cavium_zip]
 regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
-                intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+                intel_ntb_icx, intel_ntb_skx]
 
 # global dict ethernet devices present. Dictionary indexed by PCI address.
 # Each device within this is itself a dictionary of device properties