diff mbox series

ip_frag: increase default value for config parameter

Message ID 20211102190309.5795-1-konstantin.ananyev@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ip_frag: increase default value for config parameter |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues

Commit Message

Ananyev, Konstantin Nov. 2, 2021, 7:03 p.m. UTC 
  Increase default value for config parameter RTE_LIBRTE_IP_FRAG_MAX_FRAG
from 4 to 8. This parameter controls maximum number of fragments per
packet in ip reassembly table. Increasing this value from 4 to 8 will
allow users to cover common case with jumbo packet size of 9KB and
fragments with default frame size (1500B).
As RTE_LIBRTE_IP_FRAG_MAX_FRAG is used in definition of public
structure (struct rte_ip_frag_death_row), this is an ABI change.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
 config/rte_config.h                    | 2 +-
 doc/guides/rel_notes/release_21_11.rst | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon Nov. 8, 2021, 10:08 p.m. UTC | #1 
02/11/2021 20:03, Konstantin Ananyev:
> Increase default value for config parameter RTE_LIBRTE_IP_FRAG_MAX_FRAG
> from 4 to 8. This parameter controls maximum number of fragments per
> packet in ip reassembly table. Increasing this value from 4 to 8 will
> allow users to cover common case with jumbo packet size of 9KB and
> fragments with default frame size (1500B).
> As RTE_LIBRTE_IP_FRAG_MAX_FRAG is used in definition of public
> structure (struct rte_ip_frag_death_row), this is an ABI change.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
> +#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8

This unannounced change was approved by the techboard:
http://inbox.dpdk.org/dev/0fccb0b7-b2bb-7391-9c94-e87fbf64f007@redhat.com/

Applied with simplified release notes, thanks.
diff mbox series

Patch

diff --git a/config/rte_config.h b/config/rte_config.h
index 1a66b42fcc..08e70af497 100644
--- a/config/rte_config.h
+++ b/config/rte_config.h
@@ -82,7 +82,7 @@ 
 #define RTE_RAWDEV_MAX_DEVS 64
 
 /* ip_fragmentation defines */
-#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
+#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
 #undef RTE_LIBRTE_IP_FRAG_TBL_STAT
 
 /* rte_power defines */
diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
index 502cc5ceb2..4d0f112b00 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -543,6 +543,14 @@  ABI Changes
 
 * eventdev: Re-arranged fields in ``rte_event_timer`` to remove holes.
 
+* Increase default value for config parameter ``RTE_LIBRTE_IP_FRAG_MAX_FRAG``
+  from ``4`` to ``8``. This parameter controls maximum number of fragments
+  per packet in ip reassembly table. Increasing this value from ``4`` to ``8``
+  will allow users to cover common case with jumbo packet size of ``9KB``
+  and fragments with default frame size ``(1500B)``.
+  As ``RTE_LIBRTE_IP_FRAG_MAX_FRAG`` is used in definition of
+  public structure ``rte_ip_frag_death_row``, this is an ABI change.
+
 
 Known Issues
 ------------