From patchwork Tue Nov 2 18:41:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 103536 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D53DEA0C4B; Tue, 2 Nov 2021 19:42:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A8354111D; Tue, 2 Nov 2021 19:42:29 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E9EBA41100 for ; Tue, 2 Nov 2021 19:42:26 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1A2HGlhC030466 for ; Tue, 2 Nov 2021 11:42:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=/dUd+oCemynbywMDsipoNIk+bpV4HSeo9zMr/5LBauE=; b=OTSDOYq5SPxfWqMOGuHiG8pVjvlH7mGzx/9+oFPEciDWTOtX84UbE7KL3NgYH6aVM86s lhE9on0g/JKebRlTjqRlm2Dr2kdYO/6zxHq5YdHq3NSkPinFj31aMqh+a750z4wFylZj PZbAu0Qg21eikh0NMeqIkTRsC85m7K9Dx0t3PqG29SyJsImXAoieTgPMg0mjMeEQOJYM WHFp1xqqf9RdpJESplu3VlEBerPUOg9PuANpYWtCuaI7xqVpUw9TcHf65AOS3bLNL6Y3 H0+lpDSDdNE/B4fgo0RMSw16jWPiNiOg4hMPcMRkm08AlX44HzLpgmD4JNn44rxcOd00 xg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3c35mbhyt6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 02 Nov 2021 11:42:26 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 2 Nov 2021 11:42:24 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 2 Nov 2021 11:42:24 -0700 Received: from localhost.localdomain (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id 1BFFE5B6932; Tue, 2 Nov 2021 11:42:22 -0700 (PDT) From: Tomasz Duszynski To: CC: , Tomasz Duszynski , "Jakub Palider" Date: Tue, 2 Nov 2021 19:41:32 +0100 Message-ID: <20211102184134.3012344-3-tduszynski@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211102184134.3012344-1-tduszynski@marvell.com> References: <20211102184134.3012344-1-tduszynski@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: or--cU8aVJ0u23ItPjaqNmghuXsuuzEW X-Proofpoint-ORIG-GUID: or--cU8aVJ0u23ItPjaqNmghuXsuuzEW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-02_08,2021-11-02_01,2020-04-07_01 Subject: [dpdk-dev] [PATCH 2/4] raw/cnxk_bphy: keep leading zero in device name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Device naming might be misleading which is especially true if one takes it from lspci output. In order to keep naming consistent keep leading zero in front of pci bus number. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran Reviewed-by: Jakub Palider --- doc/guides/rawdevs/cnxk_bphy.rst | 6 ++++-- drivers/raw/cnxk_bphy/cnxk_bphy.c | 2 +- drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst index bf7c00e6bc..3cb2175688 100644 --- a/doc/guides/rawdevs/cnxk_bphy.rst +++ b/doc/guides/rawdevs/cnxk_bphy.rst @@ -146,8 +146,10 @@ the raw devices. The rawdev ID of the device can be obtained using invocation of ``rte_rawdev_get_dev_id("NAME:x")`` from the test application, where: - NAME is the desired subsystem: use "BPHY" for regular, and "BPHY_CGX" for - RFOE module, -- x is the device's bus id specified in "bus:device.func" (BDF) format. + RFOE module. +- x is the device's bus id specified in "bus:device.func" (BDF) format. BDF follows convention + used by lspci i.e bus, device and func are specified using respectively two, two and one hex + digit(s). Use this identifier for further rawdev function calls. diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c index 558ebfa85e..349d551839 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c @@ -158,7 +158,7 @@ bphy_rawdev_selftest(uint16_t dev_id) static void bphy_rawdev_get_name(char *name, struct rte_pci_device *pci_dev) { - snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "BPHY:%x:%02x.%x", + snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "BPHY:%02x:%02x.%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); } diff --git a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c index ade45ab741..0b694e1c03 100644 --- a/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c +++ b/drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c @@ -28,7 +28,7 @@ static void cnxk_bphy_cgx_format_name(char *name, unsigned int len, struct rte_pci_device *pci_dev) { - snprintf(name, len, "BPHY_CGX:%x:%02x.%x", pci_dev->addr.bus, + snprintf(name, len, "BPHY_CGX:%02x:%02x.%x", pci_dev->addr.bus, pci_dev->addr.devid, pci_dev->addr.function); }