diff mbox series

ethdev: promote device removal check function as stable

Message ID 20211028083513.3024352-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: promote device removal check function as stable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Thomas Monjalon Oct. 28, 2021, 8:35 a.m. UTC 
  The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
and is integrated in error checks of ethdev library.

It is promoted as stable ABI.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/ethdev/rte_ethdev.h | 4 ----
 lib/ethdev/version.map  | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Ray Kinsella Oct. 28, 2021, 8:38 a.m. UTC | #1 
On 28/10/2021 09:35, Thomas Monjalon wrote:
> The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
> and is integrated in error checks of ethdev library.
> 
> It is promoted as stable ABI.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   lib/ethdev/rte_ethdev.h | 4 ----
>   lib/ethdev/version.map  | 2 +-
>   2 files changed, 1 insertion(+), 5 deletions(-)
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Andrew Rybchenko Oct. 28, 2021, 8:56 a.m. UTC | #2 
On 10/28/21 11:38 AM, Kinsella, Ray wrote:
> 
> 
> On 28/10/2021 09:35, Thomas Monjalon wrote:
>> The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
>> and is integrated in error checks of ethdev library.
>>
>> It is promoted as stable ABI.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>>   lib/ethdev/rte_ethdev.h | 4 ----
>>   lib/ethdev/version.map  | 2 +-
>>   2 files changed, 1 insertion(+), 5 deletions(-)
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Ferruh Yigit Nov. 4, 2021, 10:45 a.m. UTC | #3 
On 10/28/2021 9:56 AM, Andrew Rybchenko wrote:
> On 10/28/21 11:38 AM, Kinsella, Ray wrote:
>>
>>
>> On 28/10/2021 09:35, Thomas Monjalon wrote:
>>> The function rte_eth_dev_is_removed() was introduced in DPDK 18.02,
>>> and is integrated in error checks of ethdev library.
>>>
>>> It is promoted as stable ABI.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>> ---
>>>   lib/ethdev/rte_ethdev.h | 4 ----
>>>   lib/ethdev/version.map  | 2 +-
>>>   2 files changed, 1 insertion(+), 5 deletions(-)
>>>
>> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index 24f30b4b28..09d60351a3 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -2385,9 +2385,6 @@  int rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_queue,
 		uint16_t nb_tx_queue, const struct rte_eth_conf *eth_conf);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Check if an Ethernet device was physically removed.
  *
  * @param port_id
@@ -2395,7 +2392,6 @@  int rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_queue,
  * @return
  *   1 when the Ethernet device is removed, otherwise 0.
  */
-__rte_experimental
 int
 rte_eth_dev_is_removed(uint16_t port_id);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index e1abe99729..c2fb0669a4 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -31,6 +31,7 @@  DPDK_22 {
 	rte_eth_dev_get_supported_ptypes;
 	rte_eth_dev_get_vlan_offload;
 	rte_eth_dev_info_get;
+	rte_eth_dev_is_removed;
 	rte_eth_dev_is_valid_port;
 	rte_eth_dev_logtype;
 	rte_eth_dev_mac_addr_add;
@@ -148,7 +149,6 @@  EXPERIMENTAL {
 	rte_mtr_stats_update;
 
 	# added in 18.02
-	rte_eth_dev_is_removed;
 	rte_eth_dev_owner_delete;
 	rte_eth_dev_owner_get;
 	rte_eth_dev_owner_new;