diff mbox series

[v2,02/15] vhost: hide inflight async structure

Message ID	20211026162904.482987-3-maxime.coquelin@redhat.com (mailing list archive)
State	Accepted, archived
Delegated to:	Maxime Coquelin
Headers	From: Maxime Coquelin <maxime.coquelin@redhat.com> To: dev@dpdk.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, wenwux.ma@intel.com, bruce.richardson@intel.com, john.mcnamara@intel.com Cc: Maxime Coquelin <maxime.coquelin@redhat.com> Date: Tue, 26 Oct 2021 18:28:51 +0200 Message-Id: <20211026162904.482987-3-maxime.coquelin@redhat.com> In-Reply-To: <20211026162904.482987-1-maxime.coquelin@redhat.com> References: <20211026162904.482987-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2 02/15] vhost: hide inflight async structure Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	vhost: clean-up and simplify async implementation \| [v2,00/15] vhost: clean-up and simplify async implementation [v2,01/15] vhost: move async data in a dedicated structure [v2,02/15] vhost: hide inflight async structure [v2,03/15] vhost: simplify async IO vectors [v2,04/15] vhost: simplify async IO vectors iterators [v2,05/15] vhost: remove async batch threshold [v2,06/15] vhost: introduce specific iovec structure [v2,07/15] vhost: remove useless fields in async iterator struct [v2,08/15] vhost: improve IO vector logic [v2,09/15] vhost: remove notion of async descriptor [v2,10/15] vhost: simplify async enqueue completion [v2,11/15] vhost: simplify getting the first in-flight index [v2,12/15] vhost: prepare async for mbuf to desc refactoring [v2,13/15] vhost: prepare sync for mbuf to desc refactoring [v2,14/15] vhost: merge sync and async mbuf to desc filling [v2,15/15] vhost: increase number of async IO vectors

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Maxime Coquelin Oct. 26, 2021, 4:28 p.m. UTC

  This patch moves async_inflight_info struct to internal
header since it should not be part of the API.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 lib/vhost/rte_vhost_async.h | 9 ---------
 lib/vhost/vhost.h           | 9 +++++++++
 2 files changed, 9 insertions(+), 9 deletions(-)

Comments

Chenbo Xia Oct. 28, 2021, 12:07 p.m. UTC | #1

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, October 27, 2021 12:29 AM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Hu, Jiayu
> <jiayu.hu@intel.com>; Wang, YuanX <yuanx.wang@intel.com>; Ma, WenwuX
> <wenwux.ma@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH v2 02/15] vhost: hide inflight async structure
> 
> This patch moves async_inflight_info struct to internal
> header since it should not be part of the API.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/vhost/rte_vhost_async.h | 9 ---------
>  lib/vhost/vhost.h           | 9 +++++++++
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
> index ad71555a7f..789b80f5a0 100644
> --- a/lib/vhost/rte_vhost_async.h
> +++ b/lib/vhost/rte_vhost_async.h
> @@ -83,15 +83,6 @@ struct rte_vhost_async_channel_ops {
>  		uint16_t max_packets);
>  };
> 
> -/**
> - * inflight async packet information
> - */
> -struct async_inflight_info {
> -	struct rte_mbuf *mbuf;
> -	uint16_t descs; /* num of descs inflight */
> -	uint16_t nr_buffers; /* num of buffers inflight for packed ring */
> -};
> -
>  /**
>   *  async channel features
>   */
> diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
> index a556d61063..8c1c33c852 100644
> --- a/lib/vhost/vhost.h
> +++ b/lib/vhost/vhost.h
> @@ -119,6 +119,15 @@ struct vring_used_elem_packed {
>  	uint32_t count;
>  };
> 
> +/**
> + * inflight async packet information
> + */
> +struct async_inflight_info {
> +	struct rte_mbuf *mbuf;
> +	uint16_t descs; /* num of descs inflight */
> +	uint16_t nr_buffers; /* num of buffers inflight for packed ring */
> +};
> +
>  struct vhost_async {
>  	/* operation callbacks for DMA */
>  	struct rte_vhost_async_channel_ops ops;
> --
> 2.31.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

diff mbox series

Patch

diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
index ad71555a7f..789b80f5a0 100644
--- a/lib/vhost/rte_vhost_async.h
+++ b/lib/vhost/rte_vhost_async.h
@@ -83,15 +83,6 @@  struct rte_vhost_async_channel_ops {
 		uint16_t max_packets);
 };
 
-/**
- * inflight async packet information
- */
-struct async_inflight_info {
-	struct rte_mbuf *mbuf;
-	uint16_t descs; /* num of descs inflight */
-	uint16_t nr_buffers; /* num of buffers inflight for packed ring */
-};
-
 /**
  *  async channel features
  */
diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index a556d61063..8c1c33c852 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -119,6 +119,15 @@  struct vring_used_elem_packed {
 	uint32_t count;
 };
 
+/**
+ * inflight async packet information
+ */
+struct async_inflight_info {
+	struct rte_mbuf *mbuf;
+	uint16_t descs; /* num of descs inflight */
+	uint16_t nr_buffers; /* num of buffers inflight for packed ring */
+};
+
 struct vhost_async {
 	/* operation callbacks for DMA */
 	struct rte_vhost_async_channel_ops ops;