From patchwork Tue Oct 26 14:20:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Laatz X-Patchwork-Id: 102934 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B4CA0547; Tue, 26 Oct 2021 16:35:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1889040E0F; Tue, 26 Oct 2021 16:35:13 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2C8D2407FF for ; Tue, 26 Oct 2021 16:35:10 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="229870538" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="229870538" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 07:20:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="497357211" Received: from silpixa00401122.ir.intel.com ([10.55.128.10]) by orsmga008.jf.intel.com with ESMTP; 26 Oct 2021 07:20:47 -0700 From: Kevin Laatz To: dev@dpdk.org Cc: bruce.richardson@intel.com, Kevin Laatz Date: Tue, 26 Oct 2021 14:20:45 +0000 Message-Id: <20211026142045.2996949-1-kevin.laatz@intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When checking if the DMA device is active, the result of the operand will always be zero since the err_code is truncated to 8 bits which makes checking the 31st bit impossible. This is fixed by changing the type of err_code to uint32_t so that it is not truncated. Coverity issue: 373657 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson Reviewed-by: Conor Walsh --- drivers/dma/idxd/idxd_pci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 1aabacee41..9ca1ec64e9 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -22,7 +22,7 @@ const struct rte_pci_id pci_id_idxd_map[] = { static inline int idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command) { - uint8_t err_code; + uint32_t err_code; uint16_t qid = idxd->qid; int i = 0; @@ -37,7 +37,8 @@ idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command) if (++i >= 1000) { IDXD_PMD_ERR("Timeout waiting for command response from HW"); rte_spinlock_unlock(&idxd->u.pci->lk); - return err_code; + err_code &= CMDSTATUS_ERR_MASK; + return -err_code; } } while (err_code & CMDSTATUS_ACTIVE_MASK); rte_spinlock_unlock(&idxd->u.pci->lk);