diff mbox series

[v3] doc: document a limitation for a meter with RSS action

Message ID 20211026093106.124791-1-lizh@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series [v3] doc: document a limitation for a meter with RSS action |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing warning Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS

Commit Message

Li Zhang Oct. 26, 2021, 9:31 a.m. UTC 
  A meter policy with RSS/Queue action is not supported
when dv_xmeta_en is not zero.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Oct. 26, 2021, 9:51 a.m. UTC | #1 
26/10/2021 11:31, Li Zhang:
> A meter policy with RSS/Queue action is not supported
> when dv_xmeta_en is not zero.

It is still not explaining why.

> 
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.

It is still not enclosed like this: ``dv_xmeta_en``

Don't you think "enabled" is better than "not zero"?
Li Zhang Oct. 26, 2021, 10:12 a.m. UTC | #2 
Thanks Thomas.
Will update the following commit-log in patch v4

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows (one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table, it cannot split flow and cannot support
dv_xmeta_en enabled.


Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, October 26, 2021 5:51 PM
To: Li Zhang <lizh@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v3] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


26/10/2021 11:31, Li Zhang:
> A meter policy with RSS/Queue action is not supported when dv_xmeta_en 
> is not zero.

It is still not explaining why.

>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.

It is still not enclosed like this: ``dv_xmeta_en``

Don't you think "enabled" is better than "not zero"?
diff mbox series

Patch

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..5d1d3a7f0e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@  Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.