net/bnxt: fix RSS behavior on Thor
Checks
Commit Message
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Move the Rx queue state update before bnxt_setup_one_vnic()
is called. For Thor, rxq->rx_started and eth_dev->data->rx_queue_state[]
needs to be set for all queues before bnxt_hwrm_vnic_cfg() or
bnxt_vnic_rss_configure() are called.
Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
Comments
On Mon, Oct 25, 2021 at 9:54 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Move the Rx queue state update before bnxt_setup_one_vnic()
> is called. For Thor, rxq->rx_started and eth_dev->data->rx_queue_state[]
> needs to be set for all queues before bnxt_hwrm_vnic_cfg() or
> bnxt_vnic_rss_configure() are called.
>
> Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 5a34bb9..668e3aa 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -790,6 +790,16 @@ static int bnxt_start_nic(struct bnxt *bp)
> goto err_out;
> }
>
> + for (j = 0; j < bp->rx_nr_rings; j++) {
> + struct bnxt_rx_queue *rxq = bp->rx_queues[j];
> +
> + if (!rxq->rx_deferred_start) {
> + bp->eth_dev->data->rx_queue_state[j] =
> + RTE_ETH_QUEUE_STATE_STARTED;
> + rxq->rx_started = true;
> + }
> + }
> +
> /* default vnic 0 */
> rc = bnxt_setup_one_vnic(bp, 0);
> if (rc)
> @@ -813,16 +823,6 @@ static int bnxt_start_nic(struct bnxt *bp)
> }
> }
>
> - for (j = 0; j < bp->rx_nr_rings; j++) {
> - struct bnxt_rx_queue *rxq = bp->rx_queues[j];
> -
> - if (!rxq->rx_deferred_start) {
> - bp->eth_dev->data->rx_queue_state[j] =
> - RTE_ETH_QUEUE_STATE_STARTED;
> - rxq->rx_started = true;
> - }
> - }
> -
> rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL);
> if (rc) {
> PMD_DRV_LOG(ERR,
> --
> 2.10.1
>
@@ -790,6 +790,16 @@ static int bnxt_start_nic(struct bnxt *bp)
goto err_out;
}
+ for (j = 0; j < bp->rx_nr_rings; j++) {
+ struct bnxt_rx_queue *rxq = bp->rx_queues[j];
+
+ if (!rxq->rx_deferred_start) {
+ bp->eth_dev->data->rx_queue_state[j] =
+ RTE_ETH_QUEUE_STATE_STARTED;
+ rxq->rx_started = true;
+ }
+ }
+
/* default vnic 0 */
rc = bnxt_setup_one_vnic(bp, 0);
if (rc)
@@ -813,16 +823,6 @@ static int bnxt_start_nic(struct bnxt *bp)
}
}
- for (j = 0; j < bp->rx_nr_rings; j++) {
- struct bnxt_rx_queue *rxq = bp->rx_queues[j];
-
- if (!rxq->rx_deferred_start) {
- bp->eth_dev->data->rx_queue_state[j] =
- RTE_ETH_QUEUE_STATE_STARTED;
- rxq->rx_started = true;
- }
- }
-
rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL);
if (rc) {
PMD_DRV_LOG(ERR,