diff mbox series

eventdev: fix free of adapters storage

Message ID 20211020202021.1205135-1-erik.g.carrillo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series eventdev: fix free of adapters storage |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Carrillo, Erik G Oct. 20, 2021, 8:20 p.m. UTC 
  Fix a typo that can cause the hugepage memory that backs the adapters
array to be freed unexpectedly.

Fixes: e9caa6a09a "eventdev: move timer adapters memory to hugepage")

Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
 lib/eventdev/rte_event_timer_adapter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pavan Nikhilesh Bhagavatula Oct. 21, 2021, 7:34 a.m. UTC | #1 
>-----Original Message-----
>From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>Sent: Thursday, October 21, 2021 1:50 AM
>To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
>Bhagavatula <pbhagavatula@marvell.com>
>Cc: dev@dpdk.org
>Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
>
>External Email
>
>----------------------------------------------------------------------
>Fix a typo that can cause the hugepage memory that backs the adapters
>array to be freed unexpectedly.
>
>Fixes: e9caa6a09a "eventdev: move timer adapters memory to
>hugepage")
>
>Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

LGTM, Jerin please squash as the series is not in main branch yet.

Thanks.

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> lib/eventdev/rte_event_timer_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/eventdev/rte_event_timer_adapter.c
>b/lib/eventdev/rte_event_timer_adapter.c
>index 86b6c3fc6f..0e21b7c475 100644
>--- a/lib/eventdev/rte_event_timer_adapter.c
>+++ b/lib/eventdev/rte_event_timer_adapter.c
>@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
>rte_event_timer_adapter *adapter)
> 	ret = 0;
> 	for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> 		if (adapters[i].allocated)
>-			ret = adapter[i].allocated;
>+			ret = adapters[i].allocated;
>
> 	if (!ret) {
> 		rte_free(adapters);
>--
>2.23.0
Jerin Jacob Oct. 21, 2021, 8:43 a.m. UTC | #2 
On Thu, Oct 21, 2021 at 1:05 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> >Sent: Thursday, October 21, 2021 1:50 AM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
> >Bhagavatula <pbhagavatula@marvell.com>
> >Cc: dev@dpdk.org
> >Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Fix a typo that can cause the hugepage memory that backs the adapters
> >array to be freed unexpectedly.
> >
> >Fixes: e9caa6a09a "eventdev: move timer adapters memory to
> >hugepage")
> >
> >Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> LGTM, Jerin please squash as the series is not in main branch yet.

Thanks Eric. Squashed the patch in the series in next-event


>
> Thanks.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> >---
> > lib/eventdev/rte_event_timer_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/eventdev/rte_event_timer_adapter.c
> >b/lib/eventdev/rte_event_timer_adapter.c
> >index 86b6c3fc6f..0e21b7c475 100644
> >--- a/lib/eventdev/rte_event_timer_adapter.c
> >+++ b/lib/eventdev/rte_event_timer_adapter.c
> >@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
> >rte_event_timer_adapter *adapter)
> >       ret = 0;
> >       for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> >               if (adapters[i].allocated)
> >-                      ret = adapter[i].allocated;
> >+                      ret = adapters[i].allocated;
> >
> >       if (!ret) {
> >               rte_free(adapters);
> >--
> >2.23.0
>
diff mbox series

Patch

diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c
index 86b6c3fc6f..0e21b7c475 100644
--- a/lib/eventdev/rte_event_timer_adapter.c
+++ b/lib/eventdev/rte_event_timer_adapter.c
@@ -407,7 +407,7 @@  rte_event_timer_adapter_free(struct rte_event_timer_adapter *adapter)
 	ret = 0;
 	for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
 		if (adapters[i].allocated)
-			ret = adapter[i].allocated;
+			ret = adapters[i].allocated;
 
 	if (!ret) {
 		rte_free(adapters);