diff mbox series

editorconfig: bump line length to 100

Message ID 20211020134840.2421686-1-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series editorconfig: bump line length to 100 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-spell-check-testing warning Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Bruce Richardson Oct. 20, 2021, 1:48 p.m. UTC 
  Since we allow line lengths of up to 100, adjust the editorconfig to use
that value, to save editors (such as vim) from automatically wrapping
lines at 80 characters when typing.

Since python checkers all seem to expect 79 character lines max, add for
python only a 79-char max line length.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .editorconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Andrew Rybchenko Oct. 20, 2021, 1:57 p.m. UTC | #1 
On 10/20/21 4:48 PM, Bruce Richardson wrote:
> Since we allow line lengths of up to 100, adjust the editorconfig to use
> that value, to save editors (such as vim) from automatically wrapping
> lines at 80 characters when typing.

DPDK_CHECKPATCH_LINE_LENGTH default is 80 in
devtools/checkpatches.sh

> 
> Since python checkers all seem to expect 79 character lines max, add for
> python only a 79-char max line length.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  .editorconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/.editorconfig b/.editorconfig
> index 5101630c8c..ab41c95085 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -11,11 +11,12 @@ trim_trailing_whitespace = true
>  charset = utf-8
>  indent_style = tab
>  tab_width = 8
> -max_line_length = 80
> +max_line_length = 100
>  
>  [*.py]
>  indent_style = space
>  indent_size = 4
> +max_line_length = 79
>  
>  [meson.build]
>  indent_style = space
>
Bruce Richardson Oct. 20, 2021, 2:11 p.m. UTC | #2 
On Wed, Oct 20, 2021 at 04:57:41PM +0300, Andrew Rybchenko wrote:
> On 10/20/21 4:48 PM, Bruce Richardson wrote:
> > Since we allow line lengths of up to 100, adjust the editorconfig to use
> > that value, to save editors (such as vim) from automatically wrapping
> > lines at 80 characters when typing.
> 
> DPDK_CHECKPATCH_LINE_LENGTH default is 80 in
> devtools/checkpatches.sh
> 

Yes, but all the CIs run with it set to 100.
Bruce Richardson Oct. 20, 2021, 2:14 p.m. UTC | #3 
On Wed, Oct 20, 2021 at 04:57:41PM +0300, Andrew Rybchenko wrote:
> On 10/20/21 4:48 PM, Bruce Richardson wrote:
> > Since we allow line lengths of up to 100, adjust the editorconfig to use
> > that value, to save editors (such as vim) from automatically wrapping
> > lines at 80 characters when typing.
> 
> DPDK_CHECKPATCH_LINE_LENGTH default is 80 in
> devtools/checkpatches.sh
> 
I'll do a v2 with that changed in it too, just to keep things consistent.
It better reflects the state of reality in the code base.

/Bruce
diff mbox series

Patch

diff --git a/.editorconfig b/.editorconfig
index 5101630c8c..ab41c95085 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -11,11 +11,12 @@  trim_trailing_whitespace = true
 charset = utf-8
 indent_style = tab
 tab_width = 8
-max_line_length = 80
+max_line_length = 100
 
 [*.py]
 indent_style = space
 indent_size = 4
+max_line_length = 79
 
 [meson.build]
 indent_style = space