From patchwork Tue Oct 12 21:14:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 101274 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B1BAA0C4D; Tue, 12 Oct 2021 23:14:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC8714114D; Tue, 12 Oct 2021 23:14:45 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 4F6134111F for ; Tue, 12 Oct 2021 23:14:42 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id v20so378992plo.7 for ; Tue, 12 Oct 2021 14:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=ZXmOkd0vlm01A4WP/IsphuPKakn3jUgK2Gk2X62VBOE=; b=Hf/1BFAj5RnaX2EvbTMuSGNBeu+rAvWEdATIwf3Nl4VRj7Hm+9jFlkKZrH63TuuOmo dCdhQ9erEWnEbUB4rsKGleMRpdQEOJ7/SqFbrwumw4X51ri+dJK9bPGZejCFS5aHS4VZ gYm+h4kEnFDQknhWYD/gwSclE/umzww+kk/Lg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=ZXmOkd0vlm01A4WP/IsphuPKakn3jUgK2Gk2X62VBOE=; b=cs2W/nGhfuY8HkNuiRYAjH0HCUFGOArt46dSD+VPmk45BtkLMSPlgpb79X2pzoPpdU dVfYI5FIHwyqgHSoJaNjBsxnVvDEcTkwOTGyv6+KsHHAKghhQIP2BILqAczRmDtEVnjR LL9yoLy4chVYtKaGT/ap0nVk7ryltMg99GFePyzcTdsoO6auTFmKEuMepgRMfeSFM3CE O/7RUyKDz/LYC+B7PsuAoVLjiASjm2q4KUe/pXF7H/dJB18rn9X4fEberPLV7VaHXJQE 3P5drObm7Y7N8D+vgOumMk5RfbqOIFDYOgdTulTRmkUmDecpRPofPrxdkPXc7LXEkfW8 PgGA== X-Gm-Message-State: AOAM531bxb8WM/6uutK722bJf9NTUfomN+4zrMqF0n4gIM8Us8aBc40H cfA8PeWVWzTcKb2BmaEHIB0F5/A62ALSkO5GqnGC2XEo8xq7vPiNMAWXt2rIeer96KKp3C+6lu4 tQXE5Q96WvY05zo8E3EICSgrXkOpOqQKQFUF93vTmwQpEUzO7ER+IeLsaXMpF8kI= X-Google-Smtp-Source: ABdhPJxOy/4d20IzBlimX1gOxjMh3Z84QhLUglWo+eRRKjE/Nv9hLNYAudKpwzhZZ1pHhZePHRsvRQ== X-Received: by 2002:a17:90b:390b:: with SMTP id ob11mr8794459pjb.145.1634073281228; Tue, 12 Oct 2021 14:14:41 -0700 (PDT) Received: from localhost.localdomain ([136.52.99.246]) by smtp.gmail.com with ESMTPSA id f18sm7585705pfa.60.2021.10.12.14.14.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Oct 2021 14:14:40 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Lance Richardson Date: Tue, 12 Oct 2021 14:14:35 -0700 Message-Id: <20211012211436.70846-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20211012211436.70846-1-ajit.khaparde@broadcom.com> References: <20211012211436.70846-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [dpdk-dev] [PATCH v3 2/3] net/bnxt: fix Rx queue state on start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index aa7e7fdc85..a98f93ab29 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -482,12 +482,6 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; else vnic->rx_queue_cnt++; - - if (!rxq->rx_deferred_start) { - bp->eth_dev->data->rx_queue_state[j] = - RTE_ETH_QUEUE_STATE_STARTED; - rxq->rx_started = true; - } } PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); @@ -824,6 +818,16 @@ static int bnxt_start_nic(struct bnxt *bp) } } + for (j = 0; j < bp->rx_nr_rings; j++) { + struct bnxt_rx_queue *rxq = bp->rx_queues[j]; + + if (!rxq->rx_deferred_start) { + bp->eth_dev->data->rx_queue_state[j] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_started = true; + } + } + rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); if (rc) { PMD_DRV_LOG(ERR,