[v5,2/4] security: build on Windows

Message ID 20211006223544.1882-3-u9012063@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v5,1/4] security: use the net library for IP structs |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

William Tu Oct. 6, 2021, 10:35 p.m. UTC
  From: Tal Shnaiderman <talshn@nvidia.com>

Build the security library on Windows.

Remove unneeded export from version file.

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: William Tu <u9012063@gmail.com>
---
 lib/meson.build          | 1 +
 lib/security/version.map | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)
  

Comments

Thomas Monjalon Oct. 7, 2021, 7:44 a.m. UTC | #1
07/10/2021 00:35, William Tu:
> From: Tal Shnaiderman <talshn@nvidia.com>
> 
> Build the security library on Windows.
> 
> Remove unneeded export from version file.

To be more precise, it is unneeded because they are inline functions.

> --- a/lib/security/version.map
> +++ b/lib/security/version.map
> @@ -1,13 +1,11 @@
>  DPDK_22 {
>  	global:
>  
> -	rte_security_attach_session;
>  	rte_security_capabilities_get;
>  	rte_security_capability_get;
>  	rte_security_session_create;
>  	rte_security_session_destroy;
>  	rte_security_session_get_size;
> -	rte_security_set_pkt_metadata;
>  
>  	local: *;
>  };
> @@ -19,7 +17,6 @@ EXPERIMENTAL {
>  	__rte_security_set_pkt_metadata;
>  	rte_security_dynfield_offset;
>  	rte_security_dynfield_register;
> -	rte_security_get_userdata;
>  	rte_security_session_stats_get;
>  	rte_security_session_update;
>  };
  

Patch

diff --git a/lib/meson.build b/lib/meson.build
index 9c4841fe40..8183dd92da 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -86,6 +86,7 @@  if is_windows
             'latencystats',
             'pdump',
             'stack',
+            'security',
     ] # only supported libraries for windows
 endif
 
diff --git a/lib/security/version.map b/lib/security/version.map
index b377be602a..a1f46bfd27 100644
--- a/lib/security/version.map
+++ b/lib/security/version.map
@@ -1,13 +1,11 @@ 
 DPDK_22 {
 	global:
 
-	rte_security_attach_session;
 	rte_security_capabilities_get;
 	rte_security_capability_get;
 	rte_security_session_create;
 	rte_security_session_destroy;
 	rte_security_session_get_size;
-	rte_security_set_pkt_metadata;
 
 	local: *;
 };
@@ -19,7 +17,6 @@  EXPERIMENTAL {
 	__rte_security_set_pkt_metadata;
 	rte_security_dynfield_offset;
 	rte_security_dynfield_register;
-	rte_security_get_userdata;
 	rte_security_session_stats_get;
 	rte_security_session_update;
 };